From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type Date: Sat, 12 Nov 2022 02:10:02 -0800 Message-ID: References: <83iljko87o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16979"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59212@debbugs.gnu.org To: Eli Zaretskii , Gabriel , Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 12 11:11:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otnTv-0004Fn-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Nov 2022 11:11:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otnTd-0008ID-3J; Sat, 12 Nov 2022 05:11:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otnTb-0008Eq-IH for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 05:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otnTb-0004fj-6j for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 05:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otnTa-0004ZV-I7 for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 05:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 10:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59212-submit@debbugs.gnu.org id=B59212.166824781117502 (code B ref 59212); Sat, 12 Nov 2022 10:11:02 +0000 Original-Received: (at 59212) by debbugs.gnu.org; 12 Nov 2022 10:10:11 +0000 Original-Received: from localhost ([127.0.0.1]:47358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otnSk-0004YB-JD for submit@debbugs.gnu.org; Sat, 12 Nov 2022 05:10:10 -0500 Original-Received: from mail-ot1-f41.google.com ([209.85.210.41]:41927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otnSj-0004Xq-5Y for 59212@debbugs.gnu.org; Sat, 12 Nov 2022 05:10:09 -0500 Original-Received: by mail-ot1-f41.google.com with SMTP id p27-20020a056830319b00b0066d7a348e20so117245ots.8 for <59212@debbugs.gnu.org>; Sat, 12 Nov 2022 02:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=qI5F5qZxT/Po5KwXpeu535T+XDtyoF7OOpY3QYSxUjY=; b=nzVOhrz87P5nroZNTgqIwz/b5M+1Mw6Y3MhgdkRuN0JMgP/N/mWugkFAAil229W84G nyL3MLmX2WGOFBIMUJFrD2qb+oMyg6DyPko3NFxW3S9yvkwPoSUye1hUzIOyrpx3J5AJ P2TPhFiox8z9EoGaygB4G8u4jzZ2vhrZmTugVLS3XxpkUZrdOvDrQcSD0CYiacI5Jmde SoEKLT12sUwhuRg8Limtk+ALJQhwGVoVVL9OQ3XpOGNthJH9tdgMKxLumw/BjfZ4v7wa Dj7JlC6qUjSHdurazrf6uUKK4m7HuWyRO1eozYeuJFBFKLL2W8nDx+/s5Dt2icpCRdQy cEMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qI5F5qZxT/Po5KwXpeu535T+XDtyoF7OOpY3QYSxUjY=; b=kELRsjISC1AhSiAKh86kMmVyYasoIOzFq8rhKdtYWxuQWIBg7GhIiC7vLCRvkLVgCu NkkQVYWy1w6jevf+7OSrtaV1DjzhuSLsDxrr/vPmxYpaM16BVtSSy2tcWtnFJKfAq9Su rFxMXEj/DzfS0nFJCEvhZvN3+NKIuAKIHW+i8RhHVNtdDSDZd9v7Aei24NUTfUN7+QBQ 94syZxig72uXjMM3vSiZfSxuA/pnZtyXZGXSdVvFnho4O5Ghhbhnd37WNEnvdyKNrx6Q Zoox76uUwlGMPQpordybWeCsCsbn5ZQp2sUlg5zqml9bg5ZNqgt6DYumItLGder5hpDD /NNQ== X-Gm-Message-State: ANoB5plHd9VjCSy6gcSg3yp3VwFJ0K/TdYghSeV98g+bxeW/Im+59q+Z YRUmaTiUr/aKzDK2C/A1EhufHN18VjwTks8Q+Cg= X-Google-Smtp-Source: AA0mqf4p2WGcRaHRflp7Iz98N7ji9BxrmNfQuLN2iSaUu8XMAbQamvfegGUXE+NqQUBlhYWLStZipBhWv2kTq4pMWUY= X-Received: by 2002:a9d:6399:0:b0:661:c48b:12db with SMTP id w25-20020a9d6399000000b00661c48b12dbmr2948538otk.105.1668247803464; Sat, 12 Nov 2022 02:10:03 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Nov 2022 02:10:02 -0800 In-Reply-To: <83iljko87o.fsf@gnu.org> X-Hashcash: 1:20:221112:gabriel376@hotmail.com::7B7BOIyXBHQUzalV:3h5l X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247645 Archived-At: severity 59212 wishlist thanks Eli Zaretskii writes: >> From: Gabriel >> Date: Sat, 12 Nov 2022 05:56:22 -0300 >> >> Description: >> Not a bug per se, but a suggestion for improvement in how Bookmark >> displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659). >> >> Currently, bookmark-bmenu-list (C-x r l) displays a column named Type, >> which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc) >> except for regular files, in which an empty string is displayed. I >> believe the current behavior could be improved by displaying a default >> value ("Files") to make the interface more uniform, explicit and to >> avoid confusion. >> >> Steps: >> 1) emacs -Q >> 2) M-x eshell >> 3) C-x r m >> 4) C-x C-f ~/foo.bar >> 5) C-x r m >> 6) C-x r b >> >> These steps will add two bookmarks (eshell and foo.bar) and will open >> the Bookmarks list. The Type column will have values "" and >> "Eshell". After the patch below is applied, the Type column will have >> values "File" and "Eshell". > > Thanks. > > Karl, any comments? I'm not Karl, but I've experimented with something similar before and I found two things: 1. I had to add a type for Dired bookmarks (which are not Files) to avoid confusion. 2. Using a default name (I also used "Files", IIRC), just made my long list of bookmarks more busy with little benefit. If anything, it made it harder to navigate, as it was harder to make out the "special" types of bookmarks. So all in all, I was not a huge fan of the change. If we want to add this, I suggest adding a defcustom so that users can enable or disable this functionality to their liking (or change "Files" into something else). I might prefer to disable it, for example.