From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master ffbea0d: Tweak two time.el tests Date: Wed, 21 Oct 2020 09:40:20 -0700 Message-ID: References: <20201021152239.25885.23627@vcs0.savannah.gnu.org> <20201021152241.4FFC8209D4@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33494"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 21 18:47:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVHGW-0008ct-D0 for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Oct 2020 18:47:08 +0200 Original-Received: from localhost ([::1]:54612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVHGV-0008Ew-Ev for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Oct 2020 12:47:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVHA0-00015u-Sf for emacs-devel@gnu.org; Wed, 21 Oct 2020 12:40:24 -0400 Original-Received: from mail-ej1-f42.google.com ([209.85.218.42]:37698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVH9y-0006ZM-VC for emacs-devel@gnu.org; Wed, 21 Oct 2020 12:40:24 -0400 Original-Received: by mail-ej1-f42.google.com with SMTP id e22so4195000ejr.4 for ; Wed, 21 Oct 2020 09:40:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ODNVJ5AXdeRwDTmNnplGLQLwdsQvtELVQVF/5Ttp3ts=; b=Bl0Hyy61fNvSSH2/7glUDaosBIvG4YYoKaLLGFZrh8Mo/TLa6jzxT6ZqJfdDt6AxG/ eKEDVJVsr31Txrh1VQIfzlwfSyYqMuS4wRrx02vcLChqtQ1ljTMy8V2f3FP91xKg2SE4 JfwdlzboTCMcTn5sNs1ViMp1xLqQPAhLgLJJ8DBb2+oeoh7tM/a9D8akLulqBXgiaj6Q l6ui1v7lFL4cNtdnEIhnvnmRXaWwC0lQVKFPIJbVakYvbaDmP+Y+qe7LAWay0+JE1+KE U32yE2tDJZwiNdQ6TEY/d0io028uxIrHfoBKrOdwC8LoIn820NHQO+uMasy3a+NcEfIo iEgg== X-Gm-Message-State: AOAM5334eRshcmU4tgI+w7b9SmoBF/I7Hc3/71813VUTfw42+97tgEaB oPdVdIGtZmghZblRjJxZJJ1iVF7Za+/l8jcJQQY= X-Google-Smtp-Source: ABdhPJwFJSjfN0QKJTMdtvyjZeBDvxWZz5l5WCZPSR7ndLRgnTffMLtHEcWCas/Zf2oxQ+G2JMmCPedqBDm+6dTn5kk= X-Received: by 2002:a17:906:f90a:: with SMTP id lc10mr4521983ejb.272.1603298421472; Wed, 21 Oct 2020 09:40:21 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 21 Oct 2020 09:40:20 -0700 In-Reply-To: Received-SPF: pass client-ip=209.85.218.42; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f42.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/21 12:40:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258241 Archived-At: Stefan Monnier writes: >> * test/lisp/time-tests.el (time-tests-display-time-update--load) >> (time-tests-display-time-update): Tweak tests. > > Context already makes it clear that `time-tests-display-time-update` and > `time-tests-display-time-update--load` are tests, and that you're making > some change in them. So "Tweak tests" doesn't say much, really. Yes, I realized that as well (after pushing). I should probably have said "Tweak tests to be more strict" or something along those lines.