From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master ffbea0d: Tweak two time.el tests
Date: Wed, 21 Oct 2020 09:40:20 -0700 [thread overview]
Message-ID: <CADwFkm=t2akGbwxnpZPw4JnGe36fG0XFAt9yLc9-aMBoyEooow@mail.gmail.com> (raw)
In-Reply-To: <jwveelr8ssl.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * test/lisp/time-tests.el (time-tests-display-time-update--load)
>> (time-tests-display-time-update): Tweak tests.
>
> Context already makes it clear that `time-tests-display-time-update` and
> `time-tests-display-time-update--load` are tests, and that you're making
> some change in them. So "Tweak tests" doesn't say much, really.
Yes, I realized that as well (after pushing). I should probably have
said "Tweak tests to be more strict" or something along those lines.
prev parent reply other threads:[~2020-10-21 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201021152239.25885.23627@vcs0.savannah.gnu.org>
[not found] ` <20201021152241.4FFC8209D4@vcs0.savannah.gnu.org>
2020-10-21 16:11 ` master ffbea0d: Tweak two time.el tests Stefan Monnier
2020-10-21 16:40 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=t2akGbwxnpZPw4JnGe36fG0XFAt9yLc9-aMBoyEooow@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.