From: Stefan Kangas <stefan@marxist.se>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 36603@debbugs.gnu.org
Subject: bug#36603: [PATCH] Simplify calling convention of describe_map
Date: Tue, 20 Aug 2019 18:02:56 +0200 [thread overview]
Message-ID: <CADwFkm=qyHXTUK_ntPn7aY5i83nw7BARJCNye5bP9RvSS0SPuw@mail.gmail.com> (raw)
In-Reply-To: <85mug3kesc.fsf@gmail.com>
Noam Postavsky <npostavs@gmail.com> writes:
>
> Noam Postavsky <npostavs@gmail.com> writes:
>
> > Stefan Kangas <stefan@marxist.se> writes:
> >
> >> + Lisp_Object seen_orig = Qnil;
> >> + Lisp_Object *seen = &seen_orig;
> >
> > Do we really need the seen_orig variable? It looks like there is no
> > reason for having seen as a pointer at all, but maybe I'm missing
> > something.
>
> Actually, maybe the patch is wrong (i.e., over-simplifying), because it
> has describe_map start with a fresh seen pointer each time; but the
> current code passes the same pointer to each describe_map call in a
> loop.
Thanks for that feedback. I'll take another look and get back to you.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2019-08-20 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 17:34 bug#36603: [PATCH] Simplify calling convention of describe_map Stefan Kangas
2019-07-11 17:37 ` Stefan Kangas
2019-08-20 15:32 ` Noam Postavsky
2019-08-20 16:00 ` Noam Postavsky
2019-08-20 16:02 ` Stefan Kangas [this message]
2019-11-11 18:44 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=qyHXTUK_ntPn7aY5i83nw7BARJCNye5bP9RvSS0SPuw@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=36603@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.