From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries Date: Mon, 29 Jan 2024 15:13:56 -0500 Message-ID: References: <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org> <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23789"; mail-complaints-to="usenet@ciao.gmane.io" To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 29 21:14:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUY1w-00060m-Nz for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Jan 2024 21:14:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUY15-0006HL-AO; Mon, 29 Jan 2024 15:14:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUY12-0006H1-CU for emacs-devel@gnu.org; Mon, 29 Jan 2024 15:14:00 -0500 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUY10-0005Vq-U4 for emacs-devel@gnu.org; Mon, 29 Jan 2024 15:14:00 -0500 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-55c33773c0aso3152960a12.1 for ; Mon, 29 Jan 2024 12:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706559237; x=1707164037; darn=gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=qlVqEgKisjyHnrP+taDRMDhlQTRzalduBbRijZUCfuw=; b=PWfS+RtjcGJw8YObA5el3H/cPzlVlhTHby8i0UgGx0cmj52vc4ioCRX2xYZnY6cCSs ZkTascqw3lcuBKTnvYdnO0Ne1JNJsDh5/ZBz77rkPNdSVpJKd+hwsrr3VWXVVZ2p0RcJ Gy3yVhGyKh22aw6KTNidVm/0V31jl/8IVvuTTB/WedPAaiQ0DvHRtiqAXe1regs2bh+0 lnmwGZWYIUQkfgDvG24Aii4Rl/MLKRAdBiA+sgA94bcAxe7sDXsrmPudJeYdWqF3NLqM fTGbj7NKUl7iq7/A9wEGREeJlvjTPsANOGUsAjCesCSus693aGxWh09cm/O/4QppvgWT s1eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706559237; x=1707164037; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qlVqEgKisjyHnrP+taDRMDhlQTRzalduBbRijZUCfuw=; b=JI4B+cygXjmxiEoOrIMdipI84ix88xfZlz6Oy33kgMX+OJhGF2YVw94GXmPh79EQkv wEF0jK1/XZeRC8hqSlsM3NYYbu6OVqqzbdm/Jt/aM7JcLy2bKxNTTAnrkuPhmiDXYGUI ehYwOrRBkhjWoALLzOC2OVQLmCUN7LUaWGO+uG1mcEGepifM/7PX3oY8Z31hozqj/oCs G3fMM48Wk6ZKUazDeMmsCAAolcr4l/cX73vHv5683JLMR2HoW1Zyk3yaSHdaAIv0pnW/ Asbz4b5gYNviLqHUJVAl13YWtSAxx+/2ducSYtfilcMDFxw8uUgJRj7mAM28HnazNbsg 80TQ== X-Gm-Message-State: AOJu0YzLi5fnet3HpbwLd/64t/xN5thvLRoS2CMNxbhDKFFgqj5qwn7/ eejwLgjW/A+aJb8XYEBNueEL2yWDvqQezAsLUguSynrWkYGIy9MEXfBQIg+mk3ifOUh11deFV6q E0ChvUflTj2TvI73UOYpuGz1RhUw= X-Google-Smtp-Source: AGHT+IFT7xtZhtttZEYcnimRD6KpoVYIuDn1LLeSELM276Cnw/gSbeJEdIZlt2I0xLmkLXFlxjuFEDG7+kdipVEcqaY= X-Received: by 2002:a05:6402:79a:b0:55f:2aa0:caf1 with SMTP id d26-20020a056402079a00b0055f2aa0caf1mr1053157edy.17.1706559236870; Mon, 29 Jan 2024 12:13:56 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Jan 2024 15:13:56 -0500 In-Reply-To: <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315608 Archived-At: Po Lu via Mailing list for Emacs changes writes: > branch: master > commit 78fc49407b8ef8ec649fe70fcce09101801dbc05 > Author: Po Lu > Commit: Po Lu > > Improve filling of ChangeLog entries > > * lisp/vc/log-edit.el (log-edit--insert-filled-defuns): Rewrite > completely. > (log-edit-fill-entry): Abandon pcase and cl-lib. Speaking of commit messages, the above is not at all clear to me. More specifically, the word "improve" seems open to interpretation. Is it just a rewrite to "abandon pcase and cl-lib"? If yes, I think that is what should have gone on the first line summary. If that's not it, what is it that has been improved?