From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: Zero byte-compiler warnings in the test suite
Date: Tue, 21 Dec 2021 05:39:08 -0800 [thread overview]
Message-ID: <CADwFkm=nubx_9iXb=h4DZp0bQWshZ1NLZ4nF7Lc=Nv+LCxk-cg@mail.gmail.com> (raw)
In-Reply-To: <87ilvigl3z.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
> But with a native-comp build (at least), I'm getting two
> warnings/errors on the current trunk:
>
> In toplevel form:
> lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:273:1: Warning: ‘defgeneric’ is an obsolete macro (as of 25.1); use ‘cl-defgeneric’ instead.
Strange, I don't see that here (with native-comp). Does this help?
diff --git a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
index e881e46a2d..bc89f23b58 100644
--- a/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
+++ b/test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
@@ -271,6 +271,7 @@ E-base2
(defclass E (E-base1 E-base2) () :method-invocation-order :breadth-first)
(with-suppressed-warnings ((obsolete defmethod)
+ (obsolete defgeneric)
(obsolete next-method-p)
(obsolete call-next-method))
(defmethod eitest-F ((_p E))
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
> Compiler-macro error for cl-typep: (error "Unknown type notatype")
I've seen these as well, but they weren't counted by compilation-mode so
I just sort of ignored them. It would be good to fix them as well of
course.
AFAICT, they come from here:
ELC+ELN lisp/emacs-lisp/pcase-tests.elc
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
Compiler-macro error for cl-typep: (error "Unknown type notatype")
GEN lisp/emacs-lisp/pcase-tests.log
Grepping for notatype leads me to:
./lisp/emacs-lisp/pcase-tests.el:111: ((cl-type
notatype) 'integer))))
Does anyone know what is going on here?
next prev parent reply other threads:[~2021-12-21 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 12:36 Zero byte-compiler warnings in the test suite Stefan Kangas
2021-12-21 13:09 ` Lars Ingebrigtsen
2021-12-21 13:39 ` Stefan Kangas [this message]
2021-12-21 13:49 ` Lars Ingebrigtsen
2021-12-21 15:11 ` Stefan Kangas
2021-12-21 15:41 ` Stefan Monnier
2021-12-22 5:07 ` Stefan Kangas
2021-12-22 17:40 ` Stefan Monnier
2021-12-22 22:11 ` Stefan Kangas
2021-12-23 0:07 ` Weird non-caught error in ERT (was: Zero byte-compiler warnings in the test suite) Stefan Monnier
2021-12-23 10:04 ` Philipp Stephani
2021-12-21 14:54 ` Zero byte-compiler warnings in the test suite Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=nubx_9iXb=h4DZp0bQWshZ1NLZ4nF7Lc=Nv+LCxk-cg@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.