From: Stefan Kangas <stefankangas@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Visuwesh <visuweshm@gmail.com>
Cc: emacs-devel@gnu.org, jao <jao@gnu.org>
Subject: Re: [elpa] externals/consult-recoll c5926ca3eb 1/2: format for size annotation
Date: Fri, 14 Oct 2022 19:57:29 -0700 [thread overview]
Message-ID: <CADwFkm=mT30X6Y9BOJ9gg9UM6yQLcGcp4CDoQGtAxGQGAFnBGA@mail.gmail.com> (raw)
In-Reply-To: <jwvczaup6se.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Visuwesh [2022-10-14 07:14:02] wrote:
>> [வியாழன் அக்டோபர் 13, 2022] Stefan Monnier wrote:
>>> I see we have `memory-report--format` which does something similar.
>>> I'm pretty sure we have other chunks of code doing the same elsewhere.
>>> Should Someone™ introduce a function in `subr.el` or somesuch to solve
>>> it once and for all?
>> Don't we already have `file-size-human-readable' for that?
>
> Ah, that's it, thanks!
> So Consult should simply use that instead of `consult-recoll--format-size`.
I changed `memory-report--format' to use `file-size-human-readable'
(commit 8300899953).
prev parent reply other threads:[~2022-10-15 2:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166569465562.12992.2240825905795534702@vcs2.savannah.gnu.org>
[not found] ` <20221013205735.EF3DEC03F23@vcs2.savannah.gnu.org>
2022-10-13 22:08 ` [elpa] externals/consult-recoll c5926ca3eb 1/2: format for size annotation Stefan Monnier
2022-10-14 1:44 ` Visuwesh
2022-10-14 19:15 ` Stefan Monnier
2022-10-14 20:04 ` jao
2022-10-15 2:57 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=mT30X6Y9BOJ9gg9UM6yQLcGcp4CDoQGtAxGQGAFnBGA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jao@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.