From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Thu, 14 Oct 2021 06:10:36 -0700 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <20211004081727.4F24921048@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <87lf2wkqwl.fsf@igel.home> <87ee8nlt4t.fsf@igel.home> <87zgrbyfkt.fsf@gnus.org> <87a6jblrow.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36561"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andreas Schwab , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 14 15:12:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mb0XX-0009Io-MA for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 15:12:55 +0200 Original-Received: from localhost ([::1]:40400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mb0XV-0005bo-IX for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 09:12:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb0VP-0003vm-Hw for emacs-devel@gnu.org; Thu, 14 Oct 2021 09:10:44 -0400 Original-Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:43673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mb0VN-0001iG-6R for emacs-devel@gnu.org; Thu, 14 Oct 2021 09:10:42 -0400 Original-Received: by mail-pf1-x42e.google.com with SMTP id 187so5389677pfc.10 for ; Thu, 14 Oct 2021 06:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=N800o1Xq7iJqK+20imueNz4nuFGffIjXRBJcvOMVL5E=; b=eP5pgIauVwaEqZmjueLj5l47FTFbZi0MTVs+rg+LdG56Ek0cH2PFKSbLKDFHCy0CRd 9H0iU8LjfKKIk/M5mh3MDXiSbWTtlWsyB/Z6CdOXOARKQgL8J03w7vhgW3jmi0qUwNcR AtovgoJ6UejD4qr46lIYtZtpmjKh1D7+8qyyfXEgJG3yLmbS5f6E28vgqQuWETGpNVDe JCuD32xI2KURWZ4mo9QJPxjbg2Vt7lJ7esp1z718V7ew5df+oCdYg0c7Aj+KF7Pmrt6p CWHumnMbyRV98FiaJ5ps2n018ibTHFOmWIjSSFBGeTGYgEjhA7udCFGeWVKGiWESPV4Q j7Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=N800o1Xq7iJqK+20imueNz4nuFGffIjXRBJcvOMVL5E=; b=yBmlmb7bAldkAKwr5OFymtwy7wfgB5q9eo0jrHRnH1ahWHpMmUrLiZAYeIKDNkpcWf o5mEkvZ4+Ygt88TXblANm/L7mw8FfwinQnSG63HPZ1VZwzi51/PPnZBJPmvPySSEbco5 W6P8+Im2yOCPYjC8UchdVLPuUUWGmdZUsS2LgELSSRxWIBShEyiU+J7Xe/ysEy3LxQhr VtC2/BkcX6ChDBVnK8hjft+1rZWLtWMhpgCwOMnQBQ7Osa8qGOqOKMrg6S/DQEvmQz/j ywtZEoCA2kjeAvfR5zgPQw7uX9QLLwrtiXgynXXFF5WxoIuIiW6w3KobRQooo1Zg86tR p4MQ== X-Gm-Message-State: AOAM533NNb71IbMX57U127tUHdtvFbLVTBY+KKOTzG1783eKI3VlsMqG 9Hwr2YbZ2y8KAfCZlIFewIS35dsmkQMmXn+4Nmk= X-Google-Smtp-Source: ABdhPJw6MJNm9e0OgNuM1r+cYEE00BADUcB23b25TWZ0pd/EdzsuvHKKWPSsTIVN/lNS4qgS5ClzDFAjMhxhXQHjADY= X-Received: by 2002:a63:7559:: with SMTP id f25mr1534657pgn.114.1634217037070; Thu, 14 Oct 2021 06:10:37 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 14 Oct 2021 06:10:36 -0700 In-Reply-To: <87a6jblrow.fsf@igel.home> Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=stefankangas@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277015 Archived-At: Andreas Schwab writes: >> Don't see the point in moving the entirety of a function body to another >> function. > > That's not what factoring is about. I understand that one-liners is your style, but I find it too terse to follow here. That's unfortunate, because I would like to understand what you are saying. In your first message you wrote "That needs to be factored out." When someone says "factor out", I understand this to mean that you move some specific part of one function into another function. Moreover, the word "that" seems to refer to only one part of the function. Now you seem to be talking about refactoring, which is a term that I understand to cover a wider set of types of changes. Could you perhaps elaborate on what you mean here?