From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#20150: 24.4: bookmarks: return from editing annotations (FIX INCLUDED) Date: Tue, 2 Jul 2019 05:23:59 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000003c4ca6058caa47b8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="82036"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 20150@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 02 06:29:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiAQA-000LDi-H2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 06:29:34 +0200 Original-Received: from localhost ([::1]:48784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiAQ9-0007V7-DX for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 00:29:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60147) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi9Pk-0006Z6-T1 for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 23:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hi9Pi-0000Xt-7k for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 23:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37607) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hi9Ph-0000Xf-Py for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 23:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hi9Ph-00037o-J2 for bug-gnu-emacs@gnu.org; Mon, 01 Jul 2019 23:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 03:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20150-submit@debbugs.gnu.org id=B20150.156203785911961 (code B ref 20150); Tue, 02 Jul 2019 03:25:01 +0000 Original-Received: (at 20150) by debbugs.gnu.org; 2 Jul 2019 03:24:19 +0000 Original-Received: from localhost ([127.0.0.1]:46428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi9P0-00036r-UQ for submit@debbugs.gnu.org; Mon, 01 Jul 2019 23:24:19 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:37861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hi9Oy-00036e-Od for 20150@debbugs.gnu.org; Mon, 01 Jul 2019 23:24:17 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id f17so1559276wme.2 for <20150@debbugs.gnu.org>; Mon, 01 Jul 2019 20:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ROiw/wnaluJ8txXhd5LzK80HY7EfADb7K41syHHRJKo=; b=VifjIPLg/B9okhJsLLtMCSh8qBTiWCC5CDkATb/dFddl765Bk6m9SOHDvFAb4Sg7K3 bq8DmZVThhbDGaMI+ypEZopRuGW1m7rMPJ5aVTgS3m5HQzPWuOpHAFzIqeoZSsG00bqY u8v/ZgFwHbcgqr/sI8ikgR4rA1CE5B2seZh3T326oHM0Hm/+mWUgy4VD+qn274ZC9AAl R8IoWRtwHaVb9LZFRf3CHZ3oAd4dntremATMjaP1wq6IrjV6dNAI8brNCwwjU3ojbopu 4x7toKo8y1QSmbzXapBOnMaSMlwHwyeBkXsaIY3vOREx+cJU5kIRvKYY+0YD0aWjO605 strQ== X-Gm-Message-State: APjAAAV6RZ0ldgUJFJIcNNXFKT10c2cBmD4bhvJ1hQKWCRLmufoiBpXY uMuUUlkjPg8cbFIcrRENYqwN3P9B8ne01l6GKTk= X-Google-Smtp-Source: APXvYqyZs/BgscarNpMfK/AbbCck3dOSnVk7wWsOLQRDRysCfiegvaaHwcIFMQn27VRy2YSjpoaJv8Cb+bTbLGvoZag= X-Received: by 2002:a1c:cb0c:: with SMTP id b12mr1431736wmg.93.1562037850993; Mon, 01 Jul 2019 20:24:10 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161947 Archived-At: --0000000000003c4ca6058caa47b8 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > > When completing a bookmark annotation edit, the point on the bmenu-list > > would move to point-max and the selected window would be wherever the > > annotation buffer had been displayed. > > I can confirm this bug, and suggest the attached fix. Please see this somewhat improved patch instead. Thanks, Stefan Kangas --0000000000003c4ca6058caa47b8 Content-Type: application/octet-stream; name="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-2.patch" Content-Disposition: attachment; filename="0001-Restore-focus-to-Bookmark-List-after-editing-annotat-2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxl8ylgt0 RnJvbSBmZWI4OTRhZTEwMTZjMmEwNzM1YjU4ZjBkYWJmMTFlNWY3NTBkNzViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDM6MDY6MzcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBS ZXN0b3JlIGZvY3VzIHRvIEJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyBhbm5vdGF0aW9uCgoq IGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24pOiBSZXN0 b3JlIGZvY3VzIHRvCkJvb2ttYXJrIExpc3QgYWZ0ZXIgZWRpdGluZyB0aGUgYW5ub3RhdGlvbi4g IEFsc28gdGFrZSBjYXJlIHRvIGRlbGV0ZQp3aW5kb3cgd2hlbiBuZWVkZWQsIGFuZCBtb3ZlIHBv aW50IGJhY2sgdG8gYm9va21hcmsuIChCdWcjMjAxNTApCgooYm9va21hcmstYW5ub3RhdGlvbi1u YW1lKTogSW1wcm92ZSBkb2NzdHJpbmcuCihib29rbWFyay1ibWVudS1idWZmZXIpOiBOZXcgdmFy aWFibGUuCihib29rbWFyay1ibWVudS1zdXJyZXB0aXRpb3VzbHktcmVidWlsZC1saXN0KQooYm9v a21hcmstYm1lbnUtbGlzdCk6IFVzZSBpdC4KLS0tCiBsaXNwL2Jvb2ttYXJrLmVsIHwgMjcgKysr KysrKysrKysrKysrKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygr KSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9ib29rbWFyay5lbCBiL2xpc3Av Ym9va21hcmsuZWwKaW5kZXggYmJlZjBhOTI3ZC4uZmFmN2Q1Njk2ZSAxMDA2NDQKLS0tIGEvbGlz cC9ib29rbWFyay5lbAorKysgYi9saXNwL2Jvb2ttYXJrLmVsCkBAIC05MDAsMTEgKzkwMCw5IEBA IGJvb2ttYXJrLWtpbGwtbGluZQogICAgICAgKGRlbGV0ZS1jaGFyIDEpKSkpCiAKIAotOzsgRGVm dmFycyB0byBhdm9pZCBjb21waWxhdGlvbiB3YXJuaW5nczoKIChkZWZ2YXIgYm9va21hcmstYW5u b3RhdGlvbi1uYW1lIG5pbAotICAiVmFyaWFibGUgaG9sZGluZyB0aGUgbmFtZSBvZiB0aGUgYm9v a21hcmsuCi1UaGlzIGlzIHVzZWQgaW4gYGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbicgdG8gcmVj b3JkIHRoZSBib29rbWFyawotd2hvc2UgYW5ub3RhdGlvbiBpcyBiZWluZyBlZGl0ZWQuIikKKyAg Ik5hbWUgb2YgYm9va21hcmsgd2hvc2UgYW5ub3RhdGlvbiBpcyBiZWluZyBlZGl0ZWQuCitUaGlz IGlzIHVzZWQgYnkgYGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbi1tb2RlJy4iKQogCiAKIChkZWZ1 biBib29rbWFyay1kZWZhdWx0LWFubm90YXRpb24tdGV4dCAoYm9va21hcmstbmFtZSkKQEAgLTk2 MywxMiArOTYxLDE5IEBAIGJvb2ttYXJrLXNlbmQtZWRpdGVkLWFubm90YXRpb24KICAgICAgIChm b3J3YXJkLWxpbmUgMSkpKQogICA7OyBUYWtlIG5vIGNoYW5jZXMgd2l0aCB0ZXh0IHByb3BlcnRp ZXMuCiAgIChsZXQgKChhbm5vdGF0aW9uIChidWZmZXItc3Vic3RyaW5nLW5vLXByb3BlcnRpZXMg KHBvaW50LW1pbikgKHBvaW50LW1heCkpKQotCShib29rbWFyay1uYW1lIGJvb2ttYXJrLWFubm90 YXRpb24tbmFtZSkpCisgICAgICAgIChib29rbWFyay1uYW1lIGJvb2ttYXJrLWFubm90YXRpb24t bmFtZSkKKyAgICAgICAgKG9sZC1idWZmZXIgKGN1cnJlbnQtYnVmZmVyKSkpCiAgICAgKGJvb2tt YXJrLXNldC1hbm5vdGF0aW9uIGJvb2ttYXJrLW5hbWUgYW5ub3RhdGlvbikKICAgICAoc2V0cSBi b29rbWFyay1hbGlzdC1tb2RpZmljYXRpb24tY291bnQKICAgICAgICAgICAoMSsgYm9va21hcmst YWxpc3QtbW9kaWZpY2F0aW9uLWNvdW50KSkKLSAgICAoYm9va21hcmstYm1lbnUtc3VycmVwdGl0 aW91c2x5LXJlYnVpbGQtbGlzdCkpCi0gIChraWxsLWJ1ZmZlciAoY3VycmVudC1idWZmZXIpKSkK KyAgICAocXVpdC13aW5kb3cpCisgICAgKHBvcC10by1idWZmZXIgKGdldC1idWZmZXIgYm9va21h cmstYm1lbnUtYnVmZmVyKSkKKyAgICAoYm9va21hcmstYm1lbnUtbGlzdCkKKyAgICAoZ290by1j aGFyIChwb2ludC1taW4pKQorICAgICh1bmxlc3MgKHRleHQtcHJvcGVydHktc2VhcmNoLWZvcndh cmQgJ2Jvb2ttYXJrLW5hbWUtcHJvcCBib29rbWFyay1uYW1lKQorICAgICAgKGdvdG8tY2hhciAo cG9pbnQtbWluKSkpCisgICAgKG1lc3NhZ2UgIlNldCBhbm5vdGF0aW9uIGZvciBcIiVzXCIiIGJv b2ttYXJrLW5hbWUpCisgICAgKGtpbGwtYnVmZmVyIG9sZC1idWZmZXIpKSkKIAogCiAoZGVmdW4g Ym9va21hcmstZWRpdC1hbm5vdGF0aW9uIChib29rbWFyay1uYW1lLW9yLXJlY29yZCkKQEAgLTE1 NjMsOSArMTU2OCwxMSBAQCBib29rbWFyay1sb2FkCiAJKHByb2dyZXNzLXJlcG9ydGVyLWRvbmUg cmVwb3J0ZXIpKSkpKQogCiAMCi07OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJv b2ttYXJrIG1lbnUuCis7OzsgQ29kZSBzdXBwb3J0aW5nIHRoZSBkaXJlZC1saWtlIGJvb2ttYXJr IGxpc3QuCiA7OyBQcmVmaXggaXMgImJvb2ttYXJrLWJtZW51IiBmb3IgImJ1ZmZlci1tZW51IjoK IAorKGRlZmNvbnN0IGJvb2ttYXJrLWJtZW51LWJ1ZmZlciAiKkJvb2ttYXJrIExpc3QqIgorICAi TmFtZSBvZiBidWZmZXIgdXNlZCBmb3IgQm9va21hcmsgTGlzdC4iKQogCiAoZGVmdmFyIGJvb2tt YXJrLWJtZW51LWhpZGRlbi1ib29rbWFya3MgKCkpCiAKQEAgLTE2NTAsNyArMTY1Nyw3IEBAIGJv b2ttYXJrLWJtZW51LW1vZGUtbWFwCiAoZGVmdW4gYm9va21hcmstYm1lbnUtc3VycmVwdGl0aW91 c2x5LXJlYnVpbGQtbGlzdCAoKQogICAiUmVidWlsZCB0aGUgQm9va21hcmsgTGlzdCBpZiBpdCBl eGlzdHMuCiBEb24ndCBhZmZlY3QgdGhlIGJ1ZmZlciByaW5nIG9yZGVyLiIKLSAgKGlmIChnZXQt YnVmZmVyICIqQm9va21hcmsgTGlzdCoiKQorICAoaWYgKGdldC1idWZmZXIgYm9va21hcmstYm1l bnUtYnVmZmVyKQogICAgICAgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgIChzYXZlLXdpbmRvdy1l eGN1cnNpb24KICAgICAgICAgICAoYm9va21hcmstYm1lbnUtbGlzdCkpKSkpCkBAIC0xNjY0LDcg KzE2NzEsNyBAQCBib29rbWFyay1ibWVudS1saXN0CiBkZWxldGlvbiwgb3IgPiBpZiBpdCBpcyBm bGFnZ2VkIGZvciBkaXNwbGF5aW5nLiIKICAgKGludGVyYWN0aXZlKQogICAoYm9va21hcmstbWF5 YmUtbG9hZC1kZWZhdWx0LWZpbGUpCi0gIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlICIq Qm9va21hcmsgTGlzdCoiKSkpCisgIChsZXQgKChidWYgKGdldC1idWZmZXItY3JlYXRlIGJvb2tt YXJrLWJtZW51LWJ1ZmZlcikpKQogICAgIChpZiAoY2FsbGVkLWludGVyYWN0aXZlbHktcCAnaW50 ZXJhY3RpdmUpCiAgICAgICAgIChzd2l0Y2gtdG8tYnVmZmVyIGJ1ZikKICAgICAgIChzZXQtYnVm ZmVyIGJ1ZikpKQotLSAKMi4yMS4wCgo= --0000000000003c4ca6058caa47b8--