From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Thu, 2 Jan 2025 15:38:33 -0600 Message-ID: References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <86wmfdhwg7.fsf@gnu.org> <0347118b217c57e4e62018547883fad5f1d1e63e.camel@yandex.ru> <86frm1hqv8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23765"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Hi-Angel@yandex.ru, emacs-devel@gnu.org, jonas@bernoul.li To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 02 22:39:27 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTSud-00063B-0l for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jan 2025 22:39:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTSts-0005sj-AZ; Thu, 02 Jan 2025 16:38:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTStq-0005sb-NI for emacs-devel@gnu.org; Thu, 02 Jan 2025 16:38:38 -0500 Original-Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTStp-0003EH-30; Thu, 02 Jan 2025 16:38:38 -0500 Original-Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5d7e3f1fc01so23505987a12.2; Thu, 02 Jan 2025 13:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735853914; x=1736458714; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=lKM9p+M0ylsXDAOTP25oH3uN8Bzx+rXvmHNHXe4TZik=; b=IMiPw8MCZHALCDMfG3owNbmbbPBgv0t8oz6EAxU521tdu1Om+L1KDhRNO8y4NFIrAz 5wmuuypruL6OoYUGa8Rkbk/StpKaj5BN2ZeKrld3MmSPufVhJ+VhH9r4c9dpxih/w9iY cbLn4AMs8HKJH+49e2/hZdHcbfx44eM+QXaIDoHhJF0T7/nI5eo5XGrv342oYd5RicUW mOjg9QAnYGXIW+jkFlD13z/iHnABLbaowYT5frYq4RYfmOzdcNx/Zuu6xv4tWCUb2Abs oAgExfHXHukjUXNXeGOumEptQfmR6J1oTJcEFn7Anhp7k8RzHNua4nib6jDFXikkOWGZ WICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735853914; x=1736458714; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lKM9p+M0ylsXDAOTP25oH3uN8Bzx+rXvmHNHXe4TZik=; b=sCWcqCaI0pBcrDPjDXLzILAMgHYF9FOx7GNXTK0uYdYUGLH0pgqcSrC+FQ2x+Hagrn Zw3H2HZrbu6QzhOV6gM4tF30RdTwJzXvobi7uljb/HYkosOk0og7FVIvDwLIn45KvwjT RAHvxeLViC5vWPAtygKGerk9STdn+Ylfha1DEsAhhqo1rdBU2kUpk17uvMY0GXG71dri WSmwbWfutaewafRx16l563MeITL/idyenA2D+pq0Bw/Z+n/VIUV1W0NbVpoOX7m2ehJV yx+AIaOZfFjVd3KyfTercRpBpMPAqrrDfBGWHWFh8HdwyP98lmajdf1tatlEHz1a9Itb guxQ== X-Forwarded-Encrypted: i=1; AJvYcCXY3LBs3UEyviWCTa266rl4GtcNuGbAnJkH/1KoKKAtFJIEGXmIA104bk0Vtg1akyTPgkKKx/rwDtcvxw==@gnu.org X-Gm-Message-State: AOJu0YwP73XX9AGQ+ruM9GtryQnsJTKgAGjxm2VbNv+vw7fYuCdb/Gc5 hKIrwIvR/PjGClmUI4aJaCFw0HNiu+6E0qbKa5TguczvO+S31qIk4EDyt/anWVjHV/vEq9MrFlB x6RHUOFej69hZ1u+u4LFz/I9b1Un0qsputt026Q== X-Gm-Gg: ASbGnctM+KPJkzaapDsjE0pE5fOrlxEepXIUQZy2lpiNLdM2SesOWLBwAHS+EcG6D1S lqdVq4VA/X2rnxwvZXbHtXLkIMHT7XkQjjXhzF+I= X-Google-Smtp-Source: AGHT+IFoj0PLUV6wCVB0J0718bxsDuSRRv7gCufzZcKV7rAEg2UrrPvqR9/zjIZyQt6qZwvrQOR0of/fbXXkGZfZtUg= X-Received: by 2002:a05:6402:354b:b0:5d3:cfd0:8d3f with SMTP id 4fb4d7f45d1cf-5d81ddfd82bmr40835944a12.24.1735853913751; Thu, 02 Jan 2025 13:38:33 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 2 Jan 2025 15:38:33 -0600 In-Reply-To: <86frm1hqv8.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327599 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Thu, 2 Jan 2025 14:10:22 -0600 >> Cc: emacs-devel@gnu.org, Jonas Bernoulli >> >> > I thought of deriving from text-mode. I don't know much of change-log- >> > mode besides what it says in the mode title and now that I'm looking a= t >> > mode description it also sounds pretty vague. So=E2=80=A6 I could deri= ve it >> > from change-log-mode if you think it's useful, but I'd rely on your >> > judgment here =F0=9F=98=8A >> >> `change-log-mode` implements the anachronistic ChangeLog format favored >> by GNU. > > That "anachronistic format" allows plain text, so I don't quite see > how using change-log-mode as the parent mode will cause us lose > anything? What's the harm in getting everything text-mode descendants > can do, plus support for "anachronistic" formats? I'm concerned that it would get in the way of editing commit messages that do not use the ChangeLog format. It seems to me that `change-log-mode' would need quite a bit of adapting not to do that. For example, `open-line` in that mode adds a tab character at the beginning of the line. It would also contribute to some confusion, when users try to figure out what ChangeLog's are, and why they are needed to use Git. Instead of inheriting from it, I'd propose creating an optional minor mode, that users can enabled when they need to, plus a globalized mode for those that want it on always. That would also expand it to be useful also with Magit's `git-commit-mode`, for example, which I'd personally welcome. (FWIW, I happen to think that the paragraph filling rules would be the most interesting feature in such a minor mode.)