From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37548: Implement sanitation of single-file package long description Date: Mon, 30 Sep 2019 19:39:26 +0200 Message-ID: References: <87eezzwtcx.fsf@oitofelix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="178094"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37548@debbugs.gnu.org To: Bruno =?UTF-8?Q?F=C3=A9lix?= Rezende Ribeiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 30 19:40:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEzem-000kE9-HH for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 19:40:20 +0200 Original-Received: from localhost ([::1]:55636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEzel-0005hf-11 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 13:40:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52119) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEzeW-0005hU-Iy for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 13:40:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEzeV-0001Ax-5i for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 13:40:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51634) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEzeU-0001Ao-TP for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 13:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEzeU-00010X-P6 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 13:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2019 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37548 X-GNU-PR-Package: emacs Original-Received: via spool by 37548-submit@debbugs.gnu.org id=B37548.15698651873846 (code B ref 37548); Mon, 30 Sep 2019 17:40:02 +0000 Original-Received: (at 37548) by debbugs.gnu.org; 30 Sep 2019 17:39:47 +0000 Original-Received: from localhost ([127.0.0.1]:60455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEzeE-0000zx-Iz for submit@debbugs.gnu.org; Mon, 30 Sep 2019 13:39:46 -0400 Original-Received: from mail-pl1-f177.google.com ([209.85.214.177]:33735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEzeC-0000zf-Sf for 37548@debbugs.gnu.org; Mon, 30 Sep 2019 13:39:45 -0400 Original-Received: by mail-pl1-f177.google.com with SMTP id d22so4189391pls.0 for <37548@debbugs.gnu.org>; Mon, 30 Sep 2019 10:39:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sfQTMkONf+nWiQLQsX46lCA2nUpKi8uzLWs85WBW45Q=; b=hUKpkVI4k4cyeiBpmXot7fexlIDHT1H1DNJlJrZq7/x+d+jO/ffHO0Hjxmxvt/04o5 VLDZWkp89MBKGh64DCNPzNUiSYNitJfQsgSP3hnEkOENtvwYtP2swA8ycA6J5DOq9AGJ i4oEf6W+P/Jbj8lQhg+2uBcviP2CRjCvTxh1HfQ36LVQDwoNAbuzsi5fnJGljdqGRkIs dvMdkRANExGqeKB7Eo00uHy8nQ8FfLdJXKNJbGOf89HMWo2c0bN3MyzUBiP3z+ZU/ygX XRBcBUbcpZ1vJowvnMKmZewr7talNmbt94lEkAStmORnCFRTtmaN5rtx2FphCjt1x/0h 48gg== X-Gm-Message-State: APjAAAUilGGXnqzHhaK/XtLyhq86csLHCsfC7nQWgeg3p+hhPz6cAnrH Up8uoHfWRT+OHdRWtR+x5DrihHgtGZmo+XLudI4= X-Google-Smtp-Source: APXvYqwONYpNKJK1Lip7xVWvUxQIB/9wJCBcOoAWSwv/0P+CatocdbsLeSdhC3slVCRhNoCI5a9sBHlFCBGM6uM/F5c= X-Received: by 2002:a17:902:d88f:: with SMTP id b15mr20472300plz.251.1569865178033; Mon, 30 Sep 2019 10:39:38 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167935 Archived-At: Stefan Kangas writes: > Maybe it would make more sense to create a new function in package.el > that takes care of this? That way we don't have the same > functionality in two places. I noticed something else: There is actually already code duplication in package.el -- there is code to strip the commentary section in both package--get-description and describe-package-1. Perhaps it would make sense to look this all over and see how we can do better? I also have two general questions, which are applicable to both your recent patches: 1. It looks likely that this together with your other patch and your previous contributions will together amount to more than 15 lines of code. That means that you would have to sign Copyright Assignment papers for GNU Emacs. I see you're emailing from gnu.org, so I assume there are no surprises for you here; I guess Eli can help you sort that out if it's not already. 2. Could you please provide a commit message formatted as a changelog entry? Details on this are in the CONTRIBUTE file in the repository. Best regards, Stefan Kangas