From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable Date: Tue, 2 Jul 2019 18:22:46 +0200 Message-ID: References: <878tu9wk53.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000005dd3c8058cb52823" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205766"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Dmitri Paduchikh , 24573@debbugs.gnu.org, Win Treese To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 02 19:51:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiMvu-000qOm-27 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 19:51:10 +0200 Original-Received: from localhost ([::1]:55720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiMgU-0002Bk-Uc for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 13:35:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47864) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiLZb-0001Di-TA for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:24:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiLZa-0004Nk-RR for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38942) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiLZa-0004Nd-Md for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiLZa-0003H0-G1 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:24:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <878tu9wk53.fsf@gmail.com> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24573 X-GNU-PR-Package: emacs Original-Received: via spool by 24573-submit@debbugs.gnu.org id=B24573.156208458512514 (code B ref 24573); Tue, 02 Jul 2019 16:24:02 +0000 Original-Received: (at 24573) by debbugs.gnu.org; 2 Jul 2019 16:23:05 +0000 Original-Received: from localhost ([127.0.0.1]:47761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLYf-0003Fl-94 for submit@debbugs.gnu.org; Tue, 02 Jul 2019 12:23:05 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:37995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLYd-0003Ey-IK for 24573@debbugs.gnu.org; Tue, 02 Jul 2019 12:23:04 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id s15so1692156wmj.3 for <24573@debbugs.gnu.org>; Tue, 02 Jul 2019 09:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=XaH6onYorOthHg1J01QKKiIaChzb0zJAR53MjWw5HjU=; b=gSgTi/5GGfs2rkS0SzhfE5oqhSey2aUbZGAwSde9XoEoCvJcsC7wl30SJiTyQEksaE Z044T4kPsHZuYBZFSHKMtEZ1V5lwfu6ckZX8lZFvBaJ1Vi3TqdFaQk3OrFPTXnpJ6i/8 AdGXlJ6RXQ8HiHPdiVQ0HZs2H8vVMjSxh23gEF5Z16pS/BtopWfYwIb3WzT6wVrSVwH4 +7eLSj8VZqqKHnGJVHM7ws3nTy7I4yovXVmZeRD/W1b2RhcANA4NR15aFM1KcMwgL3Cz 9rbOr6PFLC6tllpWN6MQO7180/PL4aa4YSBBU5QKyqoWHo6GizRsaJCq9D8Rrn5n1Xr+ 1z8Q== X-Gm-Message-State: APjAAAWJTJfW1e3x4GOCzpQUFGT2H1koym7/P0CPDWwGqYgmr8zOVRAa U53NXjBfkTGBDx2UKMq3CeWbys6UNj4v0/RkS9c= X-Google-Smtp-Source: APXvYqwjhLjcGGCdsEcipflqfOVpIwodXNMIFNncfQNmik4DhHTwn76Z5/IGMHUIWaOeZA5MWD1MqCTjnAHmmvhgWOw= X-Received: by 2002:a1c:b6d4:: with SMTP id g203mr3982004wmf.19.1562084577746; Tue, 02 Jul 2019 09:22:57 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161969 Archived-At: --0000000000005dd3c8058cb52823 Content-Type: text/plain; charset="UTF-8" tags 24573 patch quit Noam Postavsky writes: > The lambda is fine, it's the buffer which uses the unreadable print > synax: #<...>. The following which swaps buffer objects with their name > seems to fix it, although I haven't really tested this much. > > --- i/lisp/help-mode.el > +++ w/lisp/help-mode.el > @@ -756,7 +756,9 @@ help-bookmark-make-record > (error "Cannot create bookmark - help command not known")) > `(,@(bookmark-make-record-default 'NO-FILE 'NO-CONTEXT) > (help-fn . ,(car help-xref-stack-item)) > - (help-args . ,(cdr help-xref-stack-item)) > + (help-args . ,(mapcar (lambda (a) > + (if (bufferp a) (buffer-name a) a)) > + (cdr help-xref-stack-item))) > (position . ,(point)) > (handler . help-bookmark-jump))) I can confirm this bug, which I've recently stumbled into myself. I can also confirm that Noam Postavsky's fix works. In the interest of getting it merged as soon as possible, I'm sending it here as a diff to be easier to apply. I could send it as a patch too if that will get it merged faster. But the credit for fixing this should fully go to Noam Postavsky. Thanks, Stefan Kangas --0000000000005dd3c8058cb52823 Content-Type: text/x-patch; charset="US-ASCII"; name="bug24573.diff" Content-Disposition: attachment; filename="bug24573.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxm0krnq0 ZGlmZiAtLWdpdCBhL2xpc3AvaGVscC1tb2RlLmVsIGIvbGlzcC9oZWxwLW1vZGUuZWwKaW5kZXgg ZGMyOTkyY2Q0YS4uY2Q0MTM4YzM2NSAxMDA2NDQKLS0tIGEvbGlzcC9oZWxwLW1vZGUuZWwKKysr IGIvbGlzcC9oZWxwLW1vZGUuZWwKQEAgLTc4Nyw3ICs3ODcsOSBAQCBoZWxwLWJvb2ttYXJrLW1h a2UtcmVjb3JkCiAgICAgKGVycm9yICJDYW5ub3QgY3JlYXRlIGJvb2ttYXJrIC0gaGVscCBjb21t YW5kIG5vdCBrbm93biIpKQogICBgKCxAKGJvb2ttYXJrLW1ha2UtcmVjb3JkLWRlZmF1bHQgJ05P LUZJTEUgJ05PLUNPTlRFWFQpCiAgICAgICAoaGVscC1mbiAgICAgLiAsKGNhciBoZWxwLXhyZWYt c3RhY2staXRlbSkpCi0gICAgICAoaGVscC1hcmdzICAgLiAsKGNkciBoZWxwLXhyZWYtc3RhY2st aXRlbSkpCisgICAgICAoaGVscC1hcmdzICAgLiAsKG1hcGNhciAobGFtYmRhIChhKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChpZiAoYnVmZmVycCBhKSAoYnVmZmVyLW5hbWUgYSkgYSkp CisgICAgICAgICAgICAgICAgICAgICAgICAgIChjZHIgaGVscC14cmVmLXN0YWNrLWl0ZW0pKSkK ICAgICAgIChwb3NpdGlvbiAgICAuICwocG9pbnQpKQogICAgICAgKGhhbmRsZXIgICAgIC4gaGVs cC1ib29rbWFyay1qdW1wKSkpCiAK --0000000000005dd3c8058cb52823--