From: Stefan Kangas <stefan@marxist.se>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: Dmitri Paduchikh <dpaduchikh@gmail.com>,
24573@debbugs.gnu.org, Win Treese <treese@acm.org>
Subject: bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable
Date: Tue, 2 Jul 2019 18:22:46 +0200 [thread overview]
Message-ID: <CADwFkm=h+kVXms9M7MxMNcjN3pds0_qaGuUyJ8PA-+7bTAjWhQ@mail.gmail.com> (raw)
In-Reply-To: <878tu9wk53.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
tags 24573 patch
quit
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> The lambda is fine, it's the buffer which uses the unreadable print
> synax: #<...>. The following which swaps buffer objects with their name
> seems to fix it, although I haven't really tested this much.
>
> --- i/lisp/help-mode.el
> +++ w/lisp/help-mode.el
> @@ -756,7 +756,9 @@ help-bookmark-make-record
> (error "Cannot create bookmark - help command not known"))
> `(,@(bookmark-make-record-default 'NO-FILE 'NO-CONTEXT)
> (help-fn . ,(car help-xref-stack-item))
> - (help-args . ,(cdr help-xref-stack-item))
> + (help-args . ,(mapcar (lambda (a)
> + (if (bufferp a) (buffer-name a) a))
> + (cdr help-xref-stack-item)))
> (position . ,(point))
> (handler . help-bookmark-jump)))
I can confirm this bug, which I've recently stumbled into myself.
I can also confirm that Noam Postavsky's fix works.
In the interest of getting it merged as soon as possible, I'm sending
it here as a diff to be easier to apply. I could send it as a patch
too if that will get it merged faster. But the credit for fixing this
should fully go to Noam Postavsky.
Thanks,
Stefan Kangas
[-- Attachment #2: bug24573.diff --]
[-- Type: text/x-patch, Size: 648 bytes --]
diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index dc2992cd4a..cd4138c365 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -787,7 +787,9 @@ help-bookmark-make-record
(error "Cannot create bookmark - help command not known"))
`(,@(bookmark-make-record-default 'NO-FILE 'NO-CONTEXT)
(help-fn . ,(car help-xref-stack-item))
- (help-args . ,(cdr help-xref-stack-item))
+ (help-args . ,(mapcar (lambda (a)
+ (if (bufferp a) (buffer-name a) a))
+ (cdr help-xref-stack-item)))
(position . ,(point))
(handler . help-bookmark-jump)))
next prev parent reply other threads:[~2019-07-02 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 14:13 bug#24573: 25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable Dmitri Paduchikh
2017-10-28 18:53 ` Win Treese
2017-10-28 19:48 ` Noam Postavsky
2019-07-02 16:22 ` Stefan Kangas [this message]
2019-07-06 18:42 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=h+kVXms9M7MxMNcjN3pds0_qaGuUyJ8PA-+7bTAjWhQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=24573@debbugs.gnu.org \
--cc=dpaduchikh@gmail.com \
--cc=npostavs@users.sourceforge.net \
--cc=treese@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.