From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#72809: ms-windows: Copyright embedded into executable is outdated Date: Sat, 14 Sep 2024 06:28:15 -0700 Message-ID: References: <726bb0bf-18d6-4963-8dbe-5151c6da4926@imayhem.com> <86frqnfsd6.fsf@gnu.org> <86mskaitfa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20885"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72809@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 14 15:30:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spSr2-0005GW-Qe for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Sep 2024 15:30:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spSqZ-0003MY-HV; Sat, 14 Sep 2024 09:29:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spSqX-0003Ld-9b for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 09:29:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spSqX-0003ly-11 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 09:29:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=ODR5PfEOw+Y12Cf0NB2w4QJfApbOF/w8YDQfy5K6suM=; b=gK2+gXUmPXlSWtrPdYuQXQwXBMF2ig4Kc6/WFrET9Iqs0WSiZQM/1eAezK+/FPb+QkFb4v5nF6fcx3UwH9QdGtNuFg2ArsbhW0LgplwWT+jz4b13IqV88CaGIXjL6g3HJa173TktdsSKiGs6beIpfd16/GZ1JD1fLRu3L0nyVSXAtpXrR0adj7mfuUC2n7waWp2zwzOVqYe1E9K3ac4ODQb6zbA1s4VGoFeOTINhHU2mDlEMZFG3wLv6Rj3ao8f1poMdRKNRkh1qIF/Yf1HeJyXFY38amvsem2+5EpCesTopNl71fW5yrJqvpdFVlSHuorqnqagi9aBBuqH5HAnVqw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spSqh-0006Ax-I2 for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 09:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 13:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72809 X-GNU-PR-Package: emacs Original-Received: via spool by 72809-submit@debbugs.gnu.org id=B72809.172632057523643 (code B ref 72809); Sat, 14 Sep 2024 13:30:03 +0000 Original-Received: (at 72809) by debbugs.gnu.org; 14 Sep 2024 13:29:35 +0000 Original-Received: from localhost ([127.0.0.1]:45120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spSqE-00069H-Ul for submit@debbugs.gnu.org; Sat, 14 Sep 2024 09:29:35 -0400 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:53489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spSqC-00068y-Nv for 72809@debbugs.gnu.org; Sat, 14 Sep 2024 09:29:33 -0400 Original-Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c26a52cf82so887319a12.2 for <72809@debbugs.gnu.org>; Sat, 14 Sep 2024 06:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726320496; x=1726925296; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ODR5PfEOw+Y12Cf0NB2w4QJfApbOF/w8YDQfy5K6suM=; b=Cp9L8Z7/YL90GGL8hts6wD5ZQkecZ5QhrN3/78F/KB01x1oENLaoAQZE2DHhaKksDC 7gHLkIHjnbnpaOh0jsYJMwezbJlSWWSzyc7C63LEVYw1RpQslF5Q2yzh4vcU8K2N4gJp v8RFdEuZmyvw2RF+c2lfVlXUTbL4ISRvoI2x+dBPgwfhU6UaDvFsok8j5JxnNHy4J/Qc zQghUqiCOT3racDoDyGMiekJMtzbb3jwQbJlsUGmR7M2/bPjcfu7pyjekgTplR3JMd19 rba4tURWqtGauhrfK/w9+aaaqU79vEG5MPtqH5xIgXwOI6auN/6qwm43b/SdIp5tgoKL U5JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726320496; x=1726925296; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ODR5PfEOw+Y12Cf0NB2w4QJfApbOF/w8YDQfy5K6suM=; b=MOFbw+ovUQPMnql5COHd85TVpqJPc5i6DH726R/5knzsQbAdicS813w+RCwrukIaMJ 1ZAhn5Q7VGrbcaHyCHdhkvQRlXLpZfaS/EuQn9SjTGsT6ZkjdvzT81jZJA9nCMVJCSbp Tj2749hGuIPz9Aiql9iFx0M68LVkOv8x98xakTdpBl6yJcJUJaRH0Mzs4rgra+Xj3D20 NwCk5Blb7HYBBobtgTcYBwanpd+Y1l0rQH5KFLjKHWE2+NemhHz9TuMSf+Lc9rlgrzvt tPgX8law7wDLNu/a7maOnXQzwHIwww/8WVicgB8TL972fi/dMaTY9dJQ+mJzP0pm/WXy Qfmw== X-Gm-Message-State: AOJu0Yy7arU+WKKBOwPP2jELlGn0p9nj8RgCrO6ksnxFG/DhHPE9uOQc W2ER/KNJZ6vIDMXljmna+v3kZv4op36xxVWBKAhCBgOiE1pK8ZmuejXAK0ko9pbSbbRx04YXJBE oA5JwFoGrxPVslSw4alKi3dXxTWRbetiv6X4= X-Google-Smtp-Source: AGHT+IEPGUwD5kwz44TbiuUb/1MmW3/HOCPZxsnpFZNplZy6kbSunu1xb1ZmlPLiKp7JNt312fiFtPKRF0/P8QRxCUI= X-Received: by 2002:a05:6402:2687:b0:5c4:2448:87e9 with SMTP id 4fb4d7f45d1cf-5c424488a68mr7173867a12.0.1726320495982; Sat, 14 Sep 2024 06:28:15 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 14 Sep 2024 06:28:15 -0700 In-Reply-To: <86mskaitfa.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291742 Archived-At: Eli Zaretskii writes: > Stefan, what are your thoughts about improving the script? Do you > understand why these files were missed? The simple reason is that the Gnulib `build-aux/update-copyright` script don't support them, so we need to remember to update them manually. As for why this is, the cases are different. 1. There's more than one copyright year in these files: configure.ac doc/lispref/tips.texi etc/images/gud/README However, the Gnulib script only updates the first copyright year. 2. For these files: nt/emacs.rc.in nt/emacsclient.rc.in the Gnulib script does not support making this update: - VALUE "LegalCopyright", "Copyright (C) 2001-2021\0" + VALUE "LegalCopyright", "Copyright (C) 2001-2024\0" 3. This file: test/lisp/which-key-tests.el was added with the wrong copyright in 2024. There are even more edge cases, see for example commit 33d159c36f42. I'm not sure if it's worth updating our script to support all this. It's not too hard to remember to grep for "202[0-9]" and updating them manually. Writing code to do this has a maintenance cost too, and also runs a risk of missing some years. Files change, new files are added, etc. So there's no way around grepping to make sure, I think. Thus, perhaps we should just do this: diff --git a/admin/update-copyright b/admin/update-copyright index b9007100b35..23b78443ca4 100755 --- a/admin/update-copyright +++ b/admin/update-copyright @@ -77,3 +77,6 @@ updatable_files= -print) && build-aux/update-copyright $updatable_files + +printf "!! Please remember to grep for and manually update any" +printf "!! copyright years that were not updated by this script."