all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 72809@debbugs.gnu.org
Subject: bug#72809: ms-windows: Copyright embedded into executable is outdated
Date: Sat, 14 Sep 2024 06:28:15 -0700	[thread overview]
Message-ID: <CADwFkm=dM67MZTHtVCAqE=WctPygJ4sfhv7M2QSwQsAXmWqw6g@mail.gmail.com> (raw)
In-Reply-To: <86mskaitfa.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> Stefan, what are your thoughts about improving the script?  Do you
> understand why these files were missed?

The simple reason is that the Gnulib `build-aux/update-copyright` script
don't support them, so we need to remember to update them manually.

As for why this is, the cases are different.

1. There's more than one copyright year in these files:

    configure.ac
    doc/lispref/tips.texi
    etc/images/gud/README

   However, the Gnulib script only updates the first copyright year.

2. For these files:

    nt/emacs.rc.in
    nt/emacsclient.rc.in

   the Gnulib script does not support making this update:

   -	    VALUE "LegalCopyright", "Copyright (C) 2001-2021\0"
   +	    VALUE "LegalCopyright", "Copyright (C) 2001-2024\0"

3. This file:

    test/lisp/which-key-tests.el

   was added with the wrong copyright in 2024.

There are even more edge cases, see for example commit 33d159c36f42.

I'm not sure if it's worth updating our script to support all this.
It's not too hard to remember to grep for "202[0-9]" and updating them
manually.  Writing code to do this has a maintenance cost too, and also
runs a risk of missing some years.  Files change, new files are added,
etc.  So there's no way around grepping to make sure, I think.

Thus, perhaps we should just do this:

diff --git a/admin/update-copyright b/admin/update-copyright
index b9007100b35..23b78443ca4 100755
--- a/admin/update-copyright
+++ b/admin/update-copyright
@@ -77,3 +77,6 @@ updatable_files=
   -print) &&

 build-aux/update-copyright $updatable_files
+
+printf "!! Please remember to grep for and manually update any"
+printf "!! copyright years that were not updated by this script."





  reply	other threads:[~2024-09-14 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-25 19:38 bug#72809: ms-windows: Copyright embedded into executable is outdated Cecilio Pardo
2024-08-26  0:50 ` Stefan Kangas
2024-08-29 12:03   ` Eli Zaretskii
2024-09-14  7:30     ` Eli Zaretskii
2024-09-14 13:28       ` Stefan Kangas [this message]
2024-09-14 14:02         ` Eli Zaretskii
2024-09-14 15:41           ` Stefan Kangas
2024-09-14 16:04             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=dM67MZTHtVCAqE=WctPygJ4sfhv7M2QSwQsAXmWqw6g@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=72809@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.