From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51763: 27.2; Displaying many images take all memory Date: Thu, 11 Nov 2021 09:33:32 -0800 Message-ID: References: <87wnlfrriv.fsf@posteo.net> <8735o39bad.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51763@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 18:34:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlDxq-0004L5-K9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 18:34:18 +0100 Original-Received: from localhost ([::1]:37356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlDxp-0000On-Nw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 12:34:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlDxc-0000Nz-Ce for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 12:34:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlDxa-0007dD-LV for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 12:34:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlDxa-0004qO-EF for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 12:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 17:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51763 X-GNU-PR-Package: emacs Original-Received: via spool by 51763-submit@debbugs.gnu.org id=B51763.163665202218580 (code B ref 51763); Thu, 11 Nov 2021 17:34:02 +0000 Original-Received: (at 51763) by debbugs.gnu.org; 11 Nov 2021 17:33:42 +0000 Original-Received: from localhost ([127.0.0.1]:42155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlDxF-0004pc-L5 for submit@debbugs.gnu.org; Thu, 11 Nov 2021 12:33:41 -0500 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:36441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlDxC-0004pN-Pb for 51763@debbugs.gnu.org; Thu, 11 Nov 2021 12:33:39 -0500 Original-Received: by mail-pl1-f170.google.com with SMTP id u11so6345074plf.3 for <51763@debbugs.gnu.org>; Thu, 11 Nov 2021 09:33:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=TjLrciNNrEU8ai6CMB4bUvdxoW4MWTvpEJ0mzu64CXs=; b=6mhjs9XZeZMIsGeR1Qvg4lreUKPyxNWt0HZI9xKM/73mc5YTL/m9fehaingMMQyN0A NOzFxSMhty5SWQshUKYJ+xueymViw4IJl2CVBF1T5oMcweb2RJE8ee1hq3Bv3AuGEmg4 ZjF6ubJFvuIHPgcBMZ/0tUjp9Q4Q3ieOcfzrUfjvWCNxbt5MX1PzDNjBaeJCUi10O2kU L/wjxJz7yPUUDz+MFj7pX0Ye/Vay9/ZdcUfoJcBLHY0w4eTsjGzObi627GgmdAdyR+z2 +Ah1g3yyAit2vuSAxq9obpIGTy3kTabvOlDYPamAiZIZKc2rnJBTHcixa9ZTEeE11xwD L+KQ== X-Gm-Message-State: AOAM531Sc4dcey4GuRuuO/JN+RAwZg970RevpBMkQdfP8mQWZGLjn8OW ndhFWY7i3z3WS979j4cFjlAwdBfPX72uY0+wRMqAw34m X-Google-Smtp-Source: ABdhPJxynyMzROvKxvjlQCHok+kFLHc2MylJOrZwUdsbUBKhbUO9vJjr5OmJk5VY7++GBHZMkZPvDCkgKmZxzI53Ctc= X-Received: by 2002:a17:90a:be10:: with SMTP id a16mr9907613pjs.133.1636652012804; Thu, 11 Nov 2021 09:33:32 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 11 Nov 2021 09:33:32 -0800 In-Reply-To: <8735o39bad.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219659 Archived-At: Thierry Volpiatto writes: >> AFAIU, calling `clear-image-cache' should also the free memory unless we >> have a memory leak. You could also call this function from your code. >> Does calling this function free the memory for you? > > Yes it does =F0=9F=99=82. I didn't know this function (BTW what about re= naming to > `image-clear-cache`), works great with my code, perhaps you can do the > same in dired (we use more or less similar code). Great! For now, this is just a temporary workaround for high memory usage, so I'd personally be more inclined to work on the underlying issue than adding it to Image-Dired. I also believe that you will want to revisit the decision to use it once this bug is fixed: it is a bit of a sledgehammer and can lead to undesirable results (slowdowns). As for renaming it to `image-clear-cache', I think it would be good but let's see if anyone else thinks otherwise.