From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: File names in ChangeLog entries Date: Tue, 30 Nov 2021 15:55:17 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40862"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 01 00:56:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msCyq-000ARW-1k for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Dec 2021 00:56:12 +0100 Original-Received: from localhost ([::1]:51656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msCyo-0006xB-M3 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Nov 2021 18:56:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msCy1-0006ES-GX for emacs-devel@gnu.org; Tue, 30 Nov 2021 18:55:21 -0500 Original-Received: from mail-pj1-f42.google.com ([209.85.216.42]:46822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msCxz-00072G-L2 for emacs-devel@gnu.org; Tue, 30 Nov 2021 18:55:21 -0500 Original-Received: by mail-pj1-f42.google.com with SMTP id np6-20020a17090b4c4600b001a90b011e06so18758746pjb.5 for ; Tue, 30 Nov 2021 15:55:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=9QhOvCLHWk4cRDtjRgKMkhTirfBBGrqPG10oTA4h4Po=; b=3nmbP8tBXqkIK3/mcRGKfl6cXsha2pGSTAQgFC79HIenBAoAkTdNlSScr+j+B8yTc+ k/fTkmgdgJB7pnTr0rjI7+4FA1KccQDnT98db/YVR2uEFbZi3RC4rjCkllH3G9iqhXLW zO+u4Vjgh3WQWlzGtCUCjQ4TUc8BohVj+g/g3sHV3wF7/18ekjnvcT4o2q5uFIpfocgZ 2qcPXntnVMJK67TpyXIolj97UxonqewpJhPToBYggd0pCHaCEtMsTY1lx9qOfM9hfalc e4z2705h7HCXVnzuW8Ho/r/gRms9v0qR6AI3Y7E8u0lHKoEFH2ia0BED0Uw6nTySfjy2 wr6Q== X-Gm-Message-State: AOAM531D+QStdGIdO3u9VYtXUN03aM+yx7FToOc65NUKnJVl03+K/yyY ni9TbOpptrCcW6jabENzcodX8fjgzU3MFSjP0dp5ZSTm X-Google-Smtp-Source: ABdhPJxQrtOJLfxMFoIorBP4MECSfrLmpoLMSvLhAntc2uM4mdbNynkOhS3Nz4HQoMh+a0CdUZT7DXWLvqN1TC1BCwk= X-Received: by 2002:a17:90a:be10:: with SMTP id a16mr2804308pjs.133.1638316518222; Tue, 30 Nov 2021 15:55:18 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 30 Nov 2021 15:55:17 -0800 In-Reply-To: Received-SPF: pass client-ip=209.85.216.42; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f42.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280568 Archived-At: Stefan Monnier writes: > FWIW, I can't remember the last time I looked at a ChangeLog file. Indeed, I also never look at them. > OTOH, I would really appreciate if people could be careful to always > include some kind of file information on the first line of their commit. > Too often I see commits whose first line doesn't unambiguously indicate > which part of Emacs's code is changed. In the past I often used the format Fix foo in image-dired.el Recently, I've made some changes to image-dired.el where I instead used the format image-dired: Fix foo I quite like this format, as it is both easy to read and immediately obvious what it's about. Maybe it would make sense to start encouraging some more standardized format for the first line of commit messages? This seems like something that was probably discussed in the past (before I was following emacs-devel), so apologies in advance if I'm just beating a dead horse.