From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51340: 27.2; Bad indentation and fontification of advice functions Date: Fri, 22 Oct 2021 17:15:52 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51340@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 23 02:16:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1me4ho-0005uw-Rt for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Oct 2021 02:16:12 +0200 Original-Received: from localhost ([::1]:38850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1me4hn-0000T0-E7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Oct 2021 20:16:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1me4he-0000Ri-MP for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1me4he-0007HB-DX for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1me4he-0001jN-7x for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 20:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Oct 2021 00:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51340 X-GNU-PR-Package: emacs Original-Received: via spool by 51340-submit@debbugs.gnu.org id=B51340.16349481596636 (code B ref 51340); Sat, 23 Oct 2021 00:16:02 +0000 Original-Received: (at 51340) by debbugs.gnu.org; 23 Oct 2021 00:15:59 +0000 Original-Received: from localhost ([127.0.0.1]:34009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me4hb-0001iy-JB for submit@debbugs.gnu.org; Fri, 22 Oct 2021 20:15:59 -0400 Original-Received: from mail-pg1-f180.google.com ([209.85.215.180]:44744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me4ha-0001il-3L for 51340@debbugs.gnu.org; Fri, 22 Oct 2021 20:15:58 -0400 Original-Received: by mail-pg1-f180.google.com with SMTP id c4so4697079pgv.11 for <51340@debbugs.gnu.org>; Fri, 22 Oct 2021 17:15:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=kothu8wSEkjC/3KETS60aN3ZjelK93w0OPC4EOC9vmI=; b=nJ3zl/Wr4UvCCAKG1DjkXUyfATRWP8eTiw4MjYcrG40VVM9o6PW9xgXB3XR159XSTS NqJW8Vq0C6D/ngniT3UUaOze9lPLCfm6W5OF9kffaqplicn5rXPnEzkzXPPt1fbCafgf 5P8HytO06uJtZ9hWLdqo8QU1QTcfxJbAS+m0X7MhMFpqrDCfjfmAYAYwdW4n8PwPXFXO 4Qqvut69o9toIrPaF2ttbVJoRamrCymDOsoFD4IXxksmFDQHfoEAu2hvcVjfF1ng/X5D 8FDLV1MZDQafFipJk97jg5qs9/eu8ipf0H4tMEo+mvPSHaD6mckuVJtjBmITazqpKjZO r9mw== X-Gm-Message-State: AOAM533fjCd/JSrg5Z+9Oh1gV2vZ1MO57AC64kozd035j/wWZ2tgeBVt urJBFpwgNpFSHs6GGXsz7NKYK1Ce/xUMH1izv0w= X-Google-Smtp-Source: ABdhPJzZT5yEhoJ2tsvtVoVeP8O9sojl3g9MnKgTMaQnk5g9pou4koS3xVy5c5fnqRJQvpJfoci+fvY0iBK+8VCR1yM= X-Received: by 2002:a05:6a00:1950:b0:44d:9402:3396 with SMTP id s16-20020a056a00195000b0044d94023396mr3244581pfk.70.1634948152548; Fri, 22 Oct 2021 17:15:52 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 22 Oct 2021 17:15:52 -0700 In-Reply-To: (Drew Adams's message of "Fri, 22 Oct 2021 21:53:01 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217928 Archived-At: Drew Adams writes: > 1. Please consider indenting functions such as `advice-add' and > `add-function' properly. They should probably be indented the way > function definitions (defuns) are. So far, they're indented with no > attention to what they're for or what their content is (e.g. use of > keywords). Do you have an example of the current indentation, and the one you would like to see? Thanks. > 2. Please consider fontifying functions such as `advice-add', the same > as functions such as `add-function': `fontlock-keyword-face'. Sounds good to me.