From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Dired delete(d) the wrong file! Date: Fri, 5 Jul 2024 09:53:05 +0000 Message-ID: References: <86r0c875s4.fsf@gnu.org> <86h6d470oh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1443"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Eli Zaretskii , Dave Goel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 05 11:54:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPfdf-00006p-BC for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jul 2024 11:53:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPfcz-0003tX-Nn; Fri, 05 Jul 2024 05:53:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPfct-0003sl-FO for emacs-devel@gnu.org; Fri, 05 Jul 2024 05:53:12 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPfcr-0004y9-Ol; Fri, 05 Jul 2024 05:53:11 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-58b447c5112so1690852a12.3; Fri, 05 Jul 2024 02:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720173186; x=1720777986; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=I9HkH3p6LMEeuL2+J4HQMJcFNAkRj1+Hem3Ulr21vYo=; b=XNqMRtbcjlSozEx7n2ZLuk5iaZikvxWqG8iJPyBNK4k+wulD33KrYncpZstxjMpUkc ig/YFk8ExCnK4JshxDxlKM4a8XQb5K4Dq8k2xjbCmqlZ+s0eaWjZBhnNHXzWXyx+TDfJ 4lUq4iuKf6TV3WXlHqaPSQmDVoZ8UXtoiuw7v80/hEVCLDLdFljCP96CKPkwOAiV2M7o mvz0d3ZAj9hNL9tx2U/27XE6OYbERQM0EsFeF1qVm3fYrgxG0cZFQEWA2iD2e3uqKxwn sKX9VfoTO3D0fp+Fhi2KPK4ZHLWgPqRHm6WAkW9aXB5ek7ckvCk+U4z96HOPBi0dQEPW m8Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720173186; x=1720777986; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I9HkH3p6LMEeuL2+J4HQMJcFNAkRj1+Hem3Ulr21vYo=; b=HVnOp6eddUVxkE2NMs9OVVAdRoql1JsVgeHnmH8iuPOs55TudXawyAACVbSZeyhGyl kSgtQpb77N/mW2Jdx22PfhC5BjCXZO+xNOjxvPjgBI9AZ0Gqg0wqMFdA4OOBhkqkbPsZ 4hvS9XaeIBWIVl4OB5ARu3+3V5FsQEGXjDHKlb2sv8a29yWdiVB7dvbphIGTOLw+KdKO qGPIO/RvDWKGjek015xmSihRwdiv47hBihWXQP8jAIbxAzWIy6DZNf7x80u4yu8//7Pl vOBBH9Aps12kHKf/JHY9Ib98mZ8SuxoPf4hP9ltt9cpc5BELuM/vAk3f25tBlk/zdfWA dBVw== X-Forwarded-Encrypted: i=1; AJvYcCX5BdI/C12smQkVlZ45RUE82fFaY0llEpy6UrHO3S8TFAqggLydrhx8DQ0gYyPHh5mQRRgyHADXRQvbyBrjiMm0Cy+2 X-Gm-Message-State: AOJu0YwwhUVKdNLTFg4E5VbssyT8J2oewHt+2zASJ4snQDeUdVDb3G13 319YCdi7Xp1NLXgbpPX5zxLZLjg1WGyWaKb+miqxZCtOv3rsCRvUOCJGRyLYm2CqS53XkmjbY56 lOVY177aeNbIWv54v5NiGsvQxJIrEtcoD X-Google-Smtp-Source: AGHT+IEdQxSZnBbv1WPHsPiY6otv0HRJa2ldAIM21+6Ihf7OxQimiP1YglIXCDaiVUKn0JO18VjjNElB3JV3lGFLyWc= X-Received: by 2002:a05:6402:26c4:b0:58e:3501:5c0a with SMTP id 4fb4d7f45d1cf-58e5abda77fmr3386806a12.11.1720173186268; Fri, 05 Jul 2024 02:53:06 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 5 Jul 2024 09:53:05 +0000 In-Reply-To: <86h6d470oh.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321387 Archived-At: Eli Zaretskii writes: > diff --git a/lisp/files.el b/lisp/files.el > index 042b8e2..c518273 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -8087,8 +8087,8 @@ insert-directory-clean > (end (insert-directory-adj-pos > (+ beg (read (current-buffer))) > error-lines))) > - (if (memq (char-after end) '(?\n ?\s)) > - ;; End is followed by \n or by " -> ". > + (if (memq (char-after end) '(?\n ?\s ?/ ?* ?@ ?% ?= ?|)) > + ;; End is followed by \n or by output of -F. > (put-text-property start end 'dired-filename t) > ;; It seems that we can't trust ls's output as to > ;; byte positions of filenames. > It would be useful to have a test for this, BTW.