From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44858: [PATCH] Make byte-compiler warn about wide docstrings Date: Thu, 10 Dec 2020 15:53:13 -0600 Message-ID: References: <87zh34wfxo.fsf@gnus.org> <87v9dss2ic.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e15a1805b62333e6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21169"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44858@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 10 22:54:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knTtS-0005Pb-Bk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Dec 2020 22:54:34 +0100 Original-Received: from localhost ([::1]:52206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knTtR-0004Pu-2i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Dec 2020 16:54:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knTsw-0004P7-Gq for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 16:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knTsw-0002I3-9G for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 16:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knTsw-0004Mf-6M for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 16:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Dec 2020 21:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44858-submit@debbugs.gnu.org id=B44858.160763720316731 (code B ref 44858); Thu, 10 Dec 2020 21:54:02 +0000 Original-Received: (at 44858) by debbugs.gnu.org; 10 Dec 2020 21:53:23 +0000 Original-Received: from localhost ([127.0.0.1]:39505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knTsJ-0004Ln-FW for submit@debbugs.gnu.org; Thu, 10 Dec 2020 16:53:23 -0500 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:36183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knTsF-0004LW-Rs for 44858@debbugs.gnu.org; Thu, 10 Dec 2020 16:53:22 -0500 Original-Received: by mail-pf1-f177.google.com with SMTP id b26so5431435pfi.3 for <44858@debbugs.gnu.org>; Thu, 10 Dec 2020 13:53:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=bwXBM6AVSYmU4gwOVlgfkGxX0xgpbLHAujBw7MdlIMI=; b=sm5ItliEOz+szvw4FGfpg89naX+EkO1K3jm9Wai9GofI8MDqVyDHaANBtba6RMoDbd ubZiyD1YjlN/QFH9StJjKJGHUSSame7SVOshrMyuXrE+WRvz02E4YK1co0l/TFqYyBEu 8MXxBZFn6hFgxnW3qhXUwa5J9U0Kq5Bx6/mhX3TOe1J3oALN892LyInpR0NZpPs2Uu2w bdRpu5UJu7Z7kwKBVn28REYHWdh3qg5QrdSKKTZWVJ8QBb0N6eN9dumm0rBMKk38BhZd F4XoRKf1g1O47WWc5AEJhPm20zT8tIFWwmqLrlcR9Mra9LKJQNdb6aJUcXPimce9iYYj lUDA== X-Gm-Message-State: AOAM531jUfn88V0PKZM3BH+CcrPrp5qARm8FTY/9OnSXLIQRulEg7XGw Or8eAqw3VW01wc+VrOg2dCFl7JOeSGjpNSt0v5s= X-Google-Smtp-Source: ABdhPJwtLHlcFuOUwP9u+2ogmwOlDQTzEosFvTrZZCtICDoADBq83dNBOOAu314z/Ch7JmWm+10s2o2yaMOdDbobiQM= X-Received: by 2002:a62:e212:0:b029:19d:8cff:f179 with SMTP id a18-20020a62e2120000b029019d8cfff179mr8612932pfi.44.1607637194061; Thu, 10 Dec 2020 13:53:14 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 10 Dec 2020 15:53:13 -0600 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195713 Archived-At: --000000000000e15a1805b62333e6 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > 2. Avoid wide docstrings in define-minor-mode. And here's a patch also for define-derived-mode. It seems like we still need to fix cl-defun, cl-defstruct, define-globalized-minor-mode and perhaps a few others. So I'll work on that next. --000000000000e15a1805b62333e6 Content-Type: text/x-diff; charset="utf-8"; name="0004-Fill-docstrings-in-define-derived-mode.patch" Content-Disposition: attachment; filename="0004-Fill-docstrings-in-define-derived-mode.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: c6e8197079cdee8a_0.1 RnJvbSA1MGYyYTNjY2U1ZGU5NjY1OTk5NTJmZGQxZTZlYTA1OTEzYTk1MGIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVGh1LCAxMCBEZWMgMjAyMCAyMjozNjoxOCArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEZpbGwg ZG9jc3RyaW5ncyBpbiBkZWZpbmUtZGVyaXZlZC1tb2RlCgoqIGxpc3Avc3Vici5lbCAoaW50ZXJu YWwtLWZpbGwtc3RyaW5nKTogTmV3IGZ1bmN0aW9uLgoqIGxpc3AvZW1hY3MtbGlzcC9kZXJpdmVk LmVsIChkZXJpdmVkLW1vZGUtbWFrZS1kb2NzdHJpbmcpOiBGaWxsCmRvY3N0cmluZ3MuCi0tLQog bGlzcC9lbWFjcy1saXNwL2Rlcml2ZWQuZWwgfCA0MiArKysrKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0tLS0tLQogbGlzcC9zdWJyLmVsICAgICAgICAgICAgICAgfCAxMyArKysrKysrKysr KysKIDIgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL2Rlcml2ZWQuZWwgYi9saXNwL2VtYWNzLWxpc3Av ZGVyaXZlZC5lbAppbmRleCA2YTExZjFjMzk0Li4wMGE2YzEyYjEwIDEwMDY0NAotLS0gYS9saXNw L2VtYWNzLWxpc3AvZGVyaXZlZC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvZGVyaXZlZC5lbApA QCAtMzA2LDExICszMDYsMTMgQEAgZGVyaXZlZC1tb2RlLW1ha2UtZG9jc3RyaW5nCiAgICAgICA7 OyBVc2UgYSBkZWZhdWx0IGRvY3N0cmluZy4KICAgICAgIChzZXRxIGRvY3N0cmluZwogCSAgICAo aWYgKG51bGwgcGFyZW50KQotCQk7OyBGSVhNRSBmaWxsaW5nLgotCQkoZm9ybWF0ICJNYWpvci1t b2RlLlxuVXNlcyBrZXltYXAgYCVzJyVzJXMuIiBtYXAKLQkJCShpZiBhYmJyZXYgKGZvcm1hdCAi JXMgYWJicmV2IHRhYmxlIGAlcyciCi0JCQkJCSAgIChpZiBzeW50YXggIiwiICIgYW5kIikgYWJi cmV2KSAiIikKLQkJCShpZiBzeW50YXggKGZvcm1hdCAiIGFuZCBzeW50YXgtdGFibGUgYCVzJyIg c3ludGF4KSAiIikpCisgICAgICAgICAgICAgICAgKGNvbmNhdAorICAgICAgICAgICAgICAgICAi TWFqb3ItbW9kZS5cbiIKKyAgICAgICAgICAgICAgICAgKGludGVybmFsLS1maWxsLXN0cmluZwor ICAgICAgICAgICAgICAgICAgKGZvcm1hdCAiVXNlcyBrZXltYXAgYCVzJyVzJXMuIiBtYXAKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgKGlmIGFiYnJldiAoZm9ybWF0ICIlcyBhYmJyZXYgdGFi bGUgYCVzJyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChp ZiBzeW50YXggIiwiICIgYW5kIikgYWJicmV2KSAiIikKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgKGlmIHN5bnRheCAoZm9ybWF0ICIgYW5kIHN5bnRheC10YWJsZSBgJXMnIiBzeW50YXgpICIi KSkpKQogCSAgICAgIChmb3JtYXQgIk1ham9yIG1vZGUgZGVyaXZlZCBmcm9tIGAlcycgYnkgYGRl ZmluZS1kZXJpdmVkLW1vZGUnLgogSXQgaW5oZXJpdHMgYWxsIG9mIHRoZSBwYXJlbnQncyBhdHRy aWJ1dGVzLCBidXQgaGFzIGl0cyBvd24ga2V5bWFwJXM6CiAKQEAgLTMzNiwyMCArMzM4LDIyIEBA IGRlcml2ZWQtbW9kZS1tYWtlLWRvY3N0cmluZwogICAgICh1bmxlc3MgKHN0cmluZy1tYXRjaCAo cmVnZXhwLXF1b3RlIChzeW1ib2wtbmFtZSBob29rKSkgZG9jc3RyaW5nKQogICAgICAgOzsgTWFr ZSBzdXJlIHRoZSBkb2NzdHJpbmcgbWVudGlvbnMgdGhlIG1vZGUncyBob29rLgogICAgICAgKHNl dHEgZG9jc3RyaW5nCi0JICAgIChjb25jYXQgZG9jc3RyaW5nCi0JCSAgICAoaWYgKG51bGwgcGFy ZW50KQotCQkJIlxuXG5UaGlzIG1vZGUgIgotCQkgICAgICAoY29uY2F0Ci0JCSAgICAgICAiXG5c bkluIGFkZGl0aW9uIHRvIGFueSBob29rcyBpdHMgcGFyZW50IG1vZGUgIgotCQkgICAgICAgKGlm IChzdHJpbmctbWF0Y2ggKGZvcm1hdCAiW2DigJhdJXNbJ+KAmV0iCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJlZ2V4cC1xdW90ZQotCQkJCQkJICAo c3ltYm9sLW5hbWUgcGFyZW50KSkpCi0JCQkJCSBkb2NzdHJpbmcpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICBuaWwKLQkJCSAoZm9ybWF0ICJgJXMnICIgcGFyZW50KSkKLQkJICAgICAgICJt aWdodCBoYXZlIHJ1bixcbnRoaXMgbW9kZSAiKSkKLQkJICAgIChmb3JtYXQgInJ1bnMgdGhlIGhv b2sgYCVzJyIgaG9vaykKLQkJICAgICIsIGFzIHRoZSBmaW5hbCBvciBwZW51bHRpbWF0ZSBzdGVw XG5kdXJpbmcgaW5pdGlhbGl6YXRpb24uIikpKQorICAgICAgICAgICAgKGNvbmNhdCBkb2NzdHJp bmcgIlxuXG4iCisgICAgICAgICAgICAgICAgICAgIChpbnRlcm5hbC0tZmlsbC1zdHJpbmcKKyAg ICAgICAgICAgICAgICAgICAgIChjb25jYXQKKyAgICAgICAgICAgICAgICAgICAgICAoaWYgKG51 bGwgcGFyZW50KQorICAgICAgICAgICAgICAgICAgICAgICAgICAiVGhpcyBtb2RlICIKKyAgICAg ICAgICAgICAgICAgICAgICAgIChjb25jYXQKKyAgICAgICAgICAgICAgICAgICAgICAgICAiSW4g YWRkaXRpb24gdG8gYW55IGhvb2tzIGl0cyBwYXJlbnQgbW9kZSAiCisgICAgICAgICAgICAgICAg ICAgICAgICAgKGlmIChzdHJpbmctbWF0Y2ggKGZvcm1hdCAiW2DigJhdJXNbJ+KAmV0iCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmVnZXhwLXF1 b3RlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KHN5bWJvbC1uYW1lIHBhcmVudCkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGRvY3N0cmluZykKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbmlsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAoZm9ybWF0ICJgJXMnICIgcGFyZW50KSkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAibWlnaHQgaGF2ZSBydW4sIHRoaXMgbW9kZSAiKSkKKyAgICAg ICAgICAgICAgICAgICAgICAoZm9ybWF0ICJydW5zIHRoZSBob29rIGAlcyciIGhvb2spCisgICAg ICAgICAgICAgICAgICAgICAgIiwgYXMgdGhlIGZpbmFsIG9yIHBlbnVsdGltYXRlIHN0ZXAgZHVy aW5nIGluaXRpYWxpemF0aW9uLiIpKSkpKQogCiAgICAgKHVubGVzcyAoc3RyaW5nLW1hdGNoICJc XFxcW3tbXSIgZG9jc3RyaW5nKQogICAgICAgOzsgQW5kIGRvbid0IGZvcmdldCB0byBwdXQgdGhl IG1vZGUncyBrZXltYXAuCmRpZmYgLS1naXQgYS9saXNwL3N1YnIuZWwgYi9saXNwL3N1YnIuZWwK aW5kZXggYzI4ODA3ZjY5NC4uNGQxMGI3MGRiNyAxMDA2NDQKLS0tIGEvbGlzcC9zdWJyLmVsCisr KyBiL2xpc3Avc3Vici5lbApAQCAtNTkyNyw0ICs1OTI3LDE3IEBAIHJ1bi1ob29rLXF1ZXJ5LWVy cm9yLXdpdGgtdGltZW91dAogICAgICA7OyBDb250aW51ZSBydW5uaW5nLgogICAgICBuaWwpKSkK IAorKGRlZnVuIGludGVybmFsLS1maWxsLXN0cmluZyAoc3RyKQorICAiRmlsbCBzdHJpbmcgU1RS IHRvIGBmaWxsLWNvbHVtbicuCitUaGlzIGlzIGludGVuZGVkIGZvciB2ZXJ5IHNpbXBsZSBmaWxs aW5nIHdoaWxlIGJvb3RzdHJhcHBpbmcKK0VtYWNzIGl0c2VsZiwgYW5kIGRvZXMgbm90IHN1cHBv cnQgYWxsIHRoZSBjdXN0b21pemF0aW9uIG9wdGlvbnMKK29mIGZpbGwuZWwgKGZvciBleGFtcGxl IGBmaWxsLXJlZ2lvbicpLiIKKyAgKGlmICg8IChsZW5ndGggc3RyKSBmaWxsLWNvbHVtbikKKyAg ICAgIHN0cgorICAgIChsZXQgKChmc3QgKHN1YnN0cmluZyBzdHIgMCBmaWxsLWNvbHVtbikpCisg ICAgICAgICAgKGxzdCAoc3Vic3RyaW5nIHN0ciBmaWxsLWNvbHVtbikpKQorICAgICAgKGlmIChz dHJpbmctbWF0Y2ggIi4qXFwoIFxcKC4rXFwpXFwpJCIgZnN0KQorICAgICAgICAgIChzZXRxIGZz dCAocmVwbGFjZS1tYXRjaCAiXG5cXDIiIG5pbCBuaWwgZnN0IDEpKSkKKyAgICAgIChjb25jYXQg ZnN0IChpbnRlcm5hbC0tZmlsbC1zdHJpbmcgbHN0KSkpKSkKKwogOzs7IHN1YnIuZWwgZW5kcyBo ZXJlCi0tIAoyLjI5LjIKCg== --000000000000e15a1805b62333e6--