From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history Date: Sat, 10 Feb 2024 05:28:27 -0600 Message-ID: References: <87sf5ge0v6.fsf@runbox.com> <87a5pl1qym.fsf@runbox.com> <87y1d0p9ic.fsf@runbox.com> <874jfibkju.fsf@runbox.com> <87eded2270.fsf@runbox.com> <87sf24l6cv.fsf@runbox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19821"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67000@debbugs.gnu.org, Eli Zaretskii To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 12:29:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYlXf-0004x0-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 12:29:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYlXM-00024K-44; Sat, 10 Feb 2024 06:28:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYlXK-00024C-RS for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 06:28:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYlXK-0007lK-Jd for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 06:28:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYlXa-0006B8-1p for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 06:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Feb 2024 11:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67000-submit@debbugs.gnu.org id=B67000.170756453223726 (code B ref 67000); Sat, 10 Feb 2024 11:29:02 +0000 Original-Received: (at 67000) by debbugs.gnu.org; 10 Feb 2024 11:28:52 +0000 Original-Received: from localhost ([127.0.0.1]:34036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYlXQ-0006Ab-1y for submit@debbugs.gnu.org; Sat, 10 Feb 2024 06:28:52 -0500 Original-Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:53444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYlXN-00069G-Tf for 67000@debbugs.gnu.org; Sat, 10 Feb 2024 06:28:51 -0500 Original-Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5600c43caddso2180369a12.2 for <67000@debbugs.gnu.org>; Sat, 10 Feb 2024 03:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707564508; x=1708169308; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=cmkRTLQ1dlZFdm+ynp0FOau1trYppZ1RQ302rkRmayk=; b=ldVebGw+8yWRxpcnmGxzBttRP05jt7gVx3Bp7qNfNvmDurE7pazqx+GhfrOYlJQFAm J61US3d1HjgiPVlQ9tIJ6lyDzBGlc6KnJvqNcf9aXrPilJttgi7ehyJ3Q5fFNyRvYj4g 4b4lI+Zzann7u/gDZgEQwCVKipC/CWBTiN8Ze0K+0M/2UUgb/usxaaTazlT/DZHTNM8j pVCCLP9MDG4i2H27sg6cyNu0i6lMAcjv33uEHSUQ4KUkgYWhaGGGaZsb/nhFf8S4UKfv E/Run2my9oHX6IKYPo6VOBPMdCjGrwHxkp7izBRHvo8WZviZpLrERbszhpWN8GVP7FUW SxKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707564508; x=1708169308; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cmkRTLQ1dlZFdm+ynp0FOau1trYppZ1RQ302rkRmayk=; b=Fx93DCxFKb3NSXS1QEeA1MqtfdeNPo5m1oi75TGTfBmQXrcQCF8fJbH8IvhInVFzYm VfZ8cMteCGGhVpzQHVTBQ/QaMsVQimOn+xUVOJ+HROXjv/GPHpIY6f+QHFoHXdjC0yh0 xrG+zlXepIP8FfLsArK571zFSHGBdkVuQ7B9XBrkWe1LQ28ZkbX/EDDBk/Pqa3OTjACZ pDYFKR5E6x621ATYDyYXYDOmHwOYmBQOiPO/lhSCk2QjNzqQpITrv9mTYgDKsX7aiGuL uHvniRx7ErRLj6HVWeRiEXNc3iOzD12YJrb2N1g4Os1NbBOe10UlfitC4eLwSuIE+X3g CZ9w== X-Gm-Message-State: AOJu0YyCeVOjagpXx/RECZZpZmgIFE9uMQHTgnN20PYjQmC+6th6bjSU 0WnNqIdw3i1D5KFgMZt1tVt2qhTlT2q3WJCCyiA2wqe7jM5+RlK/V71Lcp5Oo2V/O+qoulEx8+R Qgu7GkHJY2LKur3OznEdlKDVrho8KDW0VERc= X-Google-Smtp-Source: AGHT+IELhx0Wv+vFQkc2/X+ZNU3IrzAgW2VTXo35rMzJ8PhzTCvc0VyPLo99/z7FpRd4SytzFuUaf9J4u8zcsyzojb0= X-Received: by 2002:a50:ee8b:0:b0:560:799:f802 with SMTP id f11-20020a50ee8b000000b005600799f802mr920870edr.21.1707564508547; Sat, 10 Feb 2024 03:28:28 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 10 Feb 2024 05:28:27 -0600 In-Reply-To: <87sf24l6cv.fsf@runbox.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279748 Archived-At: Simen Heggest=C3=B8yl writes: > Hi Stefan, thanks for your feedback. An updated patch is attached. LGTM, please install. Feel free to handle the minor comments below as you think is best, or disregard them. Thanks! >>> +(defcustom ielm-history-file-name >>> + (locate-user-emacs-file "ielm-history.eld") >>> + "If non-nil, name of the file to read/write IELM input history." >>> + :type '(choice (const :tag "nil" nil) >> >> The tag here should be "Disable input history" or something like that. > > Ok. Should it be updated for `comint-input-ring-file-name' too then (I > copied it from there)? Yes, that could be improved too. > From fe91c4f3aaefc109135c48ba26f8f21e87db465e Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Simen=3D20Heggest=3DC3=3DB8yl?=3D > Date: Tue, 16 Jan 2024 08:21:41 +0100 > Subject: [PATCH] Add support for reading/writing IELM input history > > * lisp/ielm.el (inferior-emacs-lisp-mode): Add support for > reading/writing input history. How about: "Add support for saving input history to a file" > (ielm--history-file-name): Name of the file to read/write IELM input > history. Maybe: "New variable indicating IELM input history file. > +(defcustom ielm-history-file-name > + (locate-user-emacs-file "ielm-history.eld") > + "If non-nil, name of the file to read/write IELM input history." > + :type '(choice (const :tag "Disable input history" nil) > + file) > + :version "30.1") Maybe `file' should have a tag too?