From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#37656: 27.0.50; Arbitrary code execution with special `mode:' Date: Wed, 16 Oct 2019 00:55:08 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000f3162c0594fae02c" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="10446"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37656@debbugs.gnu.org, Emacs developers To: adam plaice Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 00:56:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKVjh-0002Yj-Si for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 00:56:14 +0200 Original-Received: from localhost ([::1]:32938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKVjg-0000mw-Jj for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 18:56:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41286) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKVjY-0000ig-6Y for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 18:56:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKVjX-0006ar-9M for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 18:56:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36185) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKVjW-0006aP-D8 for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 18:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKVjW-0005ub-99 for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 18:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37656 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 37656-submit@debbugs.gnu.org id=B37656.157118012922683 (code B ref 37656); Tue, 15 Oct 2019 22:56:02 +0000 Original-Received: (at 37656) by debbugs.gnu.org; 15 Oct 2019 22:55:29 +0000 Original-Received: from localhost ([127.0.0.1]:45006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKViy-0005tl-OE for submit@debbugs.gnu.org; Tue, 15 Oct 2019 18:55:29 -0400 Original-Received: from mail-pl1-f173.google.com ([209.85.214.173]:44942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKViw-0005tV-C1 for 37656@debbugs.gnu.org; Tue, 15 Oct 2019 18:55:26 -0400 Original-Received: by mail-pl1-f173.google.com with SMTP id q15so10274887pll.11 for <37656@debbugs.gnu.org>; Tue, 15 Oct 2019 15:55:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nuBzhgXjTjvDvg5yvQZVeOPK7wF+q8Zl4WRMa28YpMM=; b=XqW5B/nwTP8qr9D4SJTkX30WF3UxDN368ONA1/Qz44ScRsv5hRrZ8FR2pXocVBDoeP p6DDd6jU6ANMXLpW0/Afl6C1gZNB//zcs6aJ0MsrmzXoGvoKrKy1/rENsPsCtjsWj/a9 D/2ylNS3zO2yY5TtPF5ypStqz+QwYNYhI1WFoKiVBiQw3zGcjEkhdesvPsNVj5SPLacQ zoxzL6pKl9NgBqwXha1igO/pcsY61TwBGPGGOfjiCd7T1LUrBd84Mwafk0IaQQcIuayq 6wQjbg8jE22vWPfdiuu76qf3CclQ00Sxad2fxzaQosRimo9Mi/BvcsWH1sDwVyVcV7AJ Uc8A== X-Gm-Message-State: APjAAAWBHhKCxZi6eQrRRtakKs5giE8rYHOJkT3E7hkWjtBs598cOzIe aSeWAfTY5YEtU7pW3cZVywqlTsMywf1qrvde/pw= X-Google-Smtp-Source: APXvYqwq7RF2D68Cm33dkbsoy/0ZllZGovTcG3KOPNRoeY4aNVimY2Bsr2n+Z+vt4/3nCzkrSRLEMertXrqBA9wZOBE= X-Received: by 2002:a17:902:d888:: with SMTP id b8mr39003592plz.259.1571180120298; Tue, 15 Oct 2019 15:55:20 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169403 gmane.emacs.devel:241072 Archived-At: --000000000000f3162c0594fae02c Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > The below patch seems to fix it by disabling the feature it exploits. Here is a more complete patch. Does it look like the right fix? I think the relevant node in the documentation is: (info "(emacs)Choosing Modes") Best regards, Stefan Kangas --000000000000f3162c0594fae02c Content-Type: application/octet-stream; name="0001-Remove-support-for-more-than-one-mode-in-file-local-.patch" Content-Disposition: attachment; filename="0001-Remove-support-for-more-than-one-mode-in-file-local-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1sg1dki0 RnJvbSBkNjQwZWZlOTcwZWQxZmRkNWYxMjYyZDA5YmZkNmQ1NjRjOGU3ZjgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDE2IE9jdCAyMDE5IDAwOjQ0OjU2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g UmVtb3ZlIHN1cHBvcnQgZm9yIG1vcmUgdGhhbiBvbmUgbW9kZSBpbiBmaWxlIGxvY2FsIHZhcmlh YmxlcwoKKiBsaXNwL2ZpbGVzLmVsIChzZXQtYXV0by1tb2RlKTogUmVtb3ZlIHN1cHBvcnQgZm9y IHNwZWNpZnlpbmcKbW9yZSB0aGFuIG9uZSBtYWpvciBtb2RlIGluIGZpbGUgbG9jYWwgdmFyaWFi bGVzLiAgKEJ1ZyMzNzY1NikKKiBldGMvTkVXUzogQW5ub3VuY2UgaXQuCi0tLQogZXRjL05FV1Mg ICAgICB8ICA3ICsrKysrKysKIGxpc3AvZmlsZXMuZWwgfCAxMyArKysrKysrLS0tLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBkMDZmMGE1OTUyLi5kMGNlYzA1MTQzIDEwMDY0 NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTk3LDYgKzE5NywxMyBAQCB0aGUg bmV3IHZlcnNpb24gb2YgdGhlIGZpbGUgYWdhaW4uKQogDAogKiBDaGFuZ2VzIGluIEVtYWNzIDI3 LjEKIAorLS0tCisqKiBGaWxlIGxvY2FsIHZhcmlhYmxlcyBjYW4gbm93IHNwZWNpZnkgb25seSBv bmUgbWFqb3IgbW9kZS4KK1ByZXZpb3VzbHksIGl0IHdhcyBwb3NzaWJsZSB0byBzcGVjaWZ5IG1v cmUgdGhhbiBvbmUgbWFqb3IgbW9kZSB1c2luZworZmlsZSBsb2NhbCB2YXJpYWJsZXMuICBBIHNl Y3VyaXR5IGlzc3VlIHdhcyBkaXNjb3ZlcmVkIHdoZXJlIGFuCithdHRhY2tlciBjb3VsZCBleHBs b2l0IHRoaXMgZmVhdHVyZSB1c2luZyBhIHNwZWNpYWxseSBjcmFmdGVkIGZpbGUsCit3aGljaCBj b3VsZCBsZWFkIHRvIGFyYml0cmFyeSBjb2RlIGV4ZWN1dGlvbiB3aGVuIHRoZSBmaWxlIHdhcyBv cGVuZWQuCisKICoqIGVtYWNzY2xpZW50CiAKICsrKwpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5l bCBiL2xpc3AvZmlsZXMuZWwKaW5kZXggNDA4MDc2MTdmYS4uNDFjMWJhNjBlZCAxMDA2NDQKLS0t IGEvbGlzcC9maWxlcy5lbAorKysgYi9saXNwL2ZpbGVzLmVsCkBAIC0zMDY2LDEyICszMDY2LDEz IEBAIHNldC1hdXRvLW1vZGUKIAkgICB0cnktbG9jYWxzCiAJICAgKHNldHEgZW5kIChzZXQtYXV0 by1tb2RlLTEpKQogCSAgIChpZiAoc2F2ZS1leGN1cnNpb24gKHNlYXJjaC1mb3J3YXJkICI6IiBl bmQgdCkpCi0JICAgICAgIDs7IEZpbmQgYWxsIHNwZWNpZmljYXRpb25zIGZvciB0aGUgYG1vZGU6 JyB2YXJpYWJsZQotCSAgICAgICA7OyBhbmQgZXhlY3V0ZSB0aGVtIGxlZnQgdG8gcmlnaHQuCi0J ICAgICAgICh3aGlsZSAobGV0ICgoY2FzZS1mb2xkLXNlYXJjaCB0KSkKLQkJCShvciAoYW5kIChs b29raW5nLWF0ICJtb2RlOiIpCi0JCQkJIChnb3RvLWNoYXIgKG1hdGNoLWVuZCAwKSkpCi0JCQkg ICAgKHJlLXNlYXJjaC1mb3J3YXJkICJbIFx0O11tb2RlOiIgZW5kIHQpKSkKKwkgICAgICAgOzsg RmluZCB0aGUgc3BlY2lmaWNhdGlvbiBvZiB0aGUgYG1vZGU6JyB2YXJpYWJsZSBhbmQKKwkgICAg ICAgOzsgZXhlY3V0ZSBpdC4gIFdlIG5ldmVyIHdhbnQgdG8gZXhlY3V0ZSBtb3JlIHRoYW4gb25l CisJICAgICAgIDs7IG1vZGUgZm9yIHNlY3VyaXR5IHJlYXNvbnMuICAoQnVnIzM3NjU2KQorCSAg ICAgICAod2hlbiAobGV0ICgoY2FzZS1mb2xkLXNlYXJjaCB0KSkKKwkJICAgICAgIChvciAoYW5k IChsb29raW5nLWF0ICJtb2RlOiIpCisJCQkJKGdvdG8tY2hhciAobWF0Y2gtZW5kIDApKSkKKwkJ CSAgIChyZS1zZWFyY2gtZm9yd2FyZCAiWyBcdDtdbW9kZToiIGVuZCB0KSkpCiAJCSAoc2tpcC1j aGFycy1mb3J3YXJkICIgXHQiKQogCQkgKGxldCAoKGJlZyAocG9pbnQpKSkKIAkJICAgKGlmIChz ZWFyY2gtZm9yd2FyZCAiOyIgZW5kIHQpCi0tIAoyLjIzLjAKCg== --000000000000f3162c0594fae02c--