From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 64ea1a1: Fix eshell for systems that do not have subprocesses Date: Sun, 12 Dec 2021 00:17:52 -0800 Message-ID: References: <20211212075134.13255.37107@vcs0.savannah.gnu.org> <20211212075136.10D6020A0A@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32000"; mail-complaints-to="usenet@ciao.gmane.io" To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 12 09:19:38 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwK53-0008AE-NY for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Dec 2021 09:19:37 +0100 Original-Received: from localhost ([::1]:48470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwK52-0002Ab-Ej for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Dec 2021 03:19:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwK3Q-0000v2-7h for emacs-devel@gnu.org; Sun, 12 Dec 2021 03:17:58 -0500 Original-Received: from [2607:f8b0:4864:20::631] (port=36813 helo=mail-pl1-x631.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwK3O-0002Gf-Cs for emacs-devel@gnu.org; Sun, 12 Dec 2021 03:17:55 -0500 Original-Received: by mail-pl1-x631.google.com with SMTP id u11so9100781plf.3 for ; Sun, 12 Dec 2021 00:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=KAMKTzQiLuVoNmyBz3gfy2PUuF8J1XbfCBKLbmCxGpw=; b=foKaFuCIwLslj0IfV9XQCkCflWEuRZSngW9kfWyZqee1IIpUzAGn0r9BVCu4DUmZGL rYLXgqx9SAZ6MYMIvMzEFEn2IKz/TEpuTd8fl5QAGxL805IVGbPKv2pCj64b7ZXyLw43 h4b7VSruWohKzEo19tGItfHGBafZjkDBiqNsF+ND7ATszxHvTQbgGYXrWhEACgQjkkq/ bdrj9tsneQp8RXv6qq0He9JQ2yQzJncbvYqC+z9cQmQzjuZl22xNu04MsnYPwhOur02v YPP2Hfw8/moT4UmyKwPu6XDPRjpLC3o2ijL9TFZHtEbXHurVq31qGOiQaQetvUwhIjdG KIlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=KAMKTzQiLuVoNmyBz3gfy2PUuF8J1XbfCBKLbmCxGpw=; b=JqV/SGPsdMb5gGCYbiHhQ9lf2royrW5Ot5bmGYFtpKQrFpSF7icRMiyFfk14NAtwGi dXXOgvkqGdDH+fw9E+I9FliBaZm2RpnwhPBey5Z01FS7X5eJE3FvIDJEkKguAhEhUqMJ DSrI22msjTgzzxfED8h1chBcb7US7vZmWbgNiz2u/LbIiQaOTmzQffKw7EzeL/TCEQAF 4gs0elZG8xCbnVKbgslSgVXgeq3JDLfmg4JJUi+82HiHDgEApDShyqQiNECsM6fqlSaY i8WvcPxb+og6r88I8f0gC2grJpzf2E//um1/WzJ8kFyvf+A+FcjbFhtMvJdAPmDdXsDp u6TQ== X-Gm-Message-State: AOAM530kYwTQFbHSD/Ip32Sh3K4mBIARYwcMshFieplZhlVc+5N86OkM Z9UKJGfa6A/0fhC5fJJyYnGheXtvNLacXCU5WUw= X-Google-Smtp-Source: ABdhPJx1kFIdEztm7HnTawi9G4TSyX0wBvAg8qynGD0VBkJoNhkQNeDWCJOprCxCnP9kgDMRycU4iAbD43opby1uMHs= X-Received: by 2002:a17:902:b20a:b0:143:7add:5ab7 with SMTP id t10-20020a170902b20a00b001437add5ab7mr86529955plr.71.1639297073018; Sun, 12 Dec 2021 00:17:53 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 12 Dec 2021 00:17:52 -0800 In-Reply-To: <20211212075136.10D6020A0A@vcs0.savannah.gnu.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::631 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281773 Archived-At: luangruo--- via Mailing list for Emacs changes writes: > branch: emacs-28 > commit 64ea1a178c6cb3a436eeb6783237bd603be4f5e4 > Author: Po Lu > Commit: Po Lu > > Fix eshell for systems that do not have subprocesses > > * lisp/eshell/esh-cmd.el (eshell-eval-command): Use > `eshell-processp' instead of `processp'. > --- > lisp/eshell/esh-cmd.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lisp/eshell/esh-cmd.el b/lisp/eshell/esh-cmd.el > index a2464ad..213b7ab 100644 > --- a/lisp/eshell/esh-cmd.el > +++ b/lisp/eshell/esh-cmd.el > @@ -945,12 +945,12 @@ at the moment are: > ;; In that case, unwrap the value before checking the delimiter > ;; value. > (if (and val > - (not (processp val)) > + (not (eshell-processp val)) > (not (eq val t))) > (error "Unmatched delimiter: %S" val) > ;; Eshell-command expect a list like () to know if the > ;; command should be async or not. > - (or (and (processp val) delim) val))))) > + (or (and (eshell-processp val) delim) val))))) > > (defun eshell-resume-command (proc status) > "Resume the current command when a process ends." Is this relevant only to MS-DOS? If yes, should we add a comment to that effect to `eshell-processp'?