From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Sun, 24 Oct 2021 13:11:26 -0700 Message-ID: References: <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> <87r1chfz80.fsf@gnus.org> <83r1chcjof.fsf@gnu.org> <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> <83wnm8c3v3.fsf@gnu.org> <87tuhcc1u1.fsf@gnus.org> <83tuhcaqad.fsf@gnu.org> <881r4fq5b8.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2998"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50752@debbugs.gnu.org, Lars Ingebrigtsen , shuguang79@qq.com To: Glenn Morris , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 24 22:12:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mejql-0000Yf-9v for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 22:12:11 +0200 Original-Received: from localhost ([::1]:40246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mejqj-0001D4-Ii for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 16:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mejqc-0001Ce-VR for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 16:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mejqc-0001dE-Mm for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 16:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mejqc-0003Mb-EJ for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 16:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2021 20:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163510629512896 (code B ref 50752); Sun, 24 Oct 2021 20:12:02 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 24 Oct 2021 20:11:35 +0000 Original-Received: from localhost ([127.0.0.1]:41049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mejqB-0003Lw-KP for submit@debbugs.gnu.org; Sun, 24 Oct 2021 16:11:35 -0400 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:40476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mejq9-0003Lg-7o for 50752@debbugs.gnu.org; Sun, 24 Oct 2021 16:11:33 -0400 Original-Received: by mail-pl1-f169.google.com with SMTP id v20so6473577plo.7 for <50752@debbugs.gnu.org>; Sun, 24 Oct 2021 13:11:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=WJzixjcN+nUr1miXVJt7d1VDRXNZOvvxETCdpcwdt6Q=; b=M6Eh0ZVgqe3ImLk12mc27fq7Wc/TN2O3bdbOG5xLfE+pn84HlIP2Bi99pWKSY+lzGU O+kyXtgY2Yn6EHNGGxWNQwyoQLzQkKke3clFbNOo5GaugEyaazdpa4FkEK3AVS6LZxvW wIy6SZU/Oe7SvbQ4LvZgAAcslUy06Hd5o/8arEvuwqoztzzTtOzmS0gOei1jJMUHWtIs EJXldLLaAVBw4gUmVrZb/IOK1kUeGXXyBMPHG8ea70h5n+ZNhpz+XHnenmzU1K3Z7rko POc7Jo5AsFyidAlfEorJCyEijtgQWHmEx8IZWntb7/RVftVUO2SisYchd4ITddoc9jS3 KydA== X-Gm-Message-State: AOAM531BfPvpAjSL9XBE6g+Wa5xDKZ1ClauoXlUDHWmj7EsdZM3OUVRo pWPxEhy7781+MMgaXtCnDXKjR0yPjxnySC4dqbs= X-Google-Smtp-Source: ABdhPJxHv8sVuO/eQUBxplPpTIruwK0+sEcz+O2EcmSOdxt5LN0aqdEXmLwHXxUQvklalf7yKpdDl7mZJqXWRS3TFVc= X-Received: by 2002:a17:90b:3b86:: with SMTP id pc6mr12998265pjb.143.1635106287371; Sun, 24 Oct 2021 13:11:27 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Oct 2021 13:11:26 -0700 In-Reply-To: <881r4fq5b8.fsf@fencepost.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218199 Archived-At: Glenn Morris writes: > It's very late to comment, but was the approach of adding an optional > argument to easy-menu-define that specifies the precise string to intern > (in place of "(downcase (car menu))"), and using that argument where > needed in those Emacs files that were converted to use easymenu, > rejected? I think at this point, the main counter-argument is that we have one of the fixes ready, whereas the other one isn't. I have been mulling your message over the past couple of days, and I can't really see that your proposed solution is significantly better. The chosen solution allows us to side-step the issue with a small and localized change. Furthermore, the approach we have chosen here is IMO not that complicated, at least not on a basic level. Written in Lisp, it would be very straight-forward indeed, but it turned out that with the structure of our code it was easier to just write it in C. So I would suggest pushing my fix to emacs-28, so that we can give it as much testing as possible. At this stage, it feels important to make sure there is some fix on the emacs-28 branch so that we can start testing it and gather feedback.