bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key

[Stefan Kangas <stefan@marxist.se>]

Glenn Morris <rgm@gnu.org> writes:

> It's very late to comment, but was the approach of adding an optional
> argument to easy-menu-define that specifies the precise string to intern
> (in place of "(downcase (car menu))"), and using that argument where
> needed in those Emacs files that were converted to use easymenu,
> rejected?

I think at this point, the main counter-argument is that we have one of
the fixes ready, whereas the other one isn't.  I have been mulling your
message over the past couple of days, and I can't really see that your
proposed solution is significantly better.  The chosen solution allows
us to side-step the issue with a small and localized change.

Furthermore, the approach we have chosen here is IMO not that
complicated, at least not on a basic level.  Written in Lisp, it would
be very straight-forward indeed, but it turned out that with the
structure of our code it was easier to just write it in C.

So I would suggest pushing my fix to emacs-28, so that we can give it as
much testing as possible.  At this stage, it feels important to make
sure there is some fix on the emacs-28 branch so that we can start
testing it and gather feedback.