From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding Date: Sun, 11 Dec 2022 18:21:26 -0800 Message-ID: References: <83v8mkzrvj.fsf@gnu.org> <83o7sczl1x.fsf@gnu.org> <83k02yv1n7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23035"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59920@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 03:22:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4YSR-0005lo-55 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 03:22:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4YSC-0002r8-6v; Sun, 11 Dec 2022 21:22:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4YSA-0002qz-OK for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 21:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4YSA-00083P-Gm for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 21:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4YSA-0006BR-5w for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 21:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 02:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59920-submit@debbugs.gnu.org id=B59920.167081169323759 (code B ref 59920); Mon, 12 Dec 2022 02:22:02 +0000 Original-Received: (at 59920) by debbugs.gnu.org; 12 Dec 2022 02:21:33 +0000 Original-Received: from localhost ([127.0.0.1]:49582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4YRh-0006B9-94 for submit@debbugs.gnu.org; Sun, 11 Dec 2022 21:21:33 -0500 Original-Received: from mail-oa1-f52.google.com ([209.85.160.52]:41678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4YRg-0006B1-I1 for 59920@debbugs.gnu.org; Sun, 11 Dec 2022 21:21:32 -0500 Original-Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1441d7d40c6so6851820fac.8 for <59920@debbugs.gnu.org>; Sun, 11 Dec 2022 18:21:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=HF6bA5MtKatW8itbHsYBn18LBwSfsoRy1mUZwZg9DSY=; b=B4aMbf5Lp6BrrS96mXT6rIQNX2hYLf9DMUTcLzQRtHRPXGZamYOGuXO63v/Stb4FOB 8bA3OD1COHFXqu9Ic253MuckPBwo0wiNnGpwvLsRFJeSvOFJIZlkfF2fntTgGzWm2E0j ZEpHwsIYzK/sfhgFCDSZcy5hSCQCuJxIJOZEspfvGNLQtBrRNKCqQ/p4akm/2dZ5JjdR I/whGlzbyx1MBO+RlPrW3aQnOXuK6S8wcU+wPeE12QiBgg+lMWgvZvNklDjVyTtic2hO Oimx22cNQNBaQw3m5LdTnbvkd5Mlloxf+St0OuvM69zZc2MBycznXho/SMKcUs2lpCiF xXUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HF6bA5MtKatW8itbHsYBn18LBwSfsoRy1mUZwZg9DSY=; b=JsibaT2NR8GkEcuRGbXViRzns5BBiuVRxiFSWSmO3t4rk7gu5Fc02NyNitkYmi7QYI vbS7owtqRhpFx5TDJZTGngyyNRWbywMVznUippWRgM+IcYjIgTbNP+4gTJ8hzI4dxs8w dCWuGXLjWfwiUCfgqPDhoTfvrboZCDWMq4NvKqCGr6SUYUjcFwK7taKPApNfslizEVcd dr5Fw4WTBbquATk+9oZQgCpP+MfiY3e22/6HGsF3zVgsvKKegO6EKA84znzpg7Mr8GzF DOXzeXCbTwPNcmq4nfwjmvciS+ND6FSS8hQVG2E3w8Z83GZ6m/nszpNy7UirBpb6sdcK GP8g== X-Gm-Message-State: ANoB5pkjfS2+DYjbkYB8/zwfExT+Bb0lRWP1Wuiw2+/SunIwNM7lZHMF coXOeTgTBTm0yNHE1Gezymaz6gbECWNE4jtT4bY= X-Google-Smtp-Source: AA0mqf71rNPLSBO6PwxhPGmcSk9JcY+vXXWwAuOkaxlduL0hlpj/23TkED5pSudAZp3HwcfGi4YRj9rQxZUMfuAig0A= X-Received: by 2002:a05:6870:7813:b0:148:28c1:3d46 with SMTP id hb19-20020a056870781300b0014828c13d46mr278147oab.199.1670811686846; Sun, 11 Dec 2022 18:21:26 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 11 Dec 2022 18:21:26 -0800 In-Reply-To: <83k02yv1n7.fsf@gnu.org> X-Hashcash: 1:20:221212:eliz@gnu.org::ltwq6RTN1QggLriQ:0Ldb X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250668 Archived-At: Eli Zaretskii writes: >> +(defcustom checkdoc-lexical-binding-flag t >> + "Non-nil means generate warnings if file is not using lexical binding. >> +See Info node `(elisp) Converting to Lexical Binding' for more." >> + :type 'boolean >> + :version "29.1") > > Should be "30.1", I guess? Yes, well spotted. >> + (checkdoc-create-error >> + "The first line should end with \"-*- lexical-binding: t -*-\"" > > Is this accurate? IOW, does the lexical-binding cookie have to be the > last on the first line? You're right, it's not accurate. I changed it to say: The first line should contain "-*- lexical-binding: t -*-" > Otherwise, LGTM, thanks. Thanks.