From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#18632: 24.3.94; image-dired fail when `image-dired-dir' doesn't exist Date: Thu, 15 Sep 2022 17:39:33 -0700 Message-ID: References: <871tqmskw1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21901"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 18632@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 16 02:40:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYzPB-0005QS-KI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Sep 2022 02:40:29 +0200 Original-Received: from localhost ([::1]:55928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYzPA-0002CS-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 20:40:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYzOk-0002BG-KM for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 20:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYzOk-0005yH-CO for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 20:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYzOk-0004bF-2P for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 20:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Sep 2022 00:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 18632-submit@debbugs.gnu.org id=B18632.166328878117641 (code B ref 18632); Fri, 16 Sep 2022 00:40:02 +0000 Original-Received: (at 18632) by debbugs.gnu.org; 16 Sep 2022 00:39:41 +0000 Original-Received: from localhost ([127.0.0.1]:59585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYzOO-0004aR-Hw for submit@debbugs.gnu.org; Thu, 15 Sep 2022 20:39:40 -0400 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:36415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYzON-0004Zw-BJ for 18632@debbugs.gnu.org; Thu, 15 Sep 2022 20:39:39 -0400 Original-Received: by mail-ot1-f45.google.com with SMTP id w10-20020a056830410a00b00655d70a1aeaso1380603ott.3 for <18632@debbugs.gnu.org>; Thu, 15 Sep 2022 17:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:user-agent:references :in-reply-to:from:from:to:cc:subject:date; bh=ATVChbDKsRAICPvnverVNn2Py/KW647YREi1pkjB2l4=; b=f86mvwy5l8+x/gxHnyoxdGww/rWdkHNcFHh0oKLxP2k1yheMN1ow06NC+85CII7R/8 bAqoq6Zfa23LWzKMRCCd0SiIxH2LjGMTdhlQG2PBDuwTglve3D/7T4iqV4DG0xkk1uSg hQCa6YcN32PcZ1ERdIDVPs6erhdeNRgdnbHQ9VcqjqTRvJ/K8Cw3STf0ATG2ao8qjNd0 f7LPXGvLuNPtTpx40+9tsVGJfJu8WrLQAGWENJwm4Ufq71WQFa5cpN0Oi9HA9Se6GMrT 9qgtx7xeb9RKSUHCfCR9MDPqRIgWGwxtrwSWJXcxmgnOgLWtUYIVfHBl9GHTMk1Ye6vM 5a8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:user-agent:references :in-reply-to:from:x-gm-message-state:from:to:cc:subject:date; bh=ATVChbDKsRAICPvnverVNn2Py/KW647YREi1pkjB2l4=; b=4Tx5gFPUaB7SAHUP/lAPMmJr7ouVDutPsJ5aGYera76l4b88RCkpOZPhS8CN2+biWj +26CQys+4+XpNVWf82i1PAbA933TaRLCdS4jr/uZpUKg4eyOu/gTOsJrzIQTOr/dkZlr GC7HOw+cpbB5fwfgLiYREQUeTKZgro1pYud5sLuLrBxPZ14A+o8KaiLJIsphw13r8jOq vifzvCh/o45/OICH8hhgg3vdUVCztMJwdvTl5b4SLESIYkMorsdULJUA+fToxSPQ/qzs cEI5hDJ8JQrcNQWT/MIgKrBxvzbjca6jp4TcNFKybyLut0cle79gyydqd+O4SqiukEmV z1Cw== X-Gm-Message-State: ACrzQf1IgTv9DHO4iix5y5s/VjzIU44/4s/V/PRwPXrmeVn+LLDJ9ddm 1DfJMFZNKjBtWQ9yLGz4V3pswQcVLrLmtrDXqtQ= X-Google-Smtp-Source: AMsMyM7nnsiC7f1p20YZ07vx7CFk/EYzXli6M2G1fAcS+T7e5+c9ktgR6l1Go6Spx7rLkkkFfLFhh3H1rK5W1HHVb8I= X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id p1-20020a05683003c100b0063728be7920mr1086377otc.105.1663288773820; Thu, 15 Sep 2022 17:39:33 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 15 Sep 2022 17:39:33 -0700 In-Reply-To: (Stefan Kangas's message of "Fri, 30 Aug 2019 00:32:52 +0200") X-Hashcash: 1:20:220916:18632@debbugs.gnu.org::DH5iwmDWctH1huJ/:3VCe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242671 Archived-At: close 18632 29.1 thanks Stefan Kangas writes: > Thierry Volpiatto writes: > >>> If `image-dired-dir' doesn't exists, image-dired fail with >>> something like "could not resize image" with no indications on what is happening. >>> IOW image-dired should create its directory when this one doesn't >>> exists, or at least send a helpful message to notify user he have first >>> to create manually this directory. >> >> diff --git a/lisp/image-dired.el b/lisp/image-dired.el >> index 114deab..01f88c2 100644 >> --- a/lisp/image-dired.el >> +++ b/lisp/image-dired.el >> @@ -1800,7 +1800,8 @@ should feel snappy enough. >> >> If optional argument ORIGINAL-SIZE is non-nil, display image in its >> original size." >> - (let ((new-file (expand-file-name image-dired-temp-image-file)) >> + (let ((new-file (expand-file-name image-dired-temp-image-file >> + (image-dired-dir))) >> width height command ret >> (image-type 'jpeg)) >> (setq file (expand-file-name file)) > > I can reproduce this on current master. The problem happens when the > user removes the image-dired-dir directory (normally > ~/.emacs.d/image-dired). I can no longer reproduce this on current master. I think this was fixed when we rewrote `image-dired-display-image-mode' to be based on `image-mode' instead of using external programs to convert the picture. If you are still seeing this issue, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report.