From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44849: [PATCH] Make XEmacs compat variable warning-level-aliases obsolete Date: Thu, 10 Dec 2020 11:24:42 -0600 Message-ID: References: <87blfl29a0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6473"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44849@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 10 18:44:41 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knPzb-00019N-Pp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Dec 2020 18:44:39 +0100 Original-Received: from localhost ([::1]:58724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knPzH-0002GU-A6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Dec 2020 12:44:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knPgd-0007iW-6C for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 12:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knPgc-0003Ly-GZ for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 12:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knPgc-0001yS-Cs for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 12:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Dec 2020 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44849 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44849-submit@debbugs.gnu.org id=B44849.16076210907566 (code B ref 44849); Thu, 10 Dec 2020 17:25:02 +0000 Original-Received: (at 44849) by debbugs.gnu.org; 10 Dec 2020 17:24:50 +0000 Original-Received: from localhost ([127.0.0.1]:39205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knPgQ-0001xy-J4 for submit@debbugs.gnu.org; Thu, 10 Dec 2020 12:24:50 -0500 Original-Received: from mail-pl1-f174.google.com ([209.85.214.174]:41361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knPgP-0001xk-7E for 44849@debbugs.gnu.org; Thu, 10 Dec 2020 12:24:50 -0500 Original-Received: by mail-pl1-f174.google.com with SMTP id y8so3107739plp.8 for <44849@debbugs.gnu.org>; Thu, 10 Dec 2020 09:24:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=dHHPTNZUTNTihvwGJrEjfQ07Kqv58KNJIgLHnNKSmj0=; b=HN+OpdTOM8rjdjhoRhkFUJZIipsysvXjxD0vd+pC/u82qZjqu8PcFuscbcMe8K67+W /HgH7xp4sJ2SDU09QQrLfPz72ieS63/JeKHiKMbLZYKdaNty75WpMqHZz/2ExgJIBMZb nTpa2v3YIj0+M/Aw9MAZP2rf+zCD+KiRx9Nr88+P/vUFLah79OYH1KLo5Tpbxpg7lpr5 iziOP/TFhLrjwIi3SDhOaisiZdZClEn8dCPCp51Md+3dDWqK7sGhmmlH0iSbcLyZM/n+ 8jbPpg6vqQozTYb65XRWqISKb5CJ7ZrdWcL1h3cjEIJNel+bf1b1+4s541YboTfoHWCp uXsw== X-Gm-Message-State: AOAM53181VqXzhUig0VrRBDzrsWAuWyvTQnVGWcTKSV4Mz5SvlUsf9QT yAqilPMDDdeAcKoQYnABVTiHuKpOKeVukAdDFt8= X-Google-Smtp-Source: ABdhPJxPgL3QUiJpbAd3Ob62mXtXjoeQ7/8GMIX9EicUEpHUAgIhkbYtaR0AsoI/gRRb8/kZniCmMOd+u9uaiVYlRTE= X-Received: by 2002:a17:902:9309:b029:db:c725:d19c with SMTP id bc9-20020a1709029309b02900dbc725d19cmr7534320plb.39.1607621083386; Thu, 10 Dec 2020 09:24:43 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 10 Dec 2020 11:24:42 -0600 In-Reply-To: <87blfl29a0.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195675 Archived-At: Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> The `warning-level-aliases' exists only to provide compatibility with >> XEmacs warning levels. I don't think this is very useful these days. >> >> I propose to make it obsolete and warn when one of these levels are >> used. Please see the attached patch. > > I'm slightly worried that these aliases are used out there in > out-of-tree packages. As a test, I grepped the GNU ELPA tree, but this > was the only place where the aliases are used: > > (defun muse-display-warning (message) > "Display the given MESSAGE as a warning." > (if (fboundp 'display-warning) > (display-warning 'muse message > (if (featurep 'xemacs) > 'warning > :warning)) > > And that's behind a featurep check, so it's fine, too. > > So I think the proposed change is probably fine. Thanks. I agree, and the way it is written it will simply show a warning in case such a usage is not behind a featurep check. There have been no further comments within 2 weeks, so I intend to push the change in the next couple of days unless there are any objections.