From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#62317: 28.2; This byte-compiled file behaves wrongly. Date: Wed, 13 Sep 2023 07:02:38 -0700 Message-ID: References: <20230321.125408.609857763486645873.teika@gmx.com> <83ilefy1d9.fsf@gnu.org> <83a5zqyiaj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15183"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62317@debbugs.gnu.org, Eli Zaretskii , teika@gmx.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 16:03:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgQSY-0003f4-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 16:03:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgQSJ-0002WR-1G; Wed, 13 Sep 2023 10:02:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgQSI-0002Uj-Bt for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:02:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgQSI-0001sd-3E for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:02:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgQSM-0000l2-HX for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62317-submit@debbugs.gnu.org id=B62317.16946137762882 (code B ref 62317); Wed, 13 Sep 2023 14:03:02 +0000 Original-Received: (at 62317) by debbugs.gnu.org; 13 Sep 2023 14:02:56 +0000 Original-Received: from localhost ([127.0.0.1]:35458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgQSF-0000kQ-82 for submit@debbugs.gnu.org; Wed, 13 Sep 2023 10:02:55 -0400 Original-Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:49615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgQSA-0000jw-MB for 62317@debbugs.gnu.org; Wed, 13 Sep 2023 10:02:54 -0400 Original-Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b9d07a8d84so115567371fa.3 for <62317@debbugs.gnu.org>; Wed, 13 Sep 2023 07:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694613759; x=1695218559; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=NnhGhEccsW30d0pA4scIGvkN2aiL6eDpmSSSyl/StTg=; b=MLaHmbSAQXDXEGYUcAyBkxE+wbFQnAcr79mezxbrBWLAq2jQNf5LqRosSkFDJg7Vcg cCzjbrV97NekHCvwR+PLa3SyV+awf5yr9ovPLZe9bwLyfrF6IlG4PykNi1I/P0LWT0F3 eAQyGX76JuHkOq/qLFZdPRvBmlTtJiJIHqBMT9cv22QOm8KzR+fFddRwRHIS3HD3crSY GKRuGgXkitzAGOeWJHEN3ceEkgplSO318Smb0jM0Exk12Y3WY9Y7QdPsaInkltaSA5FX UEwsuOCkq71dzhtDUj9Pp0Z0pXX3tesXjW/znY5CSFZadlRHwHPw34pWcHaxVJtg5IVr 3JzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694613759; x=1695218559; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NnhGhEccsW30d0pA4scIGvkN2aiL6eDpmSSSyl/StTg=; b=mL9nTjd49RB3F57RdQV/hZzW/0igKfAopjhyWK867TIcfGyuNTwNMDo2Z+6LX1sdjM 8Bi6fIgu113sJcyMLjS6T2QjFjIpOv/1XGXUriTSY4iZKt3eV68yAIQ9nllp08c2b/FW PFGzuwXh1+nPyu1TWuxBmbD6Qw8yS8Tf2nV5254Ytz602kDXULLzmr+0ACnr37z+dL7/ SVg0ni9MtYc6aaXYJ1Mid1hGukpEqJSucVEqRqW5mG46TRX/rSNIduxYrTMnsVatTeiq kTMnupEhTH/OTpc714XIHbm/k3rh2N4tof66w5Tsx8dvKtg3Jq1dmasVtRTd9aYtBaTw zSJQ== X-Gm-Message-State: AOJu0YwxnajX16rczEHsAV9jMiRah9qsqKU/hTPYi1QmXRqdcIMweWJY JRzqA4dWBwaWyeLN3SruRs4sLS1cKwxwOGtnvE0= X-Google-Smtp-Source: AGHT+IEsWSzXdzdIySabFadgI8u8GEiGcLQo47G7zKuD4sphG1XxVJquV80i9h8pb22WzLOeSqKIyJr7aFK7WPz77Gw= X-Received: by 2002:a2e:330a:0:b0:2b9:f0b4:eaa1 with SMTP id d10-20020a2e330a000000b002b9f0b4eaa1mr2377067ljc.16.1694613759310; Wed, 13 Sep 2023 07:02:39 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 07:02:38 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270285 Archived-At: Stefan Monnier writes: >> It seems like this patch was never installed. > > To be honest, I'm not sure it's worth the trouble. > > I'd argue that the bug is in having side-effects like that inside > `eval-and/when-compile` (or at the top-level of a `require`d file). > The patch only caters to changes to the `current_buffer` but there can > be many other ways to cause similar troubles and I can't think of a good > way to confine them all. Good point. It seems rather unusual to call `set-buffer' from the top-level of a required file, to say the least. And if we accept that, users can start calling all kinds of weird and wonderful things. On the other hand, the fix seems innocuous enough. Eli, what do you think? Should we close this as wontfix?