bug#74600: [PATCH scratch/igc] fix mps library check

bug#74600: [PATCH scratch/igc] fix mps library check

[Yikai Zhao]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

--with-mps detection failed when building with --without-x:

config.log:

configure:28292: checking for mps_arena_create in -lmps
configure:28317: gcc -o conftest -g3 -O2     conftest.c -lmps  -lsqlite3   >&5
/usr/local/bin/ld: /usr/local/lib/libmps.a(mps.o): in function
`PThreadextModuleInit':
/work/mps-release-1.118.0/code/pthrdext.c:139:(.text+0x499b):
undefined reference to `sem_init'
/usr/local/bin/ld: /usr/local/lib/libmps.a(mps.o): in function `LockInit':
/work/mps-release-1.118.0/code/lockix.c:88:(.text+0x404c3): undefined
reference to `pthread_mutexattr_init'
/usr/local/bin/ld:
/work/mps-release-1.118.0/code/lockix.c:90:(.text+0x404d8): undefined
reference to `pthread_mutexattr_settype'
/usr/local/bin/ld:
/work/mps-release-1.118.0/code/lockix.c:94:(.text+0x404fc): undefined
reference to `pthread_mutexattr_destroy'
/usr/local/bin/ld:
/work/mps-release-1.118.0/code/lockix.c:94:(.text+0x405bd): undefined
reference to `pthread_mutexattr_destroy'
...

[-- Attachment #2: 0001-Fix-mps-library-check.patch --]
[-- Type: text/x-patch, Size: 1089 bytes --]

From 6c9058814d299f33c6d4db81d3351e1343354fb6 Mon Sep 17 00:00:00 2001
From: Yikai Zhao <yikai@z1k.dev>
Date: Fri, 29 Nov 2024 15:40:21 +0800
Subject: [PATCH] Fix mps library check

; * configure.ac (with_mps): add LIB_PTHREAD
---
 configure.ac | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index fc64535dd69..885075a2f1d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5624,16 +5624,16 @@ AC_DEFUN
 IGCOBJ=
 if test "${with_mps}" != "no"; then
   AC_CHECK_HEADER([mps.h],
-    [AC_CHECK_LIB([mps], [mps_arena_create], [HAVE_MPS=yes])])
+    [AC_CHECK_LIB([mps], [mps_arena_create], [HAVE_MPS=yes], [], [$LIB_PTHREAD])])
 
   if test "${HAVE_MPS}" = "yes"; then
     IGCOBJ="igc.o"
     AC_DEFINE([HAVE_MPS], [1],
       [Define to 1 if you have the mps library (-lmps).])
     if test "${with_mps}" = "debug"; then
-      LIBMPS=-lmps-debug
+      LIBMPS="-lmps-debug $LIB_PTHREAD"
     else
-      LIBMPS=-lmps
+      LIBMPS="-lmps $LIB_PTHREAD"
     fi
   else
     AC_MSG_ERROR([The MPS library libmps is missing]):
-- 
2.34.1

bug#74600: [PATCH scratch/igc] fix mps library check

[Gerd Möllmann]

Yikai Zhao <yikai@z1k.dev> writes:

> --with-mps detection failed when building with --without-x:

Thanks! I've pushed your patch, since I can see other commits from you
in master. It works fine for me on macOS, too, BTW.

bug#74600: [PATCH scratch/igc] fix mps library check

[Stefan Kangas]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> Yikai Zhao <yikai@z1k.dev> writes:
>
>> --with-mps detection failed when building with --without-x:
>
> Thanks! I've pushed your patch, since I can see other commits from you
> in master. It works fine for me on macOS, too, BTW.

I'm therefore closing this bug report.