From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: lekktu@gmail.com, 8951@debbugs.gnu.org, 17052@debbugs.gnu.org
Subject: bug#17052: substitute-command-keys strips text properties
Date: Sun, 18 Aug 2019 19:08:18 +0200 [thread overview]
Message-ID: <CADwFkm=BwxU5NXp00MrHzuTG12mZ+OzbqDp5zKTpaLjBnnP33A@mail.gmail.com> (raw)
In-Reply-To: <87h86iuk39.fsf@mouse.gnus.org>
[In reply to Bug#17052 and cross-posting to Bug#8951.]
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I had a look at that function now and, er, no. :-) Perhaps it should
> be rewritten in Emacs Lisp? Then it'd be pretty trivial to fix this
> stuff.
The Fsubstitute_command_keys function is indeed a bit hairy, and I
agree that a conversion to Lisp is the most reasonable next step.
I've actually been working a patch to convert it to Lisp for Bug#8951,
but it's not finished yet. The difficulty is that it has a couple of
helper functions that also needs to be lifted, which makes the job
bigger than just the function Fsubstitute_command_keys.
My goal is to get the Lisp version to produce the same output as the C
version, which currently seems to be a feasible goal. Once it's in
Lisp it should be easier to make further improvements, fix bugs, etc.
Thanks,
Stefan Kangas
next prev parent reply other threads:[~2019-08-18 17:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 16:22 bug#17052: substitute-command-keys strips text properties Juanma Barranquero
2019-08-15 0:55 ` Lars Ingebrigtsen
2019-08-15 1:34 ` Glenn Morris
2019-08-15 1:58 ` Lars Ingebrigtsen
2019-08-15 16:46 ` Eli Zaretskii
2019-08-15 22:42 ` Lars Ingebrigtsen
2019-08-16 6:47 ` Eli Zaretskii
2019-08-16 7:04 ` Lars Ingebrigtsen
2019-08-18 17:08 ` Stefan Kangas [this message]
2019-08-18 17:19 ` Eli Zaretskii
2019-08-18 22:43 ` Lars Ingebrigtsen
2019-08-19 15:27 ` Eli Zaretskii
2019-08-18 17:19 ` Lars Ingebrigtsen
2020-11-17 1:24 ` Stefan Kangas
2020-11-17 1:37 ` bug#17052: substitute-command-keys strips text properties, bug#8911: huh? Drew Adams
2020-11-17 2:34 ` Stefan Kangas
2020-11-17 3:00 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=BwxU5NXp00MrHzuTG12mZ+OzbqDp5zKTpaLjBnnP33A@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=17052@debbugs.gnu.org \
--cc=8951@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.