From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com
Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds
Date: Tue, 2 Nov 2021 08:26:12 -0700 [thread overview]
Message-ID: <CADwFkm=8zdYQNkzEFAMYQhGfU+tzAqpc00MuA3_Z+7ZrfG59iQ@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmkW-FUxcwWdaxE_+oiibbB2h5J+Bi59RzskU6eJqwiEMg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
Stefan Kangas <stefan@marxist.se> writes:
>> As for foreground: what does it mean to remove the foreground from an
>> image?
(I realize that I didn't answer this part in my previous reply.) SVG is
a special case, where we just use the foreground of the current face.
In this case, I think the fix is as simple as the attached patch. I've
tested this with several themes, and it looks very good to my eyes.
I suggest that we install this fix on emacs-28.
[-- Attachment #2: 0001-Use-current-face-foreground-for-SVG-icons-in-customi.patch --]
[-- Type: text/x-diff, Size: 4310 bytes --]
From b6682bb4f3d7992f0594b848605937f358f93a33 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Tue, 2 Nov 2021 16:21:19 +0100
Subject: [PATCH] Use current face foreground for SVG icons in customize
* etc/images/down.svg:
* etc/images/left.svg:
* etc/images/right.svg:
* etc/images/up.svg: Don't define foreground; this means they will use
the foreground of the currently defined face instead. (Bug#51556)
---
etc/images/down.svg | 2 +-
etc/images/left.svg | 2 +-
etc/images/right.svg | 2 +-
etc/images/up.svg | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/etc/images/down.svg b/etc/images/down.svg
index e2760427d7..707cd23ea4 100644
--- a/etc/images/down.svg
+++ b/etc/images/down.svg
@@ -25,7 +25,7 @@
<title id='title8473'>Gnome Symbolic Icons</title>
<defs id='defs7386'/>
<g inkscape:groupmode='layer' id='layer10' inkscape:label='ui' transform='translate(-152.00586,-952)'>
- <path inkscape:connector-curvature='0' d='m 166,957 -5.99414,5.99999 L 154,957 Z' id='path6424' sodipodi:nodetypes='cccc' style='fill:#2e3436;fill-opacity:1;stroke:none'/>
+ <path inkscape:connector-curvature='0' d='m 166,957 -5.99414,5.99999 L 154,957 Z' id='path6424' sodipodi:nodetypes='cccc' style='fill-opacity:1;stroke:none'/>
</g>
<g inkscape:groupmode='layer' id='layer1' inkscape:label='status' transform='translate(-152.00586,-888)'/>
<g inkscape:groupmode='layer' id='layer11' inkscape:label='legacy' transform='translate(-152.00586,-952)'/>
diff --git a/etc/images/left.svg b/etc/images/left.svg
index d6429bc410..893515d2df 100644
--- a/etc/images/left.svg
+++ b/etc/images/left.svg
@@ -25,7 +25,7 @@
<title id='title8473'>Gnome Symbolic Icons</title>
<defs id='defs7386'/>
<g inkscape:groupmode='layer' id='layer10' inkscape:label='ui' transform='translate(-92.005848,-951.99999)'>
- <path inkscape:connector-curvature='0' d='M 103,966 97.00585,959.99999 103,954 Z' id='path6400' sodipodi:nodetypes='cccc' style='fill:#2e3436;fill-opacity:1;stroke:none'/>
+ <path inkscape:connector-curvature='0' d='M 103,966 97.00585,959.99999 103,954 Z' id='path6400' sodipodi:nodetypes='cccc' style='fill-opacity:1;stroke:none'/>
</g>
<g inkscape:groupmode='layer' id='layer1' inkscape:label='status' transform='translate(-92.005848,-887.99999)'/>
<g inkscape:groupmode='layer' id='layer11' inkscape:label='legacy' transform='translate(-92.005848,-951.99999)'/>
diff --git a/etc/images/right.svg b/etc/images/right.svg
index d58cd36435..6c7d715939 100644
--- a/etc/images/right.svg
+++ b/etc/images/right.svg
@@ -25,7 +25,7 @@
<title id='title8473'>Gnome Symbolic Icons</title>
<defs id='defs7386'/>
<g inkscape:groupmode='layer' id='layer10' inkscape:label='ui' transform='translate(-112.00585,-951.99999)'>
- <path inkscape:connector-curvature='0' d='m 117,966 6.00585,-6.00001 L 117,954 Z' id='path6412' sodipodi:nodetypes='cccc' style='fill:#2e3436;fill-opacity:1;stroke:none'/>
+ <path inkscape:connector-curvature='0' d='m 117,966 6.00585,-6.00001 L 117,954 Z' id='path6412' sodipodi:nodetypes='cccc' style='fill-opacity:1;stroke:none'/>
</g>
<g inkscape:groupmode='layer' id='layer1' inkscape:label='status' transform='translate(-112.00585,-887.99999)'/>
<g inkscape:groupmode='layer' id='layer11' inkscape:label='legacy' transform='translate(-112.00585,-951.99999)'/>
diff --git a/etc/images/up.svg b/etc/images/up.svg
index 9e1a245be7..e358c29912 100644
--- a/etc/images/up.svg
+++ b/etc/images/up.svg
@@ -25,7 +25,7 @@
<title id='title8473'>Gnome Symbolic Icons</title>
<defs id='defs7386'/>
<g inkscape:groupmode='layer' id='layer10' inkscape:label='ui' transform='translate(-132.00585,-952)'>
- <path inkscape:connector-curvature='0' d='M 146,963 140.00585,956.99999 134,963 Z' id='path6418' sodipodi:nodetypes='cccc' style='fill:#2e3436;fill-opacity:1;stroke:none'/>
+ <path inkscape:connector-curvature='0' d='M 146,963 140.00585,956.99999 134,963 Z' id='path6418' sodipodi:nodetypes='cccc' style='fill-opacity:1;stroke:none'/>
</g>
<g inkscape:groupmode='layer' id='layer1' inkscape:label='status' transform='translate(-132.00585,-888)'/>
<g inkscape:groupmode='layer' id='layer11' inkscape:label='legacy' transform='translate(-132.00585,-952)'/>
--
2.30.2
next prev parent reply other threads:[~2021-11-02 15:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:56 bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Kévin Le Gouguec
2021-11-01 19:14 ` Eli Zaretskii
2021-11-01 20:10 ` Kévin Le Gouguec
2021-11-02 12:40 ` Eli Zaretskii
2021-11-01 20:49 ` Jim Porter
2021-11-02 12:49 ` Eli Zaretskii
2021-11-02 14:41 ` Stefan Kangas
2021-11-02 14:59 ` Eli Zaretskii
2021-11-02 15:17 ` Stefan Kangas
2021-11-02 15:26 ` Stefan Kangas [this message]
2021-11-02 16:38 ` Eli Zaretskii
2021-11-02 16:43 ` Lars Ingebrigtsen
2021-11-02 17:01 ` Stefan Kangas
2021-11-02 17:13 ` Eli Zaretskii
2021-11-02 17:44 ` Stefan Kangas
2021-11-02 18:01 ` Eli Zaretskii
2021-11-02 18:43 ` Stefan Kangas
2021-11-02 18:53 ` Eli Zaretskii
2021-11-02 19:26 ` Stefan Kangas
2021-11-02 18:43 ` Jim Porter
2021-11-02 18:58 ` Stefan Kangas
2021-11-02 19:15 ` Eli Zaretskii
2021-11-02 19:44 ` Stefan Kangas
2021-11-02 20:19 ` Alan Third
2021-11-02 22:56 ` Kévin Le Gouguec
2021-11-04 8:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=8zdYQNkzEFAMYQhGfU+tzAqpc00MuA3_Z+7ZrfG59iQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=51556@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=kevin.legouguec@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.