From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Adam Porter <adam@alphapapa.net>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: 2a73673 Change how thread-first/thread-last indent the first argument
Date: Wed, 6 Oct 2021 12:27:14 +0200 [thread overview]
Message-ID: <CADwFkm=7oy9AwpmjcHO+cA6yP+KRR81OMnPmkUKq9DBcBqi_Gw@mail.gmail.com> (raw)
In-Reply-To: <87bl42frku.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I don't really have much of an opinion here -- but the old indentation
> looks like a bug to me. If the thread-first/last community disagrees
> with this, I'm open to reverting the patch. Does anybody else have an
> opinion here?
I don't have a strong opinion, but I'm personally not too concerned
about some churn given that "git blame" has an option to ignore
whitespace changes. (Magit uses that flag by default, and if I'm not
mistaken VC does too.)
As for aggressive-indent, it does sound like a somewhat unusual
use-case. I only re-indent code specifically when it makes sense.
When looking over my diff before committing, I usually double-check to
see that I'm not accidentally doing some random re-indenting unless
I'm also changing those lines, or otherwise have some specific reason
to do it (for example, if it substantially improves readability).
Just my two cents.
next prev parent reply other threads:[~2021-10-06 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 6:58 2a73673 Change how thread-first/thread-last indent the first argument Adam Porter
2021-10-05 7:35 ` Lars Ingebrigtsen
2021-10-05 8:41 ` Adam Porter
2021-10-05 14:50 ` Basil L. Contovounesios
2021-10-06 9:08 ` Lars Ingebrigtsen
2021-10-06 10:27 ` Stefan Kangas [this message]
2021-10-06 11:32 ` Adam Porter
2021-10-06 10:49 ` Adam Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=7oy9AwpmjcHO+cA6yP+KRR81OMnPmkUKq9DBcBqi_Gw@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.