From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37120: [PATCH] Prefer display-line-numbers over linum in docs and custom Date: Tue, 20 Aug 2019 20:18:49 +0200 Message-ID: References: <835zmrlnvv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="35639"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37120@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 20 20:20:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i08js-00096F-Mn for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 20:20:12 +0200 Original-Received: from localhost ([::1]:40314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i08jq-0000uQ-VX for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 14:20:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58972) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i08jj-0000uF-Cd for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 14:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i08ji-0003TK-AU for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 14:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i08ji-0003TG-70 for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 14:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i08jh-0000UH-V9 for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 14:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 18:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37120 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37120-submit@debbugs.gnu.org id=B37120.15663251481806 (code B ref 37120); Tue, 20 Aug 2019 18:20:01 +0000 Original-Received: (at 37120) by debbugs.gnu.org; 20 Aug 2019 18:19:08 +0000 Original-Received: from localhost ([127.0.0.1]:33900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i08iq-0000T3-C1 for submit@debbugs.gnu.org; Tue, 20 Aug 2019 14:19:08 -0400 Original-Received: from mail-pg1-f180.google.com ([209.85.215.180]:46405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i08ip-0000Sj-1v for 37120@debbugs.gnu.org; Tue, 20 Aug 2019 14:19:07 -0400 Original-Received: by mail-pg1-f180.google.com with SMTP id m3so3674245pgv.13 for <37120@debbugs.gnu.org>; Tue, 20 Aug 2019 11:19:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qzvdeQOMKfMRunA7Ac/qMnh6awniVpg2Hm8jasLP5o8=; b=Pb4PJ9LxaWPJpf4icXVjNLd9MX2BCrpIIBJSMmY7lB4r3NxBCQuOreSgQdUzN4dgcm UaegVJRAW4OTEZIXxlTWVJLKO15lH5Qq6YyhIvrNGBxtoql1sg1TfLXvtuk/PBaKBgde S5YJL6CjHjSV175l/cyABchwTYpr9ZTa0qgoH+VKgGF4wJ172Sl4TDzn4WVYL6ddXQZs /7HbpLzr739FpZTzdf9pZoZdjIR6HfIyiLCPNPe3griqmV9cY6jJUUf6NcQLYXSbPTam oLIHa8oFtSCnLNZIZpTlE8mpxZne6nz9RqwU/a668ySMoLDsk/uhJftYMa+WIDu9bAxA +FCA== X-Gm-Message-State: APjAAAVrhTCZ+LS6E1WG6vZsZLf90nCNq4yjN5FWbjZpSSI8yhhMD6Wp dlO5wO1UoOEABgxAkLsJlt8BBSPGuL/5fO5AMV1wv8S6 X-Google-Smtp-Source: APXvYqw7gHRpVCOfo5c1hya1qbxhQlszh15PKWf1FLgxJseTKyyXjdVQ87hJK1KCwmttTj1/Mj7tuA/9T0fZbagHu9E= X-Received: by 2002:a63:4c5c:: with SMTP id m28mr27248915pgl.333.1566325141098; Tue, 20 Aug 2019 11:19:01 -0700 (PDT) In-Reply-To: <835zmrlnvv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165433 Archived-At: Eli Zaretskii writes: > Thanks, but see the comments below. Thanks for reviewing this patch. > > --- a/doc/misc/efaq.texi > > +++ b/doc/misc/efaq.texi > > @@ -1687,7 +1687,7 @@ Displaying the current line or column > > this variable. > > > > @cindex Set number capability in @code{vi} emulators > > -The @samp{linum} package (distributed with Emacs since version 23.1) > > +@samp{display-line-numbers-mode} (added to Emacs in version 26.1) > > displays line numbers in the left margin, like the ``set number'' > > capability of @code{vi}. The packages @samp{setnu} and > > This is incorrect: display-line-numbers-mode doesn't use the display > margin (linum.el did). Would "displays line numbers on the left side of the current window" be more precise? > > diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el > > index cb39e62265..8d3513bad3 100644 > > --- a/lisp/progmodes/prog-mode.el > > +++ b/lisp/progmodes/prog-mode.el > > @@ -39,7 +39,8 @@ prog-mode > > (defcustom prog-mode-hook nil > > "Normal hook run when entering programming modes." > > :type 'hook > > - :options '(flyspell-prog-mode abbrev-mode flymake-mode linum-mode > > + :options '(flyspell-prog-mode abbrev-mode flymake-mode > > + display-line-numbers-mode > > prettify-symbols-mode) > > Hmm... is it reasonable to run prog-mode-hook just because someone > turns on line numbers? It sounds too drastic to me. I'm not sure I understand what you mean. I thought that this just means that when running M-x customize-option RET prog-mode-hook RET we show display-line-numbers-mode instead of linum-mode as an option. Is there something I'm missing here? Best regards, Stefan Kangas