all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: Po Lu <luangruo@yahoo.com>,
	60415-done@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER
Date: Wed, 6 Sep 2023 00:02:09 -0700	[thread overview]
Message-ID: <CADwFkm=4y1+vWncmGeME8YZESXTpR1cjs6Jh7_w+nU=V2zxECQ@mail.gmail.com> (raw)
In-Reply-To: <63EDF87C-B085-41C4-86F1-4AEF6A998F8D@gmail.com> (Yuan Fu's message of "Sat, 31 Dec 2022 18:18:39 -0800")

Yuan Fu <casouri@gmail.com> writes:

>> On Dec 31, 2022, at 5:09 PM, Po Lu <luangruo@yahoo.com> wrote:
>>
>> Paul Eggert <eggert@cs.ucla.edu> writes:
>>
>>> On my platform the current Emacs master (commit
>>> 91ae9f3d12885373d38c3e8d693f7dc210f9d471) won't build, failing with:
>>>
>>>   ELC      progmodes/typescript-ts-mode.elc
>>>
>>> In toplevel form:
>>> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function
>>> definition is vo\
>>> id: treesit-query-compile
>>>
>>>
>>> Full log (compressed) attached, built from Git on Fedora 37
>>> x86-64. The best fix isn't immediately obvious to me; adding a
>>> declare-function doesn't work.
>>>
>>> This platform doesn't have the tree-sitter library, so
>>> HAVE_TREE_SITTER is not defined which means C doesn't define
>>> treesit-query-compile.
>>>
>>> I will probably just install the tree-sitter library to work around
>>> the bug, but thought I'd document it. Presumably you can simulate it
>>> by configuring --without-tree-sitter.
>>
>> Copying in Yuan Fu.
>>
>> Would people please test their changes on an Emacs *WITHOUT* tree-sitter
>> before installing them in the future?
>
> Yeah I’ve setup a no-tree-sitter build so I could catch these in the future. Sorry for the inconvenience.

That was 9 months ago.

I'm assuming this has been fixed by now, and that the bug was left open
by accident.  Therefore, I'm closing this bug report.

If anyone is still seeing this, please report back and we can
investigate.

Thanks.





      reply	other threads:[~2023-09-06  7:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  4:46 bug#60415: Emacs master doesn't build if !HAVE_TREE_SITTER Paul Eggert
2023-01-01  1:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-01  2:18   ` Yuan Fu
2023-09-06  7:02     ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=4y1+vWncmGeME8YZESXTpR1cjs6Jh7_w+nU=V2zxECQ@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=60415-done@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.