From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#6207: 23.1; align.el vhdl rules setup Date: Sat, 28 Sep 2019 13:07:03 +0200 Message-ID: References: <871vdayqp6.fsf@blah.blah> <871rw3w6xy.fsf@tcd.ie> <87sgojrnv6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000567fc305939b01eb" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191687"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Reto Zimmermann , 6207@debbugs.gnu.org, John Wiegley , Stefan Monnier To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 28 13:08:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEAai-000nk4-TS for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 13:08:45 +0200 Original-Received: from localhost ([::1]:60302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEAah-0007XC-N9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 07:08:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57159) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEAa4-0007Wy-6V for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 07:08:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEAa2-0004wa-Ar for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 07:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEAa2-0004ux-2j for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 07:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEAa1-0001NN-Qq for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 07:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2019 11:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6207-submit@debbugs.gnu.org id=B6207.15696688425241 (code B ref 6207); Sat, 28 Sep 2019 11:08:01 +0000 Original-Received: (at 6207) by debbugs.gnu.org; 28 Sep 2019 11:07:22 +0000 Original-Received: from localhost ([127.0.0.1]:49413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEAZO-0001MT-6I for submit@debbugs.gnu.org; Sat, 28 Sep 2019 07:07:22 -0400 Original-Received: from mail-pl1-f193.google.com ([209.85.214.193]:40394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEAZM-0001MH-Qp for 6207@debbugs.gnu.org; Sat, 28 Sep 2019 07:07:21 -0400 Original-Received: by mail-pl1-f193.google.com with SMTP id d22so2056129pll.7 for <6207@debbugs.gnu.org>; Sat, 28 Sep 2019 04:07:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BYtA3W7rhaJ8TDFkYOqX+hlGw8OAs659kGSCg+5kwBg=; b=O2R3y3+9ZfsEmQ6X3WEbz5LE5FVlOY52P5Am9g3YOj1Bb8M+4kVQEETNlB2/oxjPQl dIU7njPZ1XCa3URfL6vpOUmb3VoW7XlSBwvjx+75lbP14jeE/DkrNhAeKiEhp13NV9bS S2YeJt346k91MdvzMOkTddWnRHNo0KcFUX/N/vi8dF3UzQv/e0S806udWNSvdiRhUZq+ +/07SGGwaUxWtRk+zY5qh8teWYixUL7UX/qVG4PIzCDOiEf6PuCXlFOFiuupYlZxpJT5 NZAb0ZP6vGAaJpXQwopFmyuosiv4LX1dv/cGpF7ZaHA4Mw7HDNwuFbOi9xFE1jSWr3O7 PIpg== X-Gm-Message-State: APjAAAUEUnInY5o7YdgnayXbutyyPltVxPDPEyN2PVqWl7CtRWNDu7zT wgUsKzZ8I+703J12yfL3lDPcv/0geh7v+s7xyrM= X-Google-Smtp-Source: APXvYqzr6i6qVTTzm6pwgaeejXt0KLIJnk024d62t/AEhCjZmlFLpjquFYVv2bq6qDz+5MeBeK1YAP53iGqOZMEk7x4= X-Received: by 2002:a17:902:326:: with SMTP id 35mr10187151pld.128.1569668835200; Sat, 28 Sep 2019 04:07:15 -0700 (PDT) In-Reply-To: <87sgojrnv6.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167470 Archived-At: --000000000000567fc305939b01eb Content-Type: text/plain; charset="UTF-8" Basil L. Contovounesios writes: > > Ugh. Thanks for spotting these issues. I'm a bit sick and tired > > today, so maybe I should just stay away from coding for the day... > > Hope you feel better soon! Thanks - I feel much better today. :-) > > I've attached an updated patch. > > Thanks, just one remaining nit: > > > +(make-obsolete-variable 'align-vhdl-rules-list "no longer used" "27.1") > ^^ > CURRENT-NAME should end with a full stop; see docstring of make-obsolete. Fixed in the attached patch. If there are no further comments, I intend to commit this in a couple of days. Best regards, Stefan Kangas --000000000000567fc305939b01eb Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Declare-unused-vhdl-code-in-align.el-obsolete.patch" Content-Disposition: attachment; filename="0001-Declare-unused-vhdl-code-in-align.el-obsolete.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k13ga65x0 RnJvbSAwNDJiNjJlNmJiMjA4OTE0ZjE0YTkyYTI3OGNlM2UyYzg5ZTM0ZWE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUaHUsIDI2IFNlcCAyMDE5IDEyOjMxOjM3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g RGVjbGFyZSB1bnVzZWQgdmhkbCBjb2RlIGluIGFsaWduLmVsIG9ic29sZXRlCgoqIGxpc3AvYWxp Z24uZWwgKGFsaWduLXZoZGwtcnVsZXMtbGlzdCwgYWxpZ24tc2V0LXZoZGwtcnVsZXMpOiBEZWNs YXJlCm9ic29sZXRlLiAgKEJ1ZyM2MjA3KQooYWxpZ24tZHEtc3RyaW5nLW1vZGVzLCBhbGlnbi1v cGVuLWNvbW1lbnQtbW9kZXMpOiBNb3ZlIHZoZGwtbW9kZSB0bwpkZWZpbml0aW9uIGluc3RlYWQg b2YgYWRkaW5nIGl0IGxhdGVyLgotLS0KIGxpc3AvYWxpZ24uZWwgfCAxNiArKysrKy0tLS0tLS0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9saXNwL2FsaWduLmVsIGIvbGlzcC9hbGlnbi5lbAppbmRleCBjZDcyZDUyZGY0 Li5kODNmODM0MWM5IDEwMDY0NAotLS0gYS9saXNwL2FsaWduLmVsCisrKyBiL2xpc3AvYWxpZ24u ZWwKQEAgLTIwNiw3ICsyMDYsNyBAQCBhbGlnbi10ZXh0LW1vZGVzCiAKIChkZWZjdXN0b20gYWxp Z24tZHEtc3RyaW5nLW1vZGVzCiAgIChhcHBlbmQgYWxpZ24tbGlzcC1tb2RlcyBhbGlnbi1jKyst bW9kZXMgYWxpZ24tcGVybC1tb2RlcwotCSAgJyhweXRob24tbW9kZSkpCisgICAgICAgICAgJyhw eXRob24tbW9kZSB2aGRsLW1vZGUpKQogICAiQSBsaXN0IG9mIG1vZGVzIHdoZXJlIGRvdWJsZSBx dW90ZWQgc3RyaW5ncyBzaG91bGQgYmUgZXhjbHVkZWQuIgogICA6dHlwZSAnKHJlcGVhdCBzeW1i b2wpCiAgIDpncm91cCAnYWxpZ24pCkBAIC0yMTksNyArMjE5LDcgQEAgYWxpZ24tc3Etc3RyaW5n LW1vZGVzCiAKIChkZWZjdXN0b20gYWxpZ24tb3Blbi1jb21tZW50LW1vZGVzCiAgIChhcHBlbmQg YWxpZ24tbGlzcC1tb2RlcyBhbGlnbi1jKystbW9kZXMgYWxpZ24tcGVybC1tb2RlcwotCSAgJyhw eXRob24tbW9kZSBtYWtlZmlsZS1tb2RlKSkKKyAgICAgICAgICAnKHB5dGhvbi1tb2RlIG1ha2Vm aWxlLW1vZGUgdmhkbC1tb2RlKSkKICAgIkEgbGlzdCBvZiBtb2RlcyB3aXRoIGEgc2luZ2xlLWxp bmUgY29tbWVudCBzeW50YXguCiBUaGVzZSBhcmUgY29tbWVudHMgYXMgaW4gTGlzcCwgd2hpY2gg aGF2ZSBhIGJlZ2lubmluZywgYnV0IGVuZCB3aXRoCiB0aGUgbGluZSAoaS5lLiwgYGNvbW1lbnQt ZW5kJyBpcyBhbiBlbXB0eSBzdHJpbmcpLiIKQEAgLTgwNSw5ICs4MDUsNyBAQCBhbGlnbi1oaWdo bGlnaHQtb3ZlcmxheXMKIChkZWZ2YXIgYWxpZ24tcmVnZXhwLWhpc3RvcnkgbmlsCiAgICJJbnB1 dCBoaXN0b3J5IGZvciB0aGUgZnVsbCB1c2VyLWVudGVyZWQgcmVnZXggaW4gYGFsaWduLXJlZ2V4 cCciKQogCi07OyBTYW1wbGUgZXh0ZW5zaW9uIHJ1bGUgc2V0LCBmb3IgdmhkbC1tb2RlLiAgVGhp cyBzaG91bGQgcHJvcGVybHkgYmUKLTs7IGluIHZoZGwtbW9kZS5lbCBpdHNlbGYuCi0KKzs7IFNh bXBsZSBleHRlbnNpb24gcnVsZSBzZXQgZm9yIHZoZGwtbW9kZS4gIFRoaXMgaXMgbm93IG9ic29s ZXRlLgogKGRlZmN1c3RvbSBhbGlnbi12aGRsLXJ1bGVzLWxpc3QKICAgYCgodmhkbC1kZWNsYXJh dGlvbgogICAgICAocmVnZXhwICAgLiAiXFwoc2lnbmFsXFx8dmFyaWFibGVcXHxjb25zdGFudFxc KVxcKFxccy0rXFwpXFxTLSIpCkBAIC04NDIsMTggKzg0MCwxNCBAQCBhbGlnbi12aGRsLXJ1bGVz LWxpc3QKICAgIkFsaWdubWVudCBydWxlcyBmb3IgYHZoZGwtbW9kZScuICBTZWUgYGFsaWduLXJ1 bGVzLWxpc3QnIGZvciBtb3JlIGluZm8uIgogICA6dHlwZSBhbGlnbi1ydWxlcy1saXN0LXR5cGUK ICAgOmdyb3VwICdhbGlnbikKLQogKHB1dCAnYWxpZ24tdmhkbC1ydWxlcy1saXN0ICdyaXNreS1s b2NhbC12YXJpYWJsZSB0KQorKG1ha2Utb2Jzb2xldGUtdmFyaWFibGUgJ2FsaWduLXZoZGwtcnVs ZXMtbGlzdCAibm8gbG9uZ2VyIHVzZWQuIiAiMjcuMSIpCiAKIChkZWZ1biBhbGlnbi1zZXQtdmhk bC1ydWxlcyAoKQogICAiU2V0dXAgdGhlIGBhbGlnbi1tb2RlLXJ1bGVzLWxpc3QnIHZhcmlhYmxl IGZvciBgdmhkbC1tb2RlJy4iCisgIChkZWNsYXJlIChvYnNvbGV0ZSBuaWwgIjI3LjEiKSkKICAg KHNldHEgYWxpZ24tbW9kZS1ydWxlcy1saXN0IGFsaWduLXZoZGwtcnVsZXMtbGlzdCkpCiAKLShh ZGQtaG9vayAndmhkbC1tb2RlLWhvb2sgJ2FsaWduLXNldC12aGRsLXJ1bGVzKQotCi0oYWRkLXRv LWxpc3QgJ2FsaWduLWRxLXN0cmluZy1tb2RlcyAndmhkbC1tb2RlKQotKGFkZC10by1saXN0ICdh bGlnbi1vcGVuLWNvbW1lbnQtbW9kZXMgJ3ZoZGwtbW9kZSkKLQogOzs7IFVzZXIgRnVuY3Rpb25z OgogCiA7OzsjIyNhdXRvbG9hZAotLSAKMi4yMC4xCgo= --000000000000567fc305939b01eb--