From: Stefan Kangas <stefan@marxist.se>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Reto Zimmermann <reto@gnu.org>,
6207@debbugs.gnu.org, John Wiegley <johnw@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#6207: 23.1; align.el vhdl rules setup
Date: Sat, 28 Sep 2019 13:07:03 +0200 [thread overview]
Message-ID: <CADwFkm=4eYWOygTCOQA-wJqb4ifSCmDNZm0NPrU0oKd9U1WQwQ@mail.gmail.com> (raw)
In-Reply-To: <87sgojrnv6.fsf@tcd.ie>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
Basil L. Contovounesios <contovob@tcd.ie> writes:
> > Ugh. Thanks for spotting these issues. I'm a bit sick and tired
> > today, so maybe I should just stay away from coding for the day...
>
> Hope you feel better soon!
Thanks - I feel much better today. :-)
> > I've attached an updated patch.
>
> Thanks, just one remaining nit:
>
> > +(make-obsolete-variable 'align-vhdl-rules-list "no longer used" "27.1")
> ^^
> CURRENT-NAME should end with a full stop; see docstring of make-obsolete.
Fixed in the attached patch. If there are no further comments, I
intend to commit this in a couple of days.
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Declare-unused-vhdl-code-in-align.el-obsolete.patch --]
[-- Type: text/x-patch, Size: 2483 bytes --]
From 042b62e6bb208914f14a92a278ce3e2c89e34ea8 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Thu, 26 Sep 2019 12:31:37 +0200
Subject: [PATCH] Declare unused vhdl code in align.el obsolete
* lisp/align.el (align-vhdl-rules-list, align-set-vhdl-rules): Declare
obsolete. (Bug#6207)
(align-dq-string-modes, align-open-comment-modes): Move vhdl-mode to
definition instead of adding it later.
---
lisp/align.el | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/lisp/align.el b/lisp/align.el
index cd72d52df4..d83f8341c9 100644
--- a/lisp/align.el
+++ b/lisp/align.el
@@ -206,7 +206,7 @@ align-text-modes
(defcustom align-dq-string-modes
(append align-lisp-modes align-c++-modes align-perl-modes
- '(python-mode))
+ '(python-mode vhdl-mode))
"A list of modes where double quoted strings should be excluded."
:type '(repeat symbol)
:group 'align)
@@ -219,7 +219,7 @@ align-sq-string-modes
(defcustom align-open-comment-modes
(append align-lisp-modes align-c++-modes align-perl-modes
- '(python-mode makefile-mode))
+ '(python-mode makefile-mode vhdl-mode))
"A list of modes with a single-line comment syntax.
These are comments as in Lisp, which have a beginning, but end with
the line (i.e., `comment-end' is an empty string)."
@@ -805,9 +805,7 @@ align-highlight-overlays
(defvar align-regexp-history nil
"Input history for the full user-entered regex in `align-regexp'")
-;; Sample extension rule set, for vhdl-mode. This should properly be
-;; in vhdl-mode.el itself.
-
+;; Sample extension rule set for vhdl-mode. This is now obsolete.
(defcustom align-vhdl-rules-list
`((vhdl-declaration
(regexp . "\\(signal\\|variable\\|constant\\)\\(\\s-+\\)\\S-")
@@ -842,18 +840,14 @@ align-vhdl-rules-list
"Alignment rules for `vhdl-mode'. See `align-rules-list' for more info."
:type align-rules-list-type
:group 'align)
-
(put 'align-vhdl-rules-list 'risky-local-variable t)
+(make-obsolete-variable 'align-vhdl-rules-list "no longer used." "27.1")
(defun align-set-vhdl-rules ()
"Setup the `align-mode-rules-list' variable for `vhdl-mode'."
+ (declare (obsolete nil "27.1"))
(setq align-mode-rules-list align-vhdl-rules-list))
-(add-hook 'vhdl-mode-hook 'align-set-vhdl-rules)
-
-(add-to-list 'align-dq-string-modes 'vhdl-mode)
-(add-to-list 'align-open-comment-modes 'vhdl-mode)
-
;;; User Functions:
;;;###autoload
--
2.20.1
next prev parent reply other threads:[~2019-09-28 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 0:54 bug#6207: 23.1; align.el vhdl rules setup Kevin Ryde
2010-05-19 3:35 ` Stefan Monnier
2010-05-19 9:54 ` John Wiegley
2010-06-01 13:06 ` Reto Zimmermann
2010-06-08 1:53 ` Kevin Ryde
2010-06-08 13:18 ` Reto Zimmermann
2019-09-26 11:04 ` Stefan Kangas
2019-09-26 12:58 ` Basil L. Contovounesios
2019-09-26 14:15 ` Stefan Kangas
2019-09-26 17:03 ` Basil L. Contovounesios
2019-09-28 11:07 ` Stefan Kangas [this message]
2019-10-04 15:14 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=4eYWOygTCOQA-wJqb4ifSCmDNZm0NPrU0oKd9U1WQwQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=6207@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=johnw@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=reto@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.