all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master a6a5d6a: Move 'revert-buffer' global binding to 'C-x g g'
Date: Tue, 9 Mar 2021 18:53:47 -0800	[thread overview]
Message-ID: <CADwFkm=4TtFHyELJ1D8_iyscbzWVu07VpQjMqvnnOciFEjsLkg@mail.gmail.com> (raw)
In-Reply-To: <20210207123048.3D5A8211A5@vcs0.savannah.gnu.org>

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit a6a5d6a27a86396ab96662fa158cdcc854bd777b
> Author: Sean Whitton <spwhitton@spwhitton.name>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Move 'revert-buffer' global binding to 'C-x g g'
>
>     * lisp/bindings.el: Define ctl-x-g-map and bind 'revert-buffer' to
>     'C-x x g' globally.
>     * doc/emacs/files.texi: Replace 'C-x g' with 'C-x x g'.
>     * etc/NEWS: Document the change (bug#46300).

One drawback of this change is that messages such as the one you get
here are less obvious:

  M-: (ask-user-about-supersession-threat "foo") RET
  C-h

The help text now says:

    Usually, you should type ‘n’ and then ‘C-x x g’,
    to get the latest version of the file, then make the change again.

The "C-x x g" part used to be "M-x revert-buffer" and therefore more
self-explanatory.  (This is due to subsitute-command-keys replacing the
"\\[revert-buffer]" with the new keybinding.)

So perhaps this change should be accompanied with grepping our sources
for "\\[revert-buffer]" and looking over the relevant substitutions to
make sure the help is sufficiently clear?  I see 16 such matches.



       reply	other threads:[~2021-03-10  2:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210207123046.20692.80429@vcs0.savannah.gnu.org>
     [not found] ` <20210207123048.3D5A8211A5@vcs0.savannah.gnu.org>
2021-03-10  2:53   ` Stefan Kangas [this message]
2021-03-10  3:04     ` master a6a5d6a: Move 'revert-buffer' global binding to 'C-x g g' Stefan Monnier
2021-03-10  4:56       ` Stefan Kangas
2021-03-10 17:23         ` Juri Linkov
2021-03-10 18:33           ` Stefan Kangas
2021-03-10 19:13             ` Juri Linkov
2021-03-11 16:19         ` Stefan Kangas
2021-03-11 16:56     ` Dmitry Gutov
2021-03-11 17:22       ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=4TtFHyELJ1D8_iyscbzWVu07VpQjMqvnnOciFEjsLkg@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=spwhitton@spwhitton.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.