From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Date: Sat, 27 Jan 2024 19:00:34 -0800 Message-ID: References: <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org> <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> <868r4b9qjs.fsf@gnu.org> <875xzfkxq7.fsf@yahoo.com> <87fryijl60.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16621"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, dev@rjt.dev To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 28 04:01:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTvQI-0004CD-On for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Jan 2024 04:01:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTvPU-0007gv-Uw; Sat, 27 Jan 2024 22:00:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTvPS-0007gh-OF for emacs-devel@gnu.org; Sat, 27 Jan 2024 22:00:38 -0500 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTvPQ-00045J-VK; Sat, 27 Jan 2024 22:00:38 -0500 Original-Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-55a9008c185so2845653a12.1; Sat, 27 Jan 2024 19:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706410835; x=1707015635; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=F6XDYO34MMkhUikp3lAhuh8jnjOrh8TwW86tJPjFHnA=; b=acRE/JoDLqLVrkpvswcYkHW16qMlbtoSMZ8vuQmQwvfAzEzWGNjTatnQnRgTzETriZ afuofAIE4uYZl0agVFUR9wM0qQDOPgmoqQNUW/vZamj86MOT4z1+1fUxr7fLiw2Nw9e4 /vE4NjQpvPLNV6MKsUNMY9z3OFDI6aUBKK61pHY0T54W5+Yjw5611+uQyH3c4WQq3IWG Qf6pLbjhAceY7+QEEqPfIth6H/OE/qROAVBqC/RzRaPgAAw1Cvdm1EVhNSE5EMGoAq5p ZuGNWnsUdrV1GZeluFnReyoWzSF9goroYHwok1oXh9/e6NJFML7qNmVxccelbaKF21oq 9XLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706410835; x=1707015635; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F6XDYO34MMkhUikp3lAhuh8jnjOrh8TwW86tJPjFHnA=; b=CtI/YJK4MkzcSic01xA86jCUJ4pUF6o42EMbpQHpm2Ks2pwY7g6P4cvigRGMoRT8Wa WWHVp9KV9YCY+1nK0YhWrbUZufIoncRN/Q4CfHdBeRHocuZBRRuWmvIZ4XRlYOjunFcr Zovg08K8OE5+X6uNt5nZ4148lKz/seGuto2UdG2jqDSDpiYwOScO52eNimfkQO8Re8zx X04gB4NTuHOHgOtuvmc5FggvE31dJ7sFoGLghOEOSGp9eyWpmPwjd6eFH5OPj4B+WD9H 5dvyA87nmC2hiR1D/7tA916zmlw51Gf0V+kQtq0D80pC3BXn1keCYANrOTqRy5qw5CHN aQnw== X-Gm-Message-State: AOJu0Yzv49VCnatX2MmExC1BedA2m1l8ossIhfvUA2jw8uy72i1apxKy 6twpnNxM/stnQG3Hb+ikN4SiW45PNyIh6B5498hlq1CwD3F8tYXfVbufD9h8r9bjYzhfu8gcz/Z jQYqkx7dqZr+tUI41Y+dVgAUXaE0= X-Google-Smtp-Source: AGHT+IGtbAWl1PgPRjQX1pptcDoeER1s8yNL9gsBXhXuHJ34NFfQ5fD3T9xizazy/+cUlcpfDoZMloT0F495z5kUoM0= X-Received: by 2002:aa7:df8b:0:b0:55e:c784:2a6c with SMTP id b11-20020aa7df8b000000b0055ec7842a6cmr1532709edy.0.1706410834691; Sat, 27 Jan 2024 19:00:34 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 27 Jan 2024 19:00:34 -0800 In-Reply-To: <87fryijl60.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315514 Archived-At: Po Lu writes: > The burden of proof is on the author of the patch, who might be the most > qualified person to comment on tree-sitter, but certainly not imenu, > autoloads, or other areas of Emacs no less affected by this change. ? They are not affected by this change though? Are we looking at the same patch (commit 1ef8b90a)? Which areas of Emacs do you think are affected? AFAICT, nothing risks breaking outside of the changed modes. For example, autoloading is not affected (`declare-function' only affects byte-compilation). >> If there are any specific technical arguments for why this particular >> change must not be installed on emacs-29, then let's hear them. Neither >> generalizations nor administrative arguments will cut it, I think. > > I haven't heard any specific technical arguments as to why this change > is safe. Did you read Bug#68706? Yuan decided to install it as a bugfix on emacs-29. The question is if this change is different from the many other bug fixes that we routinely install without much justification. This is why I'm asking for something more specific. > Rather, I'm the person who is frequently told that such specific > statements regarding the safety of a large change are "famous last > words"--which they are, all too often, so I have taken that advice to > heart. I don't know which changes this is in reference to, but I know that you often work on things like X support, that carries with it a bigger risk for breakage (as it's more complex), and it affects more users to boot. It is natural to be more careful with changes in core functionality than in specific modes. Note also that we have been decided to be more lax when it comes to the treesitter stuff, seeing as its new in Emacs 29. >> The above does not necessarily reflect the official line of the project. > > ??? I was summarizing what I myself have been told and observed over a > certain length of time. Maybe I wasn't clear enough. I didn't entirely agree with the summary, because it was too rigid to adequately summarize what I understand to have been our policy so far. What's more, the way it was formulated, I felt like it was open to the misinterpretation that it reflected some official decision. I hope it is more clear now what it is that I wanted to clarify.