From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#27748: 26.0.50; doc strings should be in DOC file Date: Sat, 25 Sep 2021 08:41:17 -0700 Message-ID: References: <11A6DB23-F538-4A59-AC90-7CF5040FA496@raeburn.org> <87a83d5zgz.fsf@users.sourceforge.net> <87h8xi50r0.fsf@users.sourceforge.net> <874ltb1gzj.fsf@users.sourceforge.net> <87r27isi57.fsf@gmail.com> <87pmxyrdsz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30974"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ken Raeburn , Noam Postavsky , Stefan Monnier , 27748@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 17:52:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mU9yT-0007ob-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 17:52:25 +0200 Original-Received: from localhost ([::1]:43396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU9yR-0001mX-H3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 11:52:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU9oQ-0006gi-6m for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 11:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51090) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mU9oP-0003zB-Uv for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 11:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mU9oP-0006JH-NZ for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 11:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 15:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27748 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27748-submit@debbugs.gnu.org id=B27748.163258448524197 (code B ref 27748); Sat, 25 Sep 2021 15:42:01 +0000 Original-Received: (at 27748) by debbugs.gnu.org; 25 Sep 2021 15:41:25 +0000 Original-Received: from localhost ([127.0.0.1]:34403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU9np-0006ID-It for submit@debbugs.gnu.org; Sat, 25 Sep 2021 11:41:25 -0400 Original-Received: from mail-pl1-f172.google.com ([209.85.214.172]:41493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU9nn-0006Hw-LH for 27748@debbugs.gnu.org; Sat, 25 Sep 2021 11:41:24 -0400 Original-Received: by mail-pl1-f172.google.com with SMTP id x8so5783969plv.8 for <27748@debbugs.gnu.org>; Sat, 25 Sep 2021 08:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=Q5wTMEQ7fMWvk8AGtKpfsS+CSxrwkFM1tSgc2n/U9nE=; b=Ynp1DL9H/oUoPXz25g8WToM6yR0hDCaqlL808j7b1ipT483KtjHJADlabsu3ZC2YLp k/AJWsdOtOOc4AZcGFgqN/bhU9zdEGALdzKjRUioL84Ezn5mt7I8bpL0/P1TgbuMuwkK OHdbzC/DYNtoXI8X6Vgk90rjAcSCSrkGpl0v2yv5Z0Mu1TYITOjQTjAyWpjNBD34Iu9u 1wbNMYzP8O1VqwILBgJGX4SkAMiARd/ZAhfl4jkedoEvtNuSFmlj9clBeSWBRCvu3LJQ YwwRCq/GLeTMG2imK0jPJstgYA4vfOuxaIpKhCWyNJkiJB4vXHi3WFHwrR7FbsprDGfz brnw== X-Gm-Message-State: AOAM533TPKW6d67omqdSA3dz9w0Lib5dfbn2MJdWfoHcK9GLu6ID02+Z H6qQIvT0S4oxUMdlLO5UNjXLGG9509q8yrZlW9g= X-Google-Smtp-Source: ABdhPJxvWCOaoprKtZ+8IJrxT9p5f8neR12AFhXAAlbBtT+euMRWHewYKd/r3Fthuu52jB7MYqjbTIWit+0PrHf3QNo= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr14380624pls.71.1632584478128; Sat, 25 Sep 2021 08:41:18 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 25 Sep 2021 08:41:17 -0700 In-Reply-To: <87pmxyrdsz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 10 May 2021 14:09:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215461 Archived-At: Lars Ingebrigtsen writes: > Noam Postavsky writes: > >>> These strings still aren't in the DOC file, but I'm not sure whether >>> that's a problem or not -- what are the practical effects of the doc >>> string of `delete-auto-save-files' not being in that file? >> >> It's mostly just an optimization thing, so not hugely important (at the >> time, Ken was working on a pure Lisp dumping strategy, so shrinking the >> preloaded code was important for that, but we've gone with the pdumper >> instead). However, I seem to recall that applying something like this >> will make it possible to solve Bug#4845, because the docstring loading >> mechanism will no longer be reliant on finding "(defun foo" in the .elc >> file. So that might be nifty. > > Stefan M recently suggested getting rid of the DOC file entirely, so I > wonder whether he has any comments here. (Added to the CCs.) FWIW, I think we should get rid of it. Stefan M did an analysis of this and the amount of saved memory was very small, from bytecomp.el: ;; For the compilation itself, we could largely get rid of this hunk-handler, ;; if it weren't for the fact that we need to figure out when a defalias ;; defines a macro, so as to add it to byte-compile-macro-environment. ;; ;; FIXME: we also use this hunk-handler to implement the function's dynamic ;; docstring feature. We could actually implement it more elegantly in ;; byte-compile-lambda so it applies to all lambdas, but the problem is that ;; the resulting .elc format will not be recognized by make-docfile, so ;; either we stop using DOC for the docstrings of preloaded elc files (at the ;; cost of around 24KB on 32bit hosts, double on 64bit hosts) or we need to ;; build DOC in a more clever way (e.g. handle anonymous elements).