From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58800: Mark previous-buffer and next-buffer commands as repeatable Date: Wed, 26 Oct 2022 12:52:37 -0700 Message-ID: References: <87v8o6zkes.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17313"; mail-complaints-to="usenet@ciao.gmane.io" To: Damien Cassou , 58800@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 26 21:59:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onmZ2-0004GZ-KH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Oct 2022 21:59:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onmSV-0005Vz-H2; Wed, 26 Oct 2022 15:53:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onmSU-0005Vq-G5 for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 15:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onmSU-0007uX-8M for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 15:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1onmSU-0006jn-3b for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 15:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Oct 2022 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58800-submit@debbugs.gnu.org id=B58800.166681396525868 (code B ref 58800); Wed, 26 Oct 2022 19:53:02 +0000 Original-Received: (at 58800) by debbugs.gnu.org; 26 Oct 2022 19:52:45 +0000 Original-Received: from localhost ([127.0.0.1]:55329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onmSD-0006j9-AK for submit@debbugs.gnu.org; Wed, 26 Oct 2022 15:52:45 -0400 Original-Received: from mail-oi1-f182.google.com ([209.85.167.182]:41600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onmSB-0006in-1o for 58800@debbugs.gnu.org; Wed, 26 Oct 2022 15:52:44 -0400 Original-Received: by mail-oi1-f182.google.com with SMTP id r187so3155138oia.8 for <58800@debbugs.gnu.org>; Wed, 26 Oct 2022 12:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=d480rrtHwkKGa1hnrQMqzHkyfvYcgmKcIJbZWYVfNGE=; b=JC/Oaa/ZWoowRFJTeZ3TIkpEgmlqPOBAc526MqrWfFaQtiDXkoOM9VnY0nAk38jgNM S8VnY2SoyG/6j7DOgc/ZViMFrKwl/fCNnEilP5PUdKbPdgM0inHyLVnvXY1vrlDoFuLp E3JLxD+NmCOAj3gzKDhpPkdqE/+Xv1VX+FWrbCURN3ljDnkBOWc0atrzEEtUgZ95ww0t WIT8vkVEHqxgp7f3wIAvVuvK+jWMTQ6s+6FdRLZAzli8OfZE/lluxbYP5U9vbQJJLL/l Bc6K3XdzhyWNy+mkALFxbUO++u2cP5dItYaMjYAyTQuV5y6pAEkgjS3huaoVxID3gB7T 9WQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d480rrtHwkKGa1hnrQMqzHkyfvYcgmKcIJbZWYVfNGE=; b=KeNC6D1f3uL/I4zw/4lgZ8EqLkxSbHNKpjTf9hHR/pch11kSZ2JtNdMUD40TiUD3U6 JEwSl8voR1ikR4VO7o0T91Xgh3ZBB2QuPEpJCgwoWOWRXxdv66L0NIdlv+aQ0GeiSSsS DHSQPRzZxtpIILeGfoQihGQcqF9e9L07Bhq7QAAK/QtzqbbmNrvhkfpLNRal5VgT7TzT YNnA9GuAmsCbWUPQmwxQKUMRQSSMzeL2fZlrKbl9nQQxn0S/UsjCVoHzuf7Y1UAidot8 Y/6YsOTURlZwLF1j4GeSoPOSzH+5Ek4GGElToPRTtSAzbKRXfAgEiZ6iSm3eMSU5u/j1 1Gmw== X-Gm-Message-State: ACrzQf0Mwhyc1KHugHVoTYS+98ZR3iZzUcEJ3piyjYSwih38FD0QJe/U Vols7oVr+BhRUjS5j+9/20//rtehkFdJ4wH54sE= X-Google-Smtp-Source: AMsMyM4wqv0rxGuJ2u+dXxgd9lXmK0anWD0TCTFSNPqsvKMQk1jrpvq7/PULMvAts75Ud4a96jHbUjlgwhGYXXlKVsA= X-Received: by 2002:a05:6808:14c3:b0:359:ac8d:41e2 with SMTP id f3-20020a05680814c300b00359ac8d41e2mr2340003oiw.92.1666813957508; Wed, 26 Oct 2022 12:52:37 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 Oct 2022 12:52:37 -0700 In-Reply-To: <87v8o6zkes.fsf@cassou.me> X-Hashcash: 1:20:221026:58800@debbugs.gnu.org::ODnTA8aERz34yGQP:0Y7H X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246256 Archived-At: Damien Cassou writes: > From 4bafbad18a0a027207399cf4ba71b7775eb873cb Mon Sep 17 00:00:00 2001 > From: Damien Cassou > Date: Wed, 26 Oct 2022 17:12:14 +0200 > Subject: [PATCH] Mark `previous-buffer' and `next-buffer' commands as > repeatable > > * lisp/bindings.el (buffer-navigation-repeat-map): Add new map. > * lisp/bindings.el (previous-buffer): > (next-buffer): Mark as repeatable. > > Copyright-paperwork-exempt: yes Do we really need to add "Copyright-paperwork-exempt"? You already have changes in emacs.git that takes you way above the 15 or so lines that we could make an exception for, so I guess you have in fact signed the papers? AFAIU, the line shouldn't be used in that case. > --- > lisp/bindings.el | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lisp/bindings.el b/lisp/bindings.el > index 2e32128274..9005b20a71 100644 > --- a/lisp/bindings.el > +++ b/lisp/bindings.el > @@ -1029,6 +1029,14 @@ ctl-x-map > (define-key global-map [XF86Back] 'previous-buffer) > (put 'previous-buffer :advertised-binding [?\C-x left]) > > +(defvar-keymap buffer-navigation-repeat-map > + :doc "Keymap to repeat `next-buffer' and `previous-buffer'. Used in `repeat-mode'." > + [right] #'next-buffer > + [left] #'previous-buffer) It should be "" and "" here, I think. > + > +(put 'next-buffer 'repeat-map 'buffer-navigation-repeat-map) > +(put 'previous-buffer 'repeat-map 'buffer-navigation-repeat-map) > + > (let ((map minibuffer-local-map)) > (define-key map "\en" 'next-history-element) > (define-key map [next] 'next-history-element) > -- > 2.36.2