From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: CL packages landed Date: Thu, 20 Oct 2022 23:42:27 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e0adb805eb85be5b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23882"; mail-complaints-to="usenet@ciao.gmane.io" To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 21 08:46:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ollnp-00061y-Iz for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Oct 2022 08:46:45 +0200 Original-Received: from localhost ([::1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ollnm-0001wJ-Iq for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Oct 2022 02:46:42 -0400 Original-Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olljq-0006oe-TC for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Oct 2022 02:42:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olljk-0006Rc-LL for emacs-devel@gnu.org; Fri, 21 Oct 2022 02:42:33 -0400 Original-Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ollji-0004h2-Mf for emacs-devel@gnu.org; Fri, 21 Oct 2022 02:42:32 -0400 Original-Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1364357a691so2430171fac.7 for ; Thu, 20 Oct 2022 23:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=p11xI+pNvD1jnHBTVsD8xagqq0YcVD06oGv3jM9esOw=; b=lZM4+9Bv6acqwsDZVrXVtEWxw2Lvq5Jnj5Qai6++huzGXDmOHt/97C6Hp19ocQoUc8 EezjkIYPVH4yT7W9lujk3QbME2eyLOMnX5IemH6lbAIUmEymY8BnmymCMCcsnXSJQ/55 SHY0/8lnzyOXPjSw7i+NaxUwBDFfDeOf4gDiDqd4u5AduGQWOkPB4zzfiglCl/W9oNma 17QkKLi1zeDEYRMCNEtM5tHqoSWetU0iVqlKMcA6L/V0CEZm/TThg9guvvp91hFXG6MP WWu+w8QmwhnSW045gVHkYIL2N6kPeDZVx23RnayxZFGp+jNQFkcYGGtoYSMZFfSD1ob2 Vqvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p11xI+pNvD1jnHBTVsD8xagqq0YcVD06oGv3jM9esOw=; b=Y9T384ypvYkUsJ2exneX1DuSCBpkhZOFNFRAzEnuAxv9FKWGw15G5iEn9JbowG+erC 6eBCRW43BJIfm8cywurq+m32qwRy6qnOluyxCqipNz4lDcwJkvPxal5vfBnN1lLqprCE ZARnisz1xNO8VU2XZiC4nySb77DeXB0F0GlfwK8Q4O3GDEGQsYYFLzxtUQcpEodQDB5r Aaoh7TZrrKiXjuGPJadRmMzZbd11PKCx8KP71EU3w5JZ5hkk+4tVMAIfb2bMwYr/7X2j 1OAvFj6LRrXps/WVVHpZOTcM+ptjoX/gyFhxezbfGhGpGUP0JooKtQIXiozGgEwJbGDc nGDA== X-Gm-Message-State: ACrzQf3/kzud80yb8z+hfeMp6WW3ty8BXZYSvx/4ocYYljwos5skINR2 UaCVRK7ZonYUnaMPEKNOIZ5NpfofCp8Ykoqt8Ro= X-Google-Smtp-Source: AMsMyM6vEFKhuX6IUnXyAJAxqED5/2v4R28m2x2eDUxvtVD1aZcZfNAgK0ERU3od8v1+5LYMUPwxVRxb0vd/hNq2M5c= X-Received: by 2002:a05:6870:d79a:b0:136:50d7:faa9 with SMTP id bd26-20020a056870d79a00b0013650d7faa9mr27089724oab.92.1666334549120; Thu, 20 Oct 2022 23:42:29 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 20 Oct 2022 23:42:27 -0700 In-Reply-To: X-Hashcash: 1:20:221021:emacs-devel@gnu.org::XFQcAiYTvr2jHDtZ:0wny Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298199 Archived-At: --000000000000e0adb805eb85be5b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Gerd M=C3=B6llmann writes: > I've pushed the branch "pkg" which implements CL packages for Emacs. I saw these GCC warnings while compiling: pkg.c:43:3: warning: function =E2=80=98pkg_error=E2=80=99 might be a candid= ate for =E2=80=98gnu_printf=E2=80=99 format attribute [-Wsuggest-attribute=3Dformat= ] 43 | verror (fmt, ap); | ^~~~~~ pkg.c:39:1: warning: function might be candidate for attribute =E2=80=98noreturn=E2=80=99 [-Wsuggest-attribute=3Dnoreturn] 39 | pkg_error (const char *fmt, ...) | ^~~~~~~~~ See the attached attempt to fix them. While playing around with this, I also came up with the attached small additions to the test suite (loosely based on the HyperSpec). BTW, I think according to our branch naming conventions this should be named "feature/pkg"? --000000000000e0adb805eb85be5b Content-Type: text/x-diff; charset="US-ASCII"; name="0001-src-lisp.h-pkg_error-Fix-GCC-warning-in-declaration.patch" Content-Disposition: attachment; filename="0001-src-lisp.h-pkg_error-Fix-GCC-warning-in-declaration.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 7ed06e9558c000e9_0.1 RnJvbSA2OTg3YzViYmI3OTRhMDAxZjZlNTY1NGJkOWVhOWMwZTA5N2JhYzA5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDIxIE9jdCAyMDIyIDA4OjEyOjU5ICswMjAwClN1YmplY3Q6IFtQQVRDSCAx LzJdICogc3JjL2xpc3AuaCAocGtnX2Vycm9yKTogRml4IEdDQyB3YXJuaW5nIGluIGRlY2xhcmF0 aW9uLgoKLS0tCiBzcmMvbGlzcC5oIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2xpc3AuaCBiL3NyYy9saXNwLmgK aW5kZXggMjA0MmRiYmQyZi4uZjYwNTgzYTE1MCAxMDA2NDQKLS0tIGEvc3JjL2xpc3AuaAorKysg Yi9zcmMvbGlzcC5oCkBAIC0yMjcyLDcgKzIyNzIsNyBAQCBQQUNLQUdFX05BTUVYIChMaXNwX09i amVjdCBwYWNrYWdlKQogZXh0ZXJuIHZvaWQgaW5pdF9wa2cgKHZvaWQpOwogZXh0ZXJuIHZvaWQg c3ltc19vZl9wa2cgKHZvaWQpOwogZXh0ZXJuIExpc3BfT2JqZWN0IHBrZ19xdWFsaWZpZWRfc3lt Ym9sIChMaXNwX09iamVjdCBuYW1lLCBMaXNwX09iamVjdCBwYWNrYWdlLCBib29sIGV4dGVybmFs KTsKLWV4dGVybiB2b2lkIHBrZ19lcnJvciAoY29uc3QgY2hhciAqZm10LCAuLi4pOworZXh0ZXJu IF9Ob3JldHVybiB2b2lkIHBrZ19lcnJvciAoY29uc3QgY2hhciAqZm10LCAuLi4pIEFUVFJJQlVU RV9GT1JNQVRfUFJJTlRGICgxLCAwKTsKIGV4dGVybiBMaXNwX09iamVjdCBwa2dfdW5xdWFsaWZp ZWRfc3ltYm9sIChMaXNwX09iamVjdCBuYW1lKTsKIGV4dGVybiBib29sIHBrZ19rZXl3b3JkcCAo TGlzcF9PYmplY3Qgb2JqKTsKIGV4dGVybiBMaXNwX09iamVjdCBwa2dfZGVmaW5lX3N5bWJvbCAo TGlzcF9PYmplY3Qgc3ltLCBMaXNwX09iamVjdCBwYWNrYWdlKTsKLS0gCjIuMzUuMQoK --000000000000e0adb805eb85be5b Content-Type: text/x-diff; charset="US-ASCII"; name="0002-Fix-cl-intern-cl-unintern-tests.patch" Content-Disposition: attachment; filename="0002-Fix-cl-intern-cl-unintern-tests.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 7ed06e9558c000e9_0.2 RnJvbSBkZDAyZGI1NzAyZTQ2YWY2NTQzYmUxNGNiMDVkOTgxZmEyNjFhZDFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDIxIE9jdCAyMDIyIDA4OjEzOjI1ICswMjAwClN1YmplY3Q6IFtQQVRDSCAy LzJdIEZpeCBjbC1pbnRlcm4vY2wtdW5pbnRlcm4gdGVzdHMKCiogdGVzdC9zcmMvcGtnLXRlc3Rz LmVsIChwa2ctdGVzdHMtY2wtaW50ZXJuKQoocGtnLXRlc3RzLWNsLXVuaW50ZXJuKTogRml4IHRl c3RzLgotLS0KIHRlc3Qvc3JjL3BrZy10ZXN0cy5lbCB8IDE1ICsrKysrKysrKysrKystLQogMSBm aWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvdGVzdC9zcmMvcGtnLXRlc3RzLmVsIGIvdGVzdC9zcmMvcGtnLXRlc3RzLmVsCmluZGV4IDFj ZmVhNmE2MzIuLmFmZjZmZjBlYjUgMTAwNjQ0Ci0tLSBhL3Rlc3Qvc3JjL3BrZy10ZXN0cy5lbAor KysgYi90ZXN0L3NyYy9wa2ctdGVzdHMuZWwKQEAgLTEyNiwxMCArMTI2LDIxIEBAIHBrZy10ZXN0 cy1maW5kLXN5bWJvbAogICAoc2hvdWxkIG5pbCkpCiAKIChlcnQtZGVmdGVzdCBwa2ctdGVzdHMt Y2wtaW50ZXJuICgpCi0gIChzaG91bGQgbmlsKSkKKyAgKGNsLWFzc2VydCAobm90IChmaW5kLXN5 bWJvbCAiZm9vIikpKQorICAodW53aW5kLXByb3RlY3QKKyAgICAgIChwcm9nbgorICAgICAgICAo Y2wtaW50ZXJuICJmb28iKQorICAgICAgICAoc2hvdWxkIChmaW5kLXN5bWJvbCAiZm9vIikpKQor ICAgIChjbC11bmludGVybiAnZm9vKSkpCiAKIChlcnQtZGVmdGVzdCBwa2ctdGVzdHMtY2wtdW5p bnRlcm4gKCkKLSAgKHNob3VsZCBuaWwpKQorICAoY2wtYXNzZXJ0IChub3QgKGZpbmQtc3ltYm9s ICJmb28iKSkpCisgICh1bndpbmQtcHJvdGVjdAorICAgICAgKHByb2duCisgICAgICAgIChjbC1p bnRlcm4gImZvbyIpCisgICAgICAgIChjbC11bmludGVybiAnZm9vKQorICAgICAgICAoc2hvdWxk LW5vdCAoZmluZC1zeW1ib2wgImZvbyIpKSkKKyAgICAoY2wtdW5pbnRlcm4gJ2ZvbykpKQogCiAo ZXJ0LWRlZnRlc3QgcGtnLXRlc3RzLWV4cG9ydCAoKQogICAoc2hvdWxkIG5pbCkpCi0tIAoyLjM1 LjEKCg== --000000000000e0adb805eb85be5b--