From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#43792: [PATCH] Add ert macros to get resource file names Date: Fri, 16 Oct 2020 02:47:45 -0700 Message-ID: References: <877ds5qgec.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18576"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43792@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 16 11:48:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTMLM-0004ki-HK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Oct 2020 11:48:12 +0200 Original-Received: from localhost ([::1]:35904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTMLL-0001u1-BO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Oct 2020 05:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTMLC-0001rt-EF for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2020 05:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTMLC-00088H-4d for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2020 05:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kTMLC-0005W5-3D for bug-gnu-emacs@gnu.org; Fri, 16 Oct 2020 05:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Oct 2020 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43792-submit@debbugs.gnu.org id=B43792.160284167821189 (code B ref 43792); Fri, 16 Oct 2020 09:48:02 +0000 Original-Received: (at 43792) by debbugs.gnu.org; 16 Oct 2020 09:47:58 +0000 Original-Received: from localhost ([127.0.0.1]:57709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTML8-0005Vg-8K for submit@debbugs.gnu.org; Fri, 16 Oct 2020 05:47:58 -0400 Original-Received: from mail-ed1-f52.google.com ([209.85.208.52]:34817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kTML2-0005VA-Np for 43792@debbugs.gnu.org; Fri, 16 Oct 2020 05:47:53 -0400 Original-Received: by mail-ed1-f52.google.com with SMTP id cq12so1653124edb.2 for <43792@debbugs.gnu.org>; Fri, 16 Oct 2020 02:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=bi6gG9lgRC1mwbKIGNZllV7rzGCZXYvcQlmvpdrVsP0=; b=Uh/mAB0W7Okr/H7Fn13HvppEzpAJvvBarlagKJfeXXkuV6Rj3S6tIFAaKaj0YOSlbY 4ELL96gUiNunEOm7S/X+Vtouu8QT1mgvpKC7R3l2a+zGcEeac2ofIGRvD8VyujH7zIq9 dbOk5LGHpEGbrmOq73qLRIEYayQcvN8baSq2ZEv5o7DqX2HFGV0YlUSeQX03SdzRw603 VoZYi98fzRP0JfOYZ/GGurGcfWdFYRjfwIeka2V7r5ISv48wWb21jAQ+s/I6d06bXdwE uSTR7VJUYYf6HSxhXHRiDUwYbnBmzoD4wEQ10r0dHUO5y4ZBqf6TjOQ833AK6VD9zTmt uiLA== X-Gm-Message-State: AOAM532vESbCcoNdOtay7QW3IwqGJvpNizWRU85VPqj6jgyRKCK7ouqj BYm5tkC9R+sTwJ4izlIfNzibvKW81+h2R2H4Bt8= X-Google-Smtp-Source: ABdhPJx/dVBZ89y6raV5PEwsa0TV2ldsExydOZxgVbc7+4V2HuCiokqQOzZee8ved38zJhvVJUeuq7vAwLZ59X1NLYc= X-Received: by 2002:aa7:d783:: with SMTP id s3mr2919055edq.214.1602841666907; Fri, 16 Oct 2020 02:47:46 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 16 Oct 2020 02:47:45 -0700 In-Reply-To: <877ds5qgec.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190678 Archived-At: close 43792 28.1 thanks Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> There's a lot of repetitive code to get at the resource directories for >> tests. That's obviously boring, so I'd propose something like the >> following two macros to make it easier: >> >> (ert-resource-directory) >> (ert-resource-file NAME) >> >> Please see the attached patch, the second of which uses the macros in >> our test suite. Not sure if they should be in ert.el, so I put them in >> ert-x.el for now to play it safe. > > Looks good to me. Thanks for reviewing; pushed to master as commit f52a775ae2 and 1f44a77672.