From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37943: assoc-default is wrongly flagged as side-effect-free. Date: Tue, 25 Aug 2020 16:32:45 -0700 Message-ID: References: <20191027122455.GB27491@ACM> <87zhhk99lb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39870"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Alan Mackenzie , 37943@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 26 01:33:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAiRB-000AGT-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 01:33:09 +0200 Original-Received: from localhost ([::1]:46964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAiR9-0003Bp-RA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Aug 2020 19:33:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAiR4-0003Bd-14 for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 19:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53219) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAiR3-0004Dy-Oa for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 19:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAiR3-0001f6-MT for bug-gnu-emacs@gnu.org; Tue, 25 Aug 2020 19:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Aug 2020 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37943 X-GNU-PR-Package: emacs Original-Received: via spool by 37943-submit@debbugs.gnu.org id=B37943.15983983736169 (code B ref 37943); Tue, 25 Aug 2020 23:33:01 +0000 Original-Received: (at 37943) by debbugs.gnu.org; 25 Aug 2020 23:32:53 +0000 Original-Received: from localhost ([127.0.0.1]:36526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAiQv-0001bM-BS for submit@debbugs.gnu.org; Tue, 25 Aug 2020 19:32:53 -0400 Original-Received: from mail-yb1-f171.google.com ([209.85.219.171]:45602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAiQt-0001Xz-Nk for 37943@debbugs.gnu.org; Tue, 25 Aug 2020 19:32:52 -0400 Original-Received: by mail-yb1-f171.google.com with SMTP id x2so182890ybf.12 for <37943@debbugs.gnu.org>; Tue, 25 Aug 2020 16:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=tQpNWnlpnORiWHzCCNnQ2Esp+exY5ok3lEJ6YqHu97o=; b=DXW2xS1g/x7bkwtWNIqJ9eV5Q9dqul7GRGJTLlaTUwnlrPEVg2zAeBUSfAkEqevYW0 cQcZxDiGOyKrdKmzig4tGQ5/V19LB0bS+kFjKJ5RX4Sg/WIGS0Lbby9l5ZlNRXCZL1nb yRZga41OUMv8E/wXV4yHEiZfd6IMbizteulLYMAX4VxawWfID3TR4QphS275Y3UrBFsh P4IeNMi3w6z4zrEyqr+bpTqIePmhedGW9+HMuTMCgITMvsfQEeLYmYK2fVp+GIggbAm/ SRDZzcdKMqnSE+ko+v/feN4FLdxoBdt+jf0lWpmJMPCNgbTh1WzwqhpP0KfYUKNFe/rW nDZA== X-Gm-Message-State: AOAM532h2wx3ZR4Xx/UazoP71zPOZd5rRFpryVryjYNLmqhHLefBO6a2 V3c13aCy5rIlrT49zEoIr0wmSkOcTkMOgfzhWlw= X-Google-Smtp-Source: ABdhPJx8C+7cvj4/gMBbYtI02MMHesdqbPB1lM0qLTkDjVv5pc2BYdGZWJAWwWx7rFd5oh9UB+LabO6agsTy1gHMaF8= X-Received: by 2002:a25:b290:: with SMTP id k16mr17455881ybj.389.1598398366175; Tue, 25 Aug 2020 16:32:46 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 Aug 2020 16:32:45 -0700 In-Reply-To: <87zhhk99lb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Oct 2019 16:24:32 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186373 Archived-At: Lars Ingebrigtsen writes: > Alan Mackenzie writes: > >> In the source for assoc-default (in subr.el) appears >> >> (declare (side-effect-free t)) >> >> . This is not true when the TEST argument to assoc-default itself >> changes the match-data. >> >> I suggest removing this declaration from the function rather than >> amending the code with a save-match-data. There are calls to >> assoc-default in set-auto-mode where the caller relies on the match data >> set by the function when TEST is string-match. :-( > > Yeah, I don't think any function that takes a closure as an argument > should be marked side-effect free? The TEST function can side-effect as > much as it wants. No further replies within 43 weeks. Should we just go ahead and remove it then? No one seems to be objecting.