From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Elias_M=C3=A5rtenson?= Newsgroups: gmane.emacs.devel Subject: Re: libpng issues Date: Mon, 12 Feb 2018 12:32:48 +0800 Message-ID: References: <20180210.204659.327614606750579213.wl@gnu.org> <43b7cd24-568b-a912-7e6b-be910b2bb99c@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113dbc1cd760540564fc5ea5" X-Trace: blaine.gmane.org 1518409890 10309 195.159.176.226 (12 Feb 2018 04:31:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Feb 2018 04:31:30 +0000 (UTC) Cc: emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 12 05:31:26 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1el5la-0000cT-2M for ged-emacs-devel@m.gmane.org; Mon, 12 Feb 2018 05:30:58 +0100 Original-Received: from localhost ([::1]:38617 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1el5nZ-0002bM-U8 for ged-emacs-devel@m.gmane.org; Sun, 11 Feb 2018 23:33:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1el5nR-0002aX-EP for emacs-devel@gnu.org; Sun, 11 Feb 2018 23:32:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1el5nQ-00068P-AU for emacs-devel@gnu.org; Sun, 11 Feb 2018 23:32:53 -0500 Original-Received: from mail-it0-x234.google.com ([2607:f8b0:4001:c0b::234]:39134) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1el5nO-000661-Hj; Sun, 11 Feb 2018 23:32:50 -0500 Original-Received: by mail-it0-x234.google.com with SMTP id c80so5049006itb.4; Sun, 11 Feb 2018 20:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GAtqjl3c2MO4Bc8O9ziojNKef1MCP30MKQI/GQlNhdE=; b=SI7jOcN0WHdb/G+Qs0w60+wVtqqZK5UMu54V5G3qiXQaWdwx5hMcvm4FhrC+dHQ2BX HM9BZsxU2x13WT8y4q4rfcWPIahJZn9TDemivDy74zal9PCsjF4pAj6Elu8bqSmSr5cV +3vmHuvaCGFtjJwq6Z51JjlWu7+zUcrjAA2z5VleNm5FRtMmtgXAjqonEz0/Yoagz57C YAuBF4Jsa4w5kXuFHMaOlp0gzb3HoWyakOLO8P1A2hBEdclRUib8/ErIS976wP0R8PXg By+p103Et2e3U5SWsKSqq4XYtwWQxHldparKizn0XrV2T8zwW6sHonIAWbi4D8SVujnz IOtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GAtqjl3c2MO4Bc8O9ziojNKef1MCP30MKQI/GQlNhdE=; b=KVjv0W9TMx0FMOPURUoZtXahGdRP9QnOc3sO2dBUVgF1q1EPi99SOJqHO/e2FKVQNV 34uPGpJFX3H0SvS0aUvTGgC53p0BqYaY5au2N9gAyPnBBaG7v5sCcQ8/LKczWR//OVlT IQrtn/h03cuuzY0D1UWgkIQleMbfIjU/AgCutFNb0CKXtpgbQai3OhGnBFP/bDVHYlg6 sfc/8pRAttAm9pBFNFaZ0CnvausAp2eAsCZUpJQLwR0Ec/NFxRpEGLbW26qCF9VTQ+Vu BIz0mrqPqrezjPTFdh1d+edrp/VF+GnrEpi5fwfJEIPqWc4S5KNYn5/4SWK5qVSNRaZx 0ETQ== X-Gm-Message-State: APf1xPBNt+mH6u+NgGAu0gUFv77z65TBXl7LYdi3OtOpK1JH8p0JoHza USuJATkiVNvojvsoN+bcKODACgekOscLmTYf3Hs= X-Google-Smtp-Source: AH8x224ExHafH2KbxNhqd7wBl9R5tbM3CV8YuyhEMTPS//665tbuOMrnNNHUCZ0w+zROgJ4vPCRnyB6+gcKgfskuT4w= X-Received: by 10.36.2.213 with SMTP id 204mr3735137itu.121.1518409969260; Sun, 11 Feb 2018 20:32:49 -0800 (PST) Original-Received: by 10.107.9.166 with HTTP; Sun, 11 Feb 2018 20:32:48 -0800 (PST) In-Reply-To: <43b7cd24-568b-a912-7e6b-be910b2bb99c@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222677 Archived-At: --001a113dbc1cd760540564fc5ea5 Content-Type: text/plain; charset="UTF-8" Hello Paul, Your fix for this (e9ca57cfcbaf1a8dfc6bde5a2afd5f3c7b357cb1) causes the build to fail on Arch Linux. Rolling back that change makes the build work again. Here's the error: make[2]: Leaving directory '/home/emartenson/src/emacs/admin/charsets' make -C ../admin/unidata charscript.el make[2]: Entering directory '/home/emartenson/src/emacs/admin/unidata' make[2]: Nothing to be done for 'charscript.el'. make[2]: Leaving directory '/home/emartenson/src/emacs/admin/unidata' CCLD temacs /bin/ld: image.o: undefined reference to symbol 'png_longjmp@@PNG16_0' /usr/lib/libpng16.so.16: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status make[1]: *** [Makefile:606: temacs] Error 1 make[1]: Leaving directory '/home/emartenson/src/emacs/src' make: *** [Makefile:418: src] Error 2 Regards, Elias On 12 February 2018 at 10:45, Paul Eggert wrote: > Werner LEMBERG wrote: > >> >> I've just been bitten by >> >> https://github.com/glennrp/libpng/issues/206 >> >> For this reason I suggest two improvements for the configure script of >> emacs. >> >> (1) Use `pkg-config' before `libpng-config' to detect libpng. >> >> (2) If `libpng-config' is used, filter out `-L/usr/lib' and >> `-L/usr/lib64' (as suggested in issue #206). >> > > Thanks, I installed the attached into master. It does (1), and as I > understand it when (1) works then (2) is unnecessary. I'm hoping we don't > have to do (2) as I worry that it might break things on some platforms. > --001a113dbc1cd760540564fc5ea5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Paul,

Your fix for this (e9ca57cf= cbaf1a8dfc6bde5a2afd5f3c7b357cb1) causes the build to fail on Arch Linux.
Rolling back that change makes the build work again.
Here's the error:

make[2]: Le= aving directory '/home/emartenson/src/emacs/admin/charsets'
make -C ../admin/unidata charscript.el
make[2]: Entering direc= tory '/home/emartenson/src/emacs/admin/unidata'
make[2]: = Nothing to be done for 'charscript.el'.
make[2]: Leaving = directory '/home/emartenson/src/emacs/admin/unidata'
=C2= =A0 CCLD=C2=A0 =C2=A0 =C2=A0temacs
/bin/ld: image.o: undefined re= ference to symbol 'png_longjmp@@PNG16_0'
/usr/lib/libpng1= 6.so.16: error adding symbols: DSO missing from command line
coll= ect2: error: ld returned 1 exit status
make[1]: *** [Makefile:606= : temacs] Error 1
make[1]: Leaving directory '/home/emartenso= n/src/emacs/src'
make: *** [Makefile:418: src] Error 2
<= /div>

Regards,
Elias


On 12 February 2= 018 at 10:45, Paul Eggert <eggert@cs.ucla.edu> wrote:
Werner LEMBERG wrote:

I've just been bitten by

=C2=A0 =C2=A0https://github.com/glennrp/libpng/is= sues/206

For this reason I suggest two improvements for the configure script of
emacs.

(1) Use `pkg-config' before `libpng-config' to detect libpng.

(2) If `libpng-config' is used, filter out `-L/usr/lib' and
=C2=A0 =C2=A0 =C2=A0`-L/usr/lib64' (as suggested in issue #206).

 Thanks, I installed the attached into master. It does (1), and as I underst= and it when (1) works then (2) is unnecessary. I'm hoping we don't = have to do (2) as I worry that it might break things on some platforms.

--001a113dbc1cd760540564fc5ea5--