From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pranshu Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q Date: Tue, 31 Dec 2024 14:25:56 +0530 Message-ID: References: <173549521472.300001.3703786856066422485@vcs3.savannah.gnu.org> <20241229180015.5FF2FD973AF@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007ed8e2062a8d19d9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38660"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 13:16:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSbAx-0009wn-PW for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 13:16:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSb9m-0004Pv-Ka; Tue, 31 Dec 2024 07:15:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSY2s-0006Xp-0Y for emacs-devel@gnu.org; Tue, 31 Dec 2024 03:56:10 -0500 Original-Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSY2q-0003tM-Dt for emacs-devel@gnu.org; Tue, 31 Dec 2024 03:56:09 -0500 Original-Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3eb3c143727so5523309b6e.1 for ; Tue, 31 Dec 2024 00:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735635367; x=1736240167; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+/QhQQigAV8za1/du1g6v0ZiVUEh4n0tic2gy8YaD/o=; b=Pc8Ct6bbvaSXR/VleORmUnBTyvVQqqJn/+VZ+QsMRe1mvsjq9ZaWf2J3OidQBTy4dv 7HfkIoNX3QdTTLDFqxuKhjxAaPaCWJ9jsdHBRZ2qsTbFsvMlmMbvEbXDS37jkwl+Dks8 YelVYBDfsNXkLFmioKPuvjT6UOcCeoWoJN2pWwJNAjDsVWjXKv2cmhORMix66NEedvKI eN8ttBy06+Ci29TEi1PbYY5zWglyh/83IKC+PxwzPX+tk+OZDtYPAhU1nQhT3BAJYCuy Tx6f86bAxlR6D5ldVoyr/DCGuVhxQqJzKBBA0g3/AOGE4PkAjHgMLShvMB6rEw/p3jee Kw2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735635367; x=1736240167; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+/QhQQigAV8za1/du1g6v0ZiVUEh4n0tic2gy8YaD/o=; b=hie/0zIToVPVC3oKs+ONtZAKYPgzG3o+H2EqrPRhrK8K0mCibFH7HihYESYWE2N+AJ P9UQWkxLNhQLFb2e9SKpZyy57nYPPLRFh3HRM9skQW1S5cfE3V+VWm0UtDov59zU4FPy LVGozEnEwg8nXvhiTWfV96VBxNy96+HlC3jFglu2nFEWiZwnklWT3pmIXia9kPEFRZ2t 3UStjfsfmQcvoR1/K20lRA8Hv0Eiffy0gkK3SEc9+imj7EfGmLou6kt5TdEManeT8pLJ s+YcpKmJBOQbh86JWrfCbP6Z9YujCsQcP6yJzGEpfoLkSu3BwyHSzfxwvFxf/gO060ht x9jw== X-Gm-Message-State: AOJu0YwYY3c+gjAcLs0u5yBZfKNoH9d8RzncvFCiv0xvL+i9JtK9xpZq WfPbGE0E/dowmy6LxFctlefuGvX0dUfTcRU1IA/u8Ee5f8D+anUqZ2MHyo6Yhjaabd5qO2hfykp LazA7ByUTVcW7s6JmmvGPB1JoPiI= X-Gm-Gg: ASbGnctyWZcxumwr280WYNuWrDkH/Q2loGqf/vRoU8lAeSl0exbbqBSlfM+7x0TcPiX 76lLd89eBGWVbKOmU+MVhzBBvdpl5VHJXhXbbeltiQZ8qKxidY1k4mXPTDs/Eyu/oD724grj7 X-Google-Smtp-Source: AGHT+IGkU0Zj6vLGtK7T3OTbGwJhJePxTMPwiUkzRqMkMQO1laNwzTZz/H2Jy885ds3+I8NpqKSaN5Iy64/pAoXXsqQ= X-Received: by 2002:a05:6808:1250:b0:3eb:643b:defc with SMTP id 5614622812f47-3ecdd647e12mr24657575b6e.7.1735635366760; Tue, 31 Dec 2024 00:56:06 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=pranshusharma366@gmail.com; helo=mail-oi1-x231.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 31 Dec 2024 07:15:14 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327493 Archived-At: --0000000000007ed8e2062a8d19d9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yeah,I realised that soon after, it should be fixed now On Mon, 30 Dec 2024, 1:15=E2=80=AFam Stefan Monnier, wrote: > > branch: elpa/haskell-ts-mode > > commit df8d3690375a14ede7079640bc326111f1fb3ddd > > Author: Pranshu Sharma > > Commit: Pranshu Sharma > > > > remove indent function useless replace by M-q > [...] > > (defvar-keymap haskell-ts-mode-map > > :doc "Keymap for haskell-ts-mode." > > "C-c C-c" 'haskell-ts-compile-region-and-go > > "C-c C-r" 'run-haskell > > - "C-M-q" 'haskell-ts-indent-defun) > > + 'haskell-ts-indent-defun) > > This last line doesn't look right. > [ Also, I'd recommend you use #' to quote function names. ] > > > Stefan > > --0000000000007ed8e2062a8d19d9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Yeah,I realised that soon after, it should be fixed now


On Mon, 30 Dec 2024, 1:15=E2=80=AFam Stefan Monnier, <monnier@iro.umontreal.ca> = wrote:
> branch: elpa/haskell-ts= -mode
> commit df8d3690375a14ede7079640bc326111f1fb3ddd
> Author: Pranshu Sharma <pranshu@pebl>
> Commit: Pranshu Sharma <pranshu@pebl>
>
>=C2=A0 =C2=A0 =C2=A0remove indent function useless replace by M-q
[...]
>=C2=A0 (defvar-keymap=C2=A0 haskell-ts-mode-map
>=C2=A0 =C2=A0 :doc "Keymap for haskell-ts-mode."
>=C2=A0 =C2=A0 "C-c C-c" 'haskell-ts-compile-region-and-go=
>=C2=A0 =C2=A0 "C-c C-r" 'run-haskell
> -=C2=A0 "C-M-q" 'haskell-ts-indent-defun)
> +=C2=A0 =C2=A0'haskell-ts-indent-defun)

This last line doesn't look right.
[ Also, I'd recommend you use #' to quote function names.=C2=A0 ]

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan

--0000000000007ed8e2062a8d19d9--