From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pranshu Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q Date: Tue, 31 Dec 2024 14:26:13 +0530 Message-ID: References: <173549521472.300001.3703786856066422485@vcs3.savannah.gnu.org> <20241229180015.5FF2FD973AF@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000878ccc062a8d1afe" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38597"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 13:16:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSbAv-0009vW-Fx for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 13:16:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSb9m-0004Q2-LA; Tue, 31 Dec 2024 07:15:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSY38-0006Yr-QV for emacs-devel@gnu.org; Tue, 31 Dec 2024 03:56:26 -0500 Original-Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSY37-0003ui-BY for emacs-devel@gnu.org; Tue, 31 Dec 2024 03:56:26 -0500 Original-Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3eba50d6da7so2413603b6e.2 for ; Tue, 31 Dec 2024 00:56:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735635384; x=1736240184; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QPHvUx2U0mWzFxjqYlnac8qJ4ejbS38/7L2+8PfZTfg=; b=TZmtik32hQij3PL+AqZF9N1Asxs3ABLRNgwDXiMW0eA/jzOhuGr1DucHYXYtdbYggl fgz536I7CxOZKc2b4LO0ooDV0tolAWVZbkrxV83/mJVn2HU05ITa5oRa6cmdYH8E1nzm HrsHEmfnse/GUSOpQ1x+maw5oCtDx/xR1q888yAVYR0U3Kx/5l3/xFHmqi54rUsu+dri TGc6DIwkIUih8Z025F5lyR8tTTm9kEnMdHf6MoICFVcgZ7IEJ2b4JwqIkM0imOi1FGTr QjmWd6kCkRnVaDAdZa+kU8Scy5knfuOAwwxw51I2bEN+UD/3BdyG1PrIkzyT4PV6Bl2E 9DPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735635384; x=1736240184; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QPHvUx2U0mWzFxjqYlnac8qJ4ejbS38/7L2+8PfZTfg=; b=ZG+Lqe5iSssdEMSiXRsy9tEr62JGHtcxfAbyPPOR5+VISbfgmehb7GGhK84kUsQs5R IQQ8TyM+605xGeKmn+s8DSnuX9i4KBNoK5LMR2mWfQ3LanXaBzs6MKisQ5dT9vC8ZJfl IEGSskmW/SSGk0NzqCWJWSdh1H28gmxN8Qo32Vkt41JP5sOxh32Rde3i8qrgQCIGR9/w 6MCqXw0Ougfw149GUwbEie9iefHnyG5Ls0NbE4bjgUYZPbMiPgFoHgztHIFZ+WMIIPzq 7bTVHBmBUcwVzhcwXyMCryUF976d8HyXE++EVSvRUAUsfxQC1pYzOu9Vh9rrCnvI7tY9 wRtg== X-Gm-Message-State: AOJu0YzP/yQk8zCa/4NVb/1pzAk1IFjkPr0HJB5lfDsJD8gcUa6KvF1e 0HdjC7AEyaBSw+djL4Omh26Vb3E9rYJIxF5QAYOUFy4Dm00YIK+HayESkCwlumlMZjohHtrz+1Z +AKp5jBOxspPIAoziF7YYfo7CarAreA== X-Gm-Gg: ASbGnctLJowsr1n/YwsQf0SO9QYMdd84Kyx3pYWHxXUZPKZVwK381DJygKMRpBU6NRh 8QudirrfOOe1GZM3EjQzFH99QDxspxsqSAP12FpC9yN/OCsG2q7CTAnBG4tJ/z2k8UOLxTqdv X-Google-Smtp-Source: AGHT+IEF7t/m69CQirtbZcHjFwB+Nuw2yP2QKXKjnHDWlSl+dFZebs92+7dmh1uBkVl0E6hXvU1pVGa7AiloY57eNn4= X-Received: by 2002:a05:6808:3c8e:b0:3ea:66c1:cbef with SMTP id 5614622812f47-3ed890b20fdmr22787211b6e.39.1735635384108; Tue, 31 Dec 2024 00:56:24 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::22d; envelope-from=pranshusharma366@gmail.com; helo=mail-oi1-x22d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 31 Dec 2024 07:15:15 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327492 Archived-At: --000000000000878ccc062a8d1afe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I will do hashtag thing later On Tue, 31 Dec 2024, 2:25=E2=80=AFpm Pranshu, = wrote: > Yeah,I realised that soon after, it should be fixed now > > On Mon, 30 Dec 2024, 1:15=E2=80=AFam Stefan Monnier, > wrote: > >> > branch: elpa/haskell-ts-mode >> > commit df8d3690375a14ede7079640bc326111f1fb3ddd >> > Author: Pranshu Sharma >> > Commit: Pranshu Sharma >> > >> > remove indent function useless replace by M-q >> [...] >> > (defvar-keymap haskell-ts-mode-map >> > :doc "Keymap for haskell-ts-mode." >> > "C-c C-c" 'haskell-ts-compile-region-and-go >> > "C-c C-r" 'run-haskell >> > - "C-M-q" 'haskell-ts-indent-defun) >> > + 'haskell-ts-indent-defun) >> >> This last line doesn't look right. >> [ Also, I'd recommend you use #' to quote function names. ] >> >> >> Stefan >> >> --000000000000878ccc062a8d1afe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I will do hashtag thing later=C2=A0

On Tue, 31 Dec 2024, 2:25=E2=80=AFpm Pranshu, <pranshusharma366@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">

Yeah,I realised that soon afte= r, it should be fixed now


On Mon= , 30 Dec 2024, 1:15=E2=80=AFam Stefan Monnier, <monnier@iro.umontr= eal.ca> wrote:
> branch: = elpa/haskell-ts-mode
> commit df8d3690375a14ede7079640bc326111f1fb3ddd
> Author: Pranshu Sharma <pranshu@pebl>
> Commit: Pranshu Sharma <pranshu@pebl>
>
>=C2=A0 =C2=A0 =C2=A0remove indent function useless replace by M-q
[...]
>=C2=A0 (defvar-keymap=C2=A0 haskell-ts-mode-map
>=C2=A0 =C2=A0 :doc "Keymap for haskell-ts-mode."
>=C2=A0 =C2=A0 "C-c C-c" 'haskell-ts-compile-region-and-go=
>=C2=A0 =C2=A0 "C-c C-r" 'run-haskell
> -=C2=A0 "C-M-q" 'haskell-ts-indent-defun)
> +=C2=A0 =C2=A0'haskell-ts-indent-defun)

This last line doesn't look right.
[ Also, I'd recommend you use #' to quote function names.=C2=A0 ]

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan

--000000000000878ccc062a8d1afe--