Re: ANN: org-sticky-header

[Carsten Dominik <dominik@uva.nl>]

[-- Attachment #1.1: Type: text/plain, Size: 1614 bytes --]

Hi Adam,

here is a new patch with does do this correctly.

Cheers

Carsten

On Wed, Apr 19, 2017 at 7:52 AM, Carsten Dominik <dominik@uva.nl> wrote:

> Hi Adam,
>
> and just after I send this, I now see that the faces of the headings
> in the path are now wrong - so you probably already had gone down
> this path.  Sorry for the noise, need to come up with something better.
>
> Carsten
>
> On Wed, Apr 19, 2017 at 7:46 AM, Carsten Dominik <dominik@uva.nl> wrote:
>
>> Hi Adam,
>>
>> thanks for adding the option to reverse the outline path.  Great thinking
>> about using a different separator for the reversed path!
>>
>> It mostly works - however, if the window is too narrow, the abbreviation
>> ellipses are now applied to the most recent heading instead of to the last
>> one shown.  It would be better to reverse the outline path before sending
>> it into org-format-outline-path, which also saves you the pain to split and
>> rejoin the path string.
>>
>> Please find attached a patch that makes this change.  It also removes the
>> dependence on the string library which is, I think, not by default
>> available in Emacs.
>>
>> Thanks
>>
>> On Wed, Apr 19, 2017 at 1:06 AM, Adam Porter <adam@alphapapa.net> wrote:
>>
>>> Carsten Dominik <dominik@uva.nl> writes:
>>>
>>> Hi Carsten,
>>>
>>> > I am wondering if you would consider the possibility to show on only
>>> > the most recent heading, but, space permitting, the outline path -
>>> > maybe in reverse order as to keep the sticky heading itself in the
>>> > left-most column.
>>>
>>> That's a great idea, I will add that.  Thanks.
>>>
>>>
>>>
>>
>

[-- Attachment #1.2: Type: text/html, Size: 2949 bytes --]

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 1766 bytes --]

--- org-sticky-header.el.orig	2017-04-19 07:33:26.000000000 +0200
+++ org-sticky-header.el	2017-04-19 08:07:41.000000000 +0200
@@ -42,7 +42,6 @@
 ;;; Code:
 
 (require 'dash)
-(require 's)
 
 (defvar org-sticky-header-old-hlf nil
   "Value of the header line when entering org-sticky-header mode.")
@@ -102,14 +101,19 @@
         ('nil (concat org-sticky-header-prefix (org-get-heading t t)))
         ('full (concat org-sticky-header-prefix (org-format-outline-path (org-get-outline-path t) (window-width) nil
                                                                          org-sticky-header-outline-path-separator)))
-        ('reversed (concat org-sticky-header-prefix
-                           ;; Using "🐱" "CAT FACE" as separator character. It needs to be a single character,
-                           ;; otherwise it could get truncated and cause splitting to fail, and the chances of this
-                           ;; character being in a heading is low enough...right?
-                           (->> (org-format-outline-path (org-get-outline-path t) (window-width) nil "🐱")
-                                (s-split "🐱")
-                                (nreverse)
-                                (s-join org-sticky-header-outline-path-reversed-separator))))))))
+        ('reversed
+	 (let ((s (mapconcat
+		   'identity
+		   (org-split-string
+		    (concat org-sticky-header-prefix
+			    (org-format-outline-path
+			     (org-get-outline-path t)
+			     1000 nil "🐱"))
+		    "🐱")
+		   org-sticky-header-outline-path-reversed-separator)))
+	   (if (> (length s) (window-width))
+	       (concat (substring s 0 (- (window-width) 2)) "..")
+	     s)))))))
 
 ;;;###autoload
 (define-minor-mode org-sticky-header-mode