bug#64590: Patch: fix gud-go in gdb-mi.el

bug#64590: Patch: fix gud-go in gdb-mi.el

[Wang Diancheng]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

Hi,
document of gud-go says "Start or continue execution.  Use a prefix to
specify arguments." but it always prompts for program arguments
regardless of whether "C-u" is pressed because arg is numeric prefix
here. The attachment is a patch to change gud-go just prompts if
prefix is not 1.

[-- Attachment #2: gud-go.patch --]
[-- Type: text/x-patch, Size: 830 bytes --]

diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
index 199be3318a1..e81c1452c55 100644
--- a/lisp/progmodes/gdb-mi.el
+++ b/lisp/progmodes/gdb-mi.el
@@ -987,14 +987,14 @@ gdb
 	   "\C-u" "Continue to current line or address.")
   (gud-def
    gud-go (progn
-            (when arg
+            (when (/= arg 1)
               (gud-call (concat "-exec-arguments "
                                 (read-string "Arguments to exec-run: "))))
             (gud-call
              (if gdb-active-process
                  (gdb-gud-context-command "-exec-continue")
                "-exec-run")))
-   "\C-v" "Start or continue execution.  Use a prefix to specify arguments.")
+   "\C-v" "Start or continue execution.  Use a prefix other than 1 to specify arguments.")
 
   ;; For debugging Emacs only.
   (gud-def gud-pp

bug#64590: Patch: fix gud-go in gdb-mi.el

[Eli Zaretskii]

> From: Wang Diancheng <dianchengwang@gmail.com>
> Date: Thu, 13 Jul 2023 12:40:58 +0800
> 
> document of gud-go says "Start or continue execution.  Use a prefix to
> specify arguments." but it always prompts for program arguments
> regardless of whether "C-u" is pressed because arg is numeric prefix
> here.

Right, gud-def specifies '(interactive "p")'.

> The attachment is a patch to change gud-go just prompts if
> prefix is not 1.

This will have the subtlety that "C-u 1 C-v" will fail to ask for
program arguments.  Shouldn't we instead look at current-prefix-arg?

Thanks.

bug#64590: Patch: fix gud-go in gdb-mi.el

[Wang Diancheng]

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Eli Zaretskii <eliz@gnu.org> 于2023年7月13日周四 16:58写道：
>
> > From: Wang Diancheng <dianchengwang@gmail.com>
> > Date: Thu, 13 Jul 2023 12:40:58 +0800
> >
> > document of gud-go says "Start or continue execution.  Use a prefix to
> > specify arguments." but it always prompts for program arguments
> > regardless of whether "C-u" is pressed because arg is numeric prefix
> > here.
>
> Right, gud-def specifies '(interactive "p")'.
>
> > The attachment is a patch to change gud-go just prompts if
> > prefix is not 1.
>
> This will have the subtlety that "C-u 1 C-v" will fail to ask for
> program arguments.  Shouldn't we instead look at current-prefix-arg?
>

Thanks.

Yes, I think it's a good idea. the patch is updated as that.

> Thanks.

[-- Attachment #2: gud-go-v2.patch --]
[-- Type: text/x-patch, Size: 493 bytes --]

diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
index 199be3318a1..a1091de43e9 100644
--- a/lisp/progmodes/gdb-mi.el
+++ b/lisp/progmodes/gdb-mi.el
@@ -987,7 +987,7 @@ gdb
 	   "\C-u" "Continue to current line or address.")
   (gud-def
    gud-go (progn
-            (when arg
+            (when (and current-prefix-arg arg)
               (gud-call (concat "-exec-arguments "
                                 (read-string "Arguments to exec-run: "))))
             (gud-call

bug#64590: Patch: fix gud-go in gdb-mi.el

[Eli Zaretskii]

> From: Wang Diancheng <dianchengwang@gmail.com>
> Date: Fri, 14 Jul 2023 11:06:32 +0800
> Cc: 64590@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> 于2023年7月13日周四 16:58写道：
> >
> > > From: Wang Diancheng <dianchengwang@gmail.com>
> > > Date: Thu, 13 Jul 2023 12:40:58 +0800
> > >
> > > document of gud-go says "Start or continue execution.  Use a prefix to
> > > specify arguments." but it always prompts for program arguments
> > > regardless of whether "C-u" is pressed because arg is numeric prefix
> > > here.
> >
> > Right, gud-def specifies '(interactive "p")'.
> >
> > > The attachment is a patch to change gud-go just prompts if
> > > prefix is not 1.
> >
> > This will have the subtlety that "C-u 1 C-v" will fail to ask for
> > program arguments.  Shouldn't we instead look at current-prefix-arg?
> >
> 
> Thanks.
> 
> Yes, I think it's a good idea. the patch is updated as that.

Thanks, installed on the emacs-29 branch, and closing the bug.

With this contribution, you have exhausted the amount of changes we
can accept from you without a copyright assignment.  Would you like to
start the legal paperwork of assigning to the FSF the copyright for
your changes, so that we could in the future accept more contributions
from you without limitations?  If yes, I will send you the form to
fill.

bug#64590: Patch: fix gud-go in gdb-mi.el

[Wang Diancheng]

Eli Zaretskii <eliz@gnu.org> 于2023年7月15日周六 16:42写道：
>
> > From: Wang Diancheng <dianchengwang@gmail.com>
> > Date: Fri, 14 Jul 2023 11:06:32 +0800
> > Cc: 64590@debbugs.gnu.org
> >
> > Eli Zaretskii <eliz@gnu.org> 于2023年7月13日周四 16:58写道：
> > >
> > > > From: Wang Diancheng <dianchengwang@gmail.com>
> > > > Date: Thu, 13 Jul 2023 12:40:58 +0800
> > > >
> > > > document of gud-go says "Start or continue execution.  Use a prefix to
> > > > specify arguments." but it always prompts for program arguments
> > > > regardless of whether "C-u" is pressed because arg is numeric prefix
> > > > here.
> > >
> > > Right, gud-def specifies '(interactive "p")'.
> > >
> > > > The attachment is a patch to change gud-go just prompts if
> > > > prefix is not 1.
> > >
> > > This will have the subtlety that "C-u 1 C-v" will fail to ask for
> > > program arguments.  Shouldn't we instead look at current-prefix-arg?
> > >
> >
> > Thanks.
> >
> > Yes, I think it's a good idea. the patch is updated as that.
>
> Thanks, installed on the emacs-29 branch, and closing the bug.
>

Thanks.

> With this contribution, you have exhausted the amount of changes we
> can accept from you without a copyright assignment.  Would you like to
> start the legal paperwork of assigning to the FSF the copyright for
> your changes, so that we could in the future accept more contributions
> from you without limitations?  If yes, I will send you the form to
> fill.

My copyright assignment has been in progress.