On Sun, Aug 8, 2021 at 12:02 PM Eli Zaretskii wrote: > > From: Anand Tamariya > > Date: Fri, 6 Aug 2021 14:33:48 +0530 > > > > Here's a patch for changing the font family on the fly. It's similar to > > changing font weight using the keyboard. > > Thanks, but how is this supposed to work? After applying the patch > and loading facemenu, "M-x facemenu-set-family RET" does nothing, not > even prompts for the font family; and clicking > > Edit->Text Properties->Face->family > > from the menu bar just shows "menu-bar edit Text Properties fc f" in > the echo area. > > I think one problem is that the facemenu machinery, as you use it, > expects "family" to be a face, and there's no such face. > > Did you test this with Emacs 28 from the master branch? Or what am I > missing? > > P.S. Please also provide a doc string for the new function(s), and add > a :version tag to any defcustom you add or change. > You are right. I don't understand the face menu system well. It worked for me because I was evaluating the changes in a running instance. Once I start a new instance, I can't seem to get it working without re-evaluating 'facemenu-keybindings' followed by (facemenu-update). Also, it's only supposed to work on a selection of text, i.e. you select some text and then change the font family for the selection.